| Subject: | pid_running: redundant $pid argument |
The pid_running() function has currently the following lines:
my ( $self, $pid ) = @_;
$pid ||= $self->read_pid;
Unfortunately $pid is nowhere used in this function. Instead $self->pid is used here. So either $pid is redundant, and the argument may be removed (and all callers fixed), or $self->pid should be replaced by $pid here.