Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-GithubMeta CPAN distribution.

Report information
The Basics
Id: 99820
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-GithubMeta
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sun Oct 26 13:19:00 2014 ether [...] cpan.org - Ticket created
Subject: [GithubMeta] not using Git::Wrapper
e.g. https://metacpan.org/source/BINGOS/Dist-Zilla-Plugin-GithubMeta-0.46/lib/Dist/Zilla/Plugin/GithubMeta.pm#L141 this would be nicer with Git::Wrapper instead of raw commands.
  Sat Dec 20 10:38:36 2014 dolmen [...] cpan.org - Correspondence added
Le 2014-10-26 18:19:00, ETHER a écrit :
Show quoted text
> e.g. https://metacpan.org/source/BINGOS/Dist-Zilla-Plugin-GithubMeta-
> 0.46/lib/Dist/Zilla/Plugin/GithubMeta.pm#L141
>
> this would be nicer with Git::Wrapper instead of raw commands.

No, it would be much simpler to replace that code with a simple call to:
    git config --local --get remote.$remote.url

No parsing of the output would be required.


-- 
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/
  Sat Dec 20 10:38:36 2014 The RT System itself - Status changed from 'new' to 'open'
  Sat Dec 20 11:00:28 2014 dolmen [...] cpan.org - Correspondence added
Le 2014-12-20 16:38:36, DOLMEN a écrit :
Show quoted text
> No, it would be much simpler to replace that code with a simple call to:
> git config --local --get remote.$remote.url

Patch available: https://github.com/bingos/dist-zilla-plugin-githubmeta/pull/8

-- 
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/