Bug #99810 for Text-Hunspell: Does not compile on non-gcc systems (e.g. clang)

Sun Oct 26 05:41:42 2014 SREZIC [...] cpan.org - Ticket created

Subject:

Does not compile on non-gcc systems (e.g. clang)

FreeBSD 10.0 (and possible other operating systems) does not ship gcc/g++ anymore, but instead clang/clang++. So compiling this distribution fails: g++ -c -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -O -DVERSION=\"2.09\" -DXS_VERSION=\"2.09\" -DPIC -fPIC "-I/usr/perl5.18.2/lib/5.18.2/amd64-freebsd/CORE" Hunspell.c g++: not found Probabably it's best to not hardcode "g++" here, but use instead "c++", which is understood by both gcc and clang based systems. Or check perl's config for the correct c/c++ compiler.

Tue May 12 05:00:47 2015 cosimo [...] cpan.org - Correspondence added

Il Dom 26 Ott 2014 05:41:42, SREZIC ha scritto: Show quoted text

> FreeBSD 10.0 (and possible other operating systems) does not ship > gcc/g++ anymore, but instead clang/clang++. So compiling this > distribution fails: > > g++ -c -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing > -pipe -fstack-protector -I/usr/local/include -O -DVERSION=\"2.09\" > -DXS_VERSION=\"2.09\" -DPIC -fPIC "-I/usr/perl5.18.2/lib/5.18.2/amd64- > freebsd/CORE" Hunspell.c > g++: not found > > Probabably it's best to not hardcode "g++" here, but use instead > "c++", which is understood by both gcc and clang based systems. Or > check perl's config for the correct c/c++ compiler.

Thanks for the report. What do you think of: use Config; my $CC = $ENV{'CXX'} || $Config{cpp} || 'c++'; Actually I'm not sure why of $ENV{'CXX'}, that predates my maintainership.

Tue May 12 05:00:47 2015 The RT System itself - Status changed from 'new' to 'open'

Tue May 12 08:22:12 2015 cosimo [...] cpan.org - Correspondence added

Il Mar 12 Maggio 2015 05:00:47, COSIMO ha scritto: Show quoted text

> Il Dom 26 Ott 2014 05:41:42, SREZIC ha scritto:

> > FreeBSD 10.0 (and possible other operating systems) does not ship > > gcc/g++ anymore, but instead clang/clang++. So compiling this > > distribution fails: > > > > g++ -c -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing > > -pipe -fstack-protector -I/usr/local/include -O -DVERSION=\"2.09\" > > -DXS_VERSION=\"2.09\" -DPIC -fPIC "-I/usr/perl5.18.2/lib/5.18.2/amd64- > > freebsd/CORE" Hunspell.c > > g++: not found > > > > Probabably it's best to not hardcode "g++" here, but use instead > > "c++", which is understood by both gcc and clang based systems. Or > > check perl's config for the correct c/c++ compiler.

> > Thanks for the report. > > What do you think of: > > use Config; > my $CC = $ENV{'CXX'} || $Config{cpp} || 'c++'; > > Actually I'm not sure why of $ENV{'CXX'}, that predates my maintainership. >

Take it back... $Config{cpp} doesn't do what I want (preprocessor vs compiler). So I'll just push 2.11 out to CPAN with 'c++' instead of 'g++' like you suggested. Another idea, suggested here: https://github.com/cosimo/perl5-text-hunspell/pull/7 is to use ExtUtils::CppGuess.

Wed May 13 01:46:30 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-05-12 08:22:12, COSIMO wrote: Show quoted text

> Il Mar 12 Maggio 2015 05:00:47, COSIMO ha scritto:

> > Il Dom 26 Ott 2014 05:41:42, SREZIC ha scritto:

> > > FreeBSD 10.0 (and possible other operating systems) does not ship > > > gcc/g++ anymore, but instead clang/clang++. So compiling this > > > distribution fails: > > > > > > g++ -c -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict- > > > aliasing > > > -pipe -fstack-protector -I/usr/local/include -O > > > -DVERSION=\"2.09\" > > > -DXS_VERSION=\"2.09\" -DPIC -fPIC "- > > > I/usr/perl5.18.2/lib/5.18.2/amd64- > > > freebsd/CORE" Hunspell.c > > > g++: not found > > > > > > Probabably it's best to not hardcode "g++" here, but use instead > > > "c++", which is understood by both gcc and clang based systems. Or > > > check perl's config for the correct c/c++ compiler.

> > > > Thanks for the report. > > > > What do you think of: > > > > use Config; > > my $CC = $ENV{'CXX'} || $Config{cpp} || 'c++'; > > > > Actually I'm not sure why of $ENV{'CXX'}, that predates my > > maintainership. > >

> > Take it back... $Config{cpp} doesn't do what I want (preprocessor vs > compiler). > So I'll just push 2.11 out to CPAN with 'c++' instead of 'g++' like > you suggested.

This works great --- the module now compiles on all my FreeBSD and Linux systems. Show quoted text

> > Another idea, suggested here: > > https://github.com/cosimo/perl5-text-hunspell/pull/7 > > is to use ExtUtils::CppGuess.

Wed May 13 01:58:13 2015 cosimo [...] cpan.org - Correspondence added

We're good then :-)

Wed May 13 01:58:14 2015 cosimo [...] cpan.org - Status changed from 'open' to 'resolved'

Wed May 13 01:58:15 2015 cosimo [...] cpan.org - Fixed in 2.11 added