Skip Menu |

This queue is for tickets about the Finance-Quote CPAN distribution.

Report information
The Basics
Id: 99784
Status: patched
Worked: 5 min
Priority: 0/
Queue: Finance-Quote
People
Owner: Nobody in particular
Requestors: rt.cpan.simon [...] arlott.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 1.35
Fixed in: 1.37

History Show all quoted text
  Fri Oct 24 16:47:46 2014 rt.cpan.simon [...] arlott.org - Ticket created
Subject: Finance::Quote::MStaruk does not detect the price correctly
MStaruk returns the "Share Class Size (Mil)" value instead of the "NAV" value. Example: GB00B7W6PR65 should be 277.35 GBX not 70.23 GBP
  Tue Feb 24 07:11:54 2015 paul [...] city-fan.org - Correspondence added
From: paul [...] city-fan.org
On Fri Oct 24 16:47:46 2014, SimonArlott wrote: Show quoted text
> MStaruk returns the "Share Class Size (Mil)" value instead of the > "NAV" value. > > Example: GB00B7W6PR65 should be 277.35 GBX not 70.23 GBP
Attached patch works for me.
Subject: Finance-Quote-1.37-rt99784.patch
--- lib/Finance/Quote/MStaruk.pm +++ lib/Finance/Quote/MStaruk.pm @@ -157,7 +157,7 @@ my ($currency, $date, $price, $pchange); if ($webdoc =~ - m[<td class="line heading">ISIN</td>.*<span class="heading"><br />([0-9]{2}/[0-9]{2}/[0-9]{4})</span>.*([A-Z]{3}).([0-9\.]+).*>([0-9\.\-]+)] ) + m[<td class="line heading">NAV<span class="heading"><br />([0-9]{2}/[0-9]{2}/[0-9]{4})</span>.*([A-Z]{3}).([0-9\.]+).*>([0-9\.\-]+)] ) { $date = $1;
  Tue Feb 24 07:11:55 2015 The RT System itself - Status changed from 'new' to 'open'
  Thu Feb 26 04:32:26 2015 eco [...] ecocode.net - Correspondence added 5 min
Patch applied. Thanks -- Erik
  Thu Feb 26 04:32:28 2015 eco [...] ecocode.net - Status changed from 'open' to 'patched'
  Thu Feb 26 04:32:28 2015 eco [...] ecocode.net - Fixed in 1.37 added