Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Git-Hooks CPAN distribution.

Report information
The Basics
Id: 99537
Status: resolved
Priority: 0/
Queue: Git-Hooks
People
Owner: GNUSTAVO [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in:
  • 1.1.0-TRIAL
  • 1.2.0
  • 1.6.2
  • 1.6.3
  • 1.6.4
  • 1.6.5
Fixed in: 1.6.7

History Show all quoted text
  Thu Oct 16 15:01:29 2014 SREZIC [...] cpan.org - Ticket created
Subject: Tests fail with a non-English locale
Tests fail if a new git version with localization enabled is used (e.g. 1.8.x) and a non-English locale is set. See http://matrix.cpantesters.org/?dist=Git-Hooks for a fail/pass overview. Probably you have to force a "C" locale before calling git.
  Thu Oct 16 22:38:27 2014 GNUSTAVO [...] cpan.org - Taken
  Thu Oct 16 22:40:31 2014 GNUSTAVO [...] cpan.org - Correspondence added
On Thu Oct 16 15:01:29 2014, SREZIC wrote: Show quoted text
> Tests fail if a new git version with localization enabled is used > (e.g. 1.8.x) and a non-English locale is set. See > http://matrix.cpantesters.org/?dist=Git-Hooks for a fail/pass > overview. Probably you have to force a "C" locale before calling git.
Yes. I was setting the LC_MESSAGES environment variable but LC_ALL has precedence over it. I've replaced the setting (in t/test-functions.pl) and it worked. I'll incorporate the fix in the next release. Thank you!
  Thu Oct 16 22:40:32 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Feb 01 08:42:14 2015 SREZIC [...] cpan.org - Correspondence added
On 2014-10-16 22:40:31, GNUSTAVO wrote: Show quoted text
> On Thu Oct 16 15:01:29 2014, SREZIC wrote:
> > Tests fail if a new git version with localization enabled is used > > (e.g. 1.8.x) and a non-English locale is set. See > > http://matrix.cpantesters.org/?dist=Git-Hooks for a fail/pass > > overview. Probably you have to force a "C" locale before calling git.
> > Yes. I was setting the LC_MESSAGES environment variable but LC_ALL has > precedence over it. I've replaced the setting (in t/test-functions.pl) > and it worked. > > I'll incorporate the fix in the next release. >
It seems that there are still locale-specific fails. See http://analysis.cpantesters.org/solved?distv=Git-Hooks-1.6.2#env%3ALC_ALL (fails if LC_ALL=de_DE.ISO8859-1 or de_DE.UTF-8 is set)
  Sun Feb 01 08:42:39 2015 SREZIC [...] cpan.org - Broken in 1.6.2 added
  Sat Feb 14 02:48:42 2015 SREZIC [...] cpan.org - Broken in 1.6.3 added
  Sat Feb 14 02:48:42 2015 SREZIC [...] cpan.org - Broken in 1.6.4 added
  Sat Feb 14 02:48:42 2015 SREZIC [...] cpan.org - Broken in 1.6.5 added
  Sat Feb 14 02:49:05 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-02-01 08:42:14, SREZIC wrote: Show quoted text
> On 2014-10-16 22:40:31, GNUSTAVO wrote:
> > On Thu Oct 16 15:01:29 2014, SREZIC wrote:
> > > Tests fail if a new git version with localization enabled is used > > > (e.g. 1.8.x) and a non-English locale is set. See > > > http://matrix.cpantesters.org/?dist=Git-Hooks for a fail/pass > > > overview. Probably you have to force a "C" locale before calling git.
> > > > Yes. I was setting the LC_MESSAGES environment variable but LC_ALL has > > precedence over it. I've replaced the setting (in t/test-functions.pl) > > and it worked. > > > > I'll incorporate the fix in the next release. > >
> > It seems that there are still locale-specific fails. See > http://analysis.cpantesters.org/solved?distv=Git-Hooks-1.6.2#env%3ALC_ALL > (fails if LC_ALL=de_DE.ISO8859-1 or de_DE.UTF-8 is set)
And still fails with the fresh 1.6.6.
  Sun Feb 15 16:43:18 2015 GNUSTAVO [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #99537] Tests fail with a non-English locale
Date: Sun, 15 Feb 2015 19:42:39 -0200
To: bug-Git-Hooks [...] rt.cpan.org
From: Gustavo Leite de Mendonça Chaves <gnustavo [...] cpan.org>
2015-02-14 5:49 GMT-02:00 Slaven_Rezic via RT <bug-Git-Hooks@rt.cpan.org>: Show quoted text
> > And still fails with the fresh 1.6.6. >
I couldn't reproduce the error myself. I tried to set the LC_ALL and other environment variables but since I explicitly set LC_ALL in t/ test-functions.pl I don't understand in what context it fails. To bypass the problem I changed the t/02-gerrit-change-id.t test file so that it doesn't rely anymore on the particular message produced by Git. Instead it only cares about its exit code. I hope this avoids the problem altogether. Let's see what happens on the 1.6.7 version I just released. Thank you.
  Tue Feb 17 01:23:04 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-02-15 16:43:18, GNUSTAVO wrote: Show quoted text
> 2015-02-14 5:49 GMT-02:00 Slaven_Rezic via RT <bug-Git-Hooks@rt.cpan.org>: >
> > > > And still fails with the fresh 1.6.6. > >
> > I couldn't reproduce the error myself. I tried to set the LC_ALL and other > environment variables but since I explicitly set LC_ALL in t/ > test-functions.pl I don't understand in what context it fails. > > To bypass the problem I changed the t/02-gerrit-change-id.t test file so > that it doesn't rely anymore on the particular message produced by Git. > Instead it only cares about its exit code. > > I hope this avoids the problem altogether. Let's see what happens on the > 1.6.7 version I just released. >
Looks good so far: http://matrix.cpantesters.org/?dist=Git-Hooks+1.6.7
  Tue Feb 17 01:23:05 2015 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Feb 17 01:23:05 2015 SREZIC [...] cpan.org - Fixed in 1.6.7 added