Bug #99481 for WWW-PushBullet: Use of uninitialized value in string eq

Tue Oct 14 08:30:42 2014 simon [...] aldrich.eu - Ticket created

Subject:	Use of uninitialized value in string eq
Date:	Tue, 14 Oct 2014 13:30:28 +0100
To:	bug-WWW-PushBullet [...] rt.cpan.org
From:	Simon Aldrich <simon [...] aldrich.eu>

With WWW::PushBullet v1.2.4 I'm getting the following warning when using 'push_note': 'Use of uninitialized value in string eq at /usr/local/share/perl/5.18.2/WWW/PushBullet.pm line 211.' My push_note call is as documented, i.e.: $pb->push_note( { device_id => $iden, title => $title, body => $body } ); It seems that in 'sub _pushes' '$content->[$i]' may not defined. The following patch seems to sort out the problem: 211c211,214 < $type = $content->[$i + 1] if ($content->[$i] eq 'type'); --- Show quoted text

> if (defined($content->[$i]) && ($content->[$i] eq 'type')) > { > $type = $content->[$i + 1]; > }

Patch file attached Regards Simon Aldrich

Message body is not shown because sender requested not to inline it.

Wed Oct 15 18:11:15 2014 sebthebert [...] gmail.com - Taken

Wed Oct 15 18:14:28 2014 sebthebert [...] gmail.com - Correspondence added

Thanks for the feedback. I'm not really happy about what I did with these functions. I will not just apply your patch, but rewrite a bigger part of my code before the end of the week. Regards, Le Mar 14 Oct 2014 08:30:42, simon@aldrich.eu a écrit : Show quoted text

> With WWW::PushBullet v1.2.4 I'm getting the following warning when using > 'push_note': > > 'Use of uninitialized value in string eq at > /usr/local/share/perl/5.18.2/WWW/PushBullet.pm line 211.' > > My push_note call is as documented, i.e.: > > $pb->push_note( { device_id => $iden, > title => $title, > body => $body } ); > > It seems that in 'sub _pushes' '$content->[$i]' may not defined. The > following patch seems to sort out the problem: > > 211c211,214 > < $type = $content->[$i + 1] if ($content->[$i] eq 'type'); > ---

> > if (defined($content->[$i]) && ($content->[$i] eq 'type')) > > { > > $type = $content->[$i + 1]; > > }

> > Patch file attached > > Regards > > Simon Aldrich

Wed Oct 15 18:14:28 2014 The RT System itself - Status changed from 'new' to 'open'

Sun Nov 02 12:08:24 2014 sebthebert [...] gmail.com - Correspondence added

I changed a lot of things in WWW::PushBullet v1.4. Your issues should be fixed. If not, please reopen a bug report on Github. https://github.com/sebthebert/WWW-PushBullet/issues Le Mer 15 Oct 2014 18:14:28, STHEBERT a écrit : Show quoted text

> Thanks for the feedback. > > I'm not really happy about what I did with these functions. > > I will not just apply your patch, but rewrite a bigger part of my code > before the end of the week. > > > Regards, > > Le Mar 14 Oct 2014 08:30:42, simon@aldrich.eu a écrit :

> > With WWW::PushBullet v1.2.4 I'm getting the following warning when > > using > > 'push_note': > > > > 'Use of uninitialized value in string eq at > > /usr/local/share/perl/5.18.2/WWW/PushBullet.pm line 211.' > > > > My push_note call is as documented, i.e.: > > > > $pb->push_note( { device_id => $iden, > > title => $title, > > body => $body } ); > > > > It seems that in 'sub _pushes' '$content->[$i]' may not defined. The > > following patch seems to sort out the problem: > > > > 211c211,214 > > < $type = $content->[$i + 1] if ($content->[$i] eq 'type'); > > ---

> > > if (defined($content->[$i]) && ($content->[$i] eq 'type')) > > > { > > > $type = $content->[$i + 1]; > > > }

> > > > Patch file attached > > > > Regards > > > > Simon Aldrich

Sun Nov 02 12:08:24 2014 sebthebert [...] gmail.com - Status changed from 'open' to 'resolved'

Bug #99481 for WWW-PushBullet: Use of uninitialized value in string eq

Preferred bug tracker