Bug #99460 for CGI-Application-Plugin-Authentication: libcgi-application-plugin-authentication-perl: FTBFS

Mon Oct 13 10:47:13 2014 gregoa [...] cpan.org - Ticket created

From:	gregoa [...] cpan.org
Subject:	libcgi-application-plugin-authentication-perl: FTBFS - tests fail with additional warnings

We have the following bug reported to the Debian package of CGI-Application-Plugin-Authentication (https://bugs.debian.org/765051): It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks! ------8<-----------8<-----------8<-----------8<-----------8<----- Package: libcgi-application-plugin-authentication-perl Version: 0.20-2 Severity: serious Usertags: goto-cc During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder and pbuilder) the build failed with the following error. [...] [...] Test Summary Report ------------------- t/03_login_box_basic.t (Wstat: 256 Tests: 6 Failed: 1) Failed test: 6 Non-zero exit status: 1 t/03_missing_color.t (Wstat: 512 Tests: 4 Failed: 2) Failed tests: 2, 4 Non-zero exit status: 2 t/53_driver_dbi_bad.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 5 Non-zero exit status: 1 t/53_driver_dbi_syntax.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 t/61_cookie_badargs.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 t/61_store_cookie_noexpiry.t (Wstat: 1024 Tests: 21 Failed: 4) Failed tests: 4, 10, 16, 21 Non-zero exit status: 4 t/61_store_cookie_other.t (Wstat: 1024 Tests: 25 Failed: 4) Failed tests: 4, 10, 16, 25 Non-zero exit status: 4 Files=44, Tests=575, 14 wallclock secs ( 0.34 usr 0.17 sys + 8.71 cusr 1.12 csys = 10.34 CPU) Result: FAIL Failed 7/44 test programs. 14/575 subtests failed. dh_auto_test: perl Build test --test_files=t/01_basic.t t/02_config.t t/03_authenticate.t t/03_destination.t t/03_login_box_basic.t t/03_login_box_other.t t/03_missing_color.t t/04_attributes.t t/05_autorunmode.t t/06_timeout.t t/07_protected_runmodes.t t/40_encoder_crypt.t t/40_encoder_lc.t t/40_encoder_md5.t t/40_encoder_sha1.t t/40_encoder_strip.t t/40_encoder_uc.t t/50_driver_missing_modules.t t/50_driver_undefined.t t/51_driver_dummy.t t/52_driver_generic.t t/53_driver_dbi.t t/53_driver_dbi_bad.t t/53_driver_dbi_die.t t/53_driver_dbi_syntax.t t/54_driver_htpasswd.t t/55_driver_authensimple.t t/55_driver_authensimple_die.t t/55_driver_missing_authensimple.t t/60_parsimony.t t/60_store.t t/60_store_cookie.t t/60_store_session.t t/61_cookie_badargs.t t/61_store_cookie_noexpiry.t t/61_store_cookie_other.t t/70_action_dispatch.t t/80_devpopup.t t/98_pod.t t/99_pod_coverage.t t/changes.t t/manifest.t t/podspell.t t/prereq.t returned exit code 255 debian/rules:10: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 255 make[1]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-libcgi-application-plugin-authentication-perl/libcgi-application-plugin-authentication-perl-0.20' debian/rules:6: recipe for target 'build' failed make: *** [build] Error 2 The full build log is attached; please do let me know if the problem is unreproducible, in which case I shall try to investigate further. Best, Michael ------8<-----------8<-----------8<-----------8<-----------8<----- Thanks for considering, gregor herrmann, Debian Perl Group

Mon Oct 13 11:16:13 2014 gregoa [...] debian.org - Correspondence added

CC:	765051 [...] bugs.debian.org
Subject:	Re: [rt.cpan.org #99460] AutoReply: libcgi-application-plugin-authentication-perl: FTBFS - tests fail with additional warnings
Date:	Mon, 13 Oct 2014 17:15:42 +0200
To:	Bugs in CGI-Application-Plugin-Authentication via RT <bug-CGI-Application-Plugin-Authentication [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

Control: tag -1 + patch On Mon, 13 Oct 2014 10:47:13 -0400, Bugs in CGI-Application-Plugin-Authentication via RT wrote: Show quoted text

> ------------------------------------------------------------------------- > We have the following bug reported to the Debian package of > CGI-Application-Plugin-Authentication > (https://bugs.debian.org/765051): > > It doesn't seem to be a bug in the packaging, so you may want to take > a look. Thanks!

I'm attaching a preliminary patch. With it, the test output looks the same as in jessie (i.e. with an older CGI.pm). Comments? Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: John Lennon: Imagine

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

Mon Oct 13 11:16:13 2014 The RT System itself - Status changed from 'new' to 'open'

Tue May 12 11:28:12 2015 ppisar [...] redhat.com - Correspondence added

From:

ppisar [...] redhat.com

Dne Po 13.říj.2014 10:47:13, GREGOA napsal(a): Show quoted text

> Test Summary Report > ------------------- > t/03_login_box_basic.t (Wstat: 256 Tests: 6 Failed: 1) > Failed test: 6 > Non-zero exit status: 1 > t/03_missing_color.t (Wstat: 512 Tests: 4 Failed: 2) > Failed tests: 2, 4 > Non-zero exit status: 2 > t/53_driver_dbi_bad.t (Wstat: 256 Tests: 9 Failed: 1) > Failed test: 5 > Non-zero exit status: 1 > t/53_driver_dbi_syntax.t (Wstat: 256 Tests: 2 Failed: 1) > Failed test: 2 > Non-zero exit status: 1 > t/61_cookie_badargs.t (Wstat: 256 Tests: 2 Failed: 1) > Failed test: 2 > Non-zero exit status: 1 > t/61_store_cookie_noexpiry.t (Wstat: 1024 Tests: 21 Failed: 4) > Failed tests: 4, 10, 16, 21 > Non-zero exit status: 4 > t/61_store_cookie_other.t (Wstat: 1024 Tests: 25 Failed: 4) > Failed tests: 4, 10, 16, 25 > Non-zero exit status: 4 > Files=44, Tests=575, 14 wallclock secs ( 0.34 usr 0.17 sys + 8.71 > cusr 1.12 csys = 10.34 CPU) > Result: FAIL

There are more warnings than the CGI one preventing from passing tests now. Attached patch fixes all the warnings displayed when running the tests. -- Petr

Subject:

CGI-Application-Plugin-Authentication-0.20-Silent-various-warnings.patch

From ef949f140931537af09d460d4b5d8be74d2fab4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 12 May 2015 17:14:55 +0200 Subject: [PATCH] Silent various warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some of them fail tests which sniffs for warnings. Some warning were introduced by CGI 4.05 or recent (5.20) perl. <https://rt.cpan.org/Public/Bug/Display.html?id=99460> Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com> --- lib/CGI/Application/Plugin/Authentication.pm | 3 ++- lib/CGI/Application/Plugin/Authentication/Driver/Filter/crypt.pm | 2 +- lib/CGI/Application/Plugin/Authentication/Driver/Filter/md5.pm | 2 +- lib/CGI/Application/Plugin/Authentication/Driver/Filter/sha1.pm | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/CGI/Application/Plugin/Authentication.pm b/lib/CGI/Application/Plugin/Authentication.pm index 83230d2..2908925 100644 --- a/lib/CGI/Application/Plugin/Authentication.pm +++ b/lib/CGI/Application/Plugin/Authentication.pm @@ -767,6 +767,7 @@ sub is_protected_runmode { my $self = shift; my $runmode = shift; + require overload; foreach my $runmode_test ($self->protected_runmodes) { if (overload::StrVal($runmode_test) =~ /^Regexp=/) { # We were passed a regular expression @@ -1205,7 +1206,7 @@ sub initialize { my $field_names = $config->{CREDENTIALS} || [qw(authen_username authen_password)]; my $query = $self->_cgiapp->query; - my @credentials = map { $query->param($_) } @$field_names; + my @credentials = map { scalar $query->param($_) } @$field_names; if ($credentials[0]) { # The user is trying to login # make sure if they are already logged in, that we log them out first diff --git a/lib/CGI/Application/Plugin/Authentication/Driver/Filter/crypt.pm b/lib/CGI/Application/Plugin/Authentication/Driver/Filter/crypt.pm index 48dd28d..07377d4 100644 --- a/lib/CGI/Application/Plugin/Authentication/Driver/Filter/crypt.pm +++ b/lib/CGI/Application/Plugin/Authentication/Driver/Filter/crypt.pm @@ -15,7 +15,7 @@ sub check { sub filter { my $class = shift; - my $param = lc shift; # not used + shift; # not used my $plain = shift; my $salt = shift; if (!$salt) { diff --git a/lib/CGI/Application/Plugin/Authentication/Driver/Filter/md5.pm b/lib/CGI/Application/Plugin/Authentication/Driver/Filter/md5.pm index 4b51ecf..56a0bea 100644 --- a/lib/CGI/Application/Plugin/Authentication/Driver/Filter/md5.pm +++ b/lib/CGI/Application/Plugin/Authentication/Driver/Filter/md5.pm @@ -25,7 +25,7 @@ sub check { sub filter { my $class = shift; - my $param = lc shift || 'hex'; + my $param = lc( shift || 'hex' ); my $plain = shift; Digest::MD5->require || die "Digest::MD5 is required to check MD5 passwords"; diff --git a/lib/CGI/Application/Plugin/Authentication/Driver/Filter/sha1.pm b/lib/CGI/Application/Plugin/Authentication/Driver/Filter/sha1.pm index 610e9fa..b9f2f24 100644 --- a/lib/CGI/Application/Plugin/Authentication/Driver/Filter/sha1.pm +++ b/lib/CGI/Application/Plugin/Authentication/Driver/Filter/sha1.pm @@ -25,7 +25,7 @@ sub check { sub filter { my $class = shift; - my $param = lc shift || 'hex'; + my $param = lc( shift || 'hex' ); my $plain = shift; Digest::SHA->require || die "Digest::SHA is required to check SHA1 passwords"; -- 2.1.0

Bug #99460 for CGI-Application-Plugin-Authentication: libcgi-application-plugin-authentication-perl: FTBFS - tests fail with additional warnings