Bug #99410 for RT-Extension-RepeatTicket: $RepeatTicketLeadTime can not be 0

Hi, In version 0.07 of RT::Extension::RepeatTicket, $RepeatTicketLeadTime defaults to 14. When overruling this default via etc/RT_SiteConfig.pm and using a value of 1, everything still works. But if we do not want a lead time, i.e. a value of 0, the default becomes 14. The use case for a zero lead time is that we want to have daily operationals and we want them to pop up, at, say 07:00 (AM). By setting $RepeatTicketLeadTime to 0, we want to prevent clobbering up the back officers' overview of outstanding tickets. The following patch seems to work for us: [root@rt ~]# diff -u /opt/rt4/local/plugins/RT-Extension-RepeatTicket/html/Ticket/Elements/EditRecurrence{-dd20141010BD,} --- /opt/rt4/local/plugins/RT-Extension-RepeatTicket/html/Ticket/Elements/EditRecurrence-dd20141010BD 2014-02-13 23:10:12.000000000 +0100 +++ /opt/rt4/local/plugins/RT-Extension-RepeatTicket/html/Ticket/Elements/EditRecurrence 2014-10-10 09:02:06.701526871 +0200 @@ -231,7 +231,8 @@ $ARGSRef->{'repeat-details-monthly'} ||= 'day'; $ARGSRef->{'repeat-details-yearly'} ||= 'day'; $ARGSRef->{'repeat-end'} ||= 'none'; -$ARGSRef->{'repeat-lead-time'} ||= RT->Config->Get('RepeatTicketLeadTime') || 14; +$ARGSRef->{'repeat-lead-time'} = RT->Config->Get('RepeatTicketLeadTime') unless (defined ($ARGSRef->{'repeat-lead-time'})); +$ARGSRef->{'repeat-lead-time'} = 14 unless (defined ($ARGSRef->{'repeat-lead-time'})); $ARGSRef->{'repeat-coexistent-number'} ||= RT->Config->Get('RepeatTicketCoexistentNumber') || 1; my $input = sub { [root@rt ~]# FWIW: [root@rt ~]# perl -v This is perl, v5.10.1 (*) built for x86_64-linux-thread-multi Copyright 1987-2009, Larry Wall Perl may be copied only under the terms of either the Artistic License or the GNU General Public License, which may be found in the Perl 5 source kit. Complete documentation for Perl, including FAQ lists, should be found on this system using "man perl" or "perldoc perl". If you have access to the Internet, point your browser at http://www.perl.org/, the Perl Home Page. [root@rt ~]# uname -a Linux rt.plusine.intern 2.6.32-431.23.3.el6.x86_64 #1 SMP Thu Jul 31 17:20:51 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux [root@rt ~]# Best regards, Bart Dopheide