Bug #99378 for File-Which: dependencies: declare Test::More, Test::Script as test

Wed Oct 08 08:49:15 2014 dolmen [...] cpan.org - Ticket created

Subject:

dependencies: declare Test::More, Test::Script as test_requires

From Makefile.PL:

'PREREQ_PM' => {

'Exporter' => 0,

'Getopt::Std' => 0,

'File::Spec' => '0.60',

'Test::More' => '0.80',

'Test::Script' => '1.05',

},

This implies that Test::More and Test::Script are required at runtime.

The Makefile.PL should be upgraded to have more granular dependencies and declare Test::More and Test::Script dependencies only for the test phase.

--
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/

Mon Feb 02 14:23:29 2015 PLICEASE [...] cpan.org - Cc PLICEASE added

Mon Feb 02 14:24:13 2015 PLICEASE [...] cpan.org - Correspondence added

This patch would address this ticket: diff --git a/Makefile.PL b/Makefile.PL index a9bd49c..9ba8eb5 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -10,9 +10,17 @@ WriteMakefile( 'Exporter' => 0, 'Getopt::Std' => 0, 'File::Spec' => '0.60', - 'Test::More' => '0.80', - 'Test::Script' => '1.05', + ($ExtUtils::MakeMaker::VERSION ge '6.34' ? ( + 'Test::More' => '0.80', + 'Test::Script' => '1.05', + ) : () ), }, + ($ExtUtils::MakeMaker::VERSION ge '6.34' ? ( + TEST_REQUIRES => { + 'Test::More' => '0.80', + 'Test::Script' => '1.05', + }, + ) : () ), 'EXE_FILES' => [ 'script/pwhich', ],

Mon Feb 02 14:24:13 2015 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 02 19:13:24 2015 PLICEASE [...] cpan.org - Correspondence added

Pardon me there was a bug in my logic :) diff --git a/Makefile.PL b/Makefile.PL index a9bd49c..b372fa4 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -10,9 +10,17 @@ WriteMakefile( 'Exporter' => 0, 'Getopt::Std' => 0, 'File::Spec' => '0.60', - 'Test::More' => '0.80', - 'Test::Script' => '1.05', + ($ExtUtils::MakeMaker::VERSION lt '6.34' ? ( + 'Test::More' => '0.80', + 'Test::Script' => '1.05', + ) : () ), }, + ($ExtUtils::MakeMaker::VERSION ge '6.34' ? ( + TEST_REQUIRES => { + 'Test::More' => '0.80', + 'Test::Script' => '1.05', + }, + ) : () ), 'EXE_FILES' => [ 'script/pwhich', ],

Mon Feb 02 19:50:19 2015 ether [...] cpan.org - Correspondence added

You also need this: WriteMakefile( ..., META_MERGE => { 'meta-spec' => { version => 2 }, dynamic_config => 0, }, ); ...in order to generate a correct META.json with prereqs under 'test' rather than 'build'.

Mon Feb 02 20:00:50 2015 PLICEASE [...] cpan.org - Correspondence added

How about this: diff --git a/Makefile.PL b/Makefile.PL index a9bd49c..3e7befb 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -10,9 +10,17 @@ WriteMakefile( 'Exporter' => 0, 'Getopt::Std' => 0, 'File::Spec' => '0.60', - 'Test::More' => '0.80', - 'Test::Script' => '1.05', + ($ExtUtils::MakeMaker::VERSION lt '6.34' ? ( + 'Test::More' => '0.80', + 'Test::Script' => '1.05', + ) : () ), }, + ($ExtUtils::MakeMaker::VERSION ge '6.34' ? ( + TEST_REQUIRES => { + 'Test::More' => '0.80', + 'Test::Script' => '1.05', + }, + ) : () ), 'EXE_FILES' => [ 'script/pwhich', ], @@ -22,4 +30,12 @@ WriteMakefile( ( $ExtUtils::MakeMaker::VERSION ge '6.31' ? ( LICENSE => 'perl', ) : () ), + + ( $ExtUtils::MakeMaker::VERSION ge '6.46' ? ( + META_MERGE => { + 'meta-spec' => { version => 2 }, + dynamic_config => 0, + }, + ) : () ), + );

Tue Feb 03 07:31:57 2015 PLICEASE [...] cpan.org - Correspondence added

another option would be to require a more recent version of MM, and remove all the version specific logic.

Thu Mar 26 05:51:37 2015 PLICEASE [...] cpan.org - Correspondence added

This will be fixed in 1.10. In addition Test::Script will be removed as a dependency in a later version, see: https://github.com/plicease/File-Which/issues/1

Thu Mar 26 05:51:48 2015 PLICEASE [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #99378 for File-Which: dependencies: declare Test::More, Test::Script as test_requires

Preferred bug tracker