Bug #99377 for Net-Whois-IP: Can't locate package AutoLoader

Wed Oct 08 08:31:41 2014 husakm [...] ics.muni.cz - Ticket created

Subject:	Can't locate package AutoLoader
Date:	Wed, 08 Oct 2014 14:31:24 +0200
To:	bug-Net-Whois-IP [...] rt.cpan.org
From:	Martin Husák <husakm [...] ics.muni.cz>

Greetings, I ended up with this error on my system: Can't locate package AutoLoader for @Net::Whois::IP::ISA There is a missing require statement in your code, adding the line: require AutoLoader; solved the issue. Regards, husakm

Download smime.p7s
application/pkcs7-signature 2.9k

Message body not shown because it is not plain text.

Thu Dec 22 12:09:20 2016 HEEB [...] cpan.org - Correspondence added

On Wed Oct 08 08:31:41 2014, husakm@ics.muni.cz wrote: Show quoted text

> I ended up with this error on my system: > > Can't locate package AutoLoader for @Net::Whois::IP::ISA > > There is a missing require statement in your code, adding the line: > > require AutoLoader; > > solved the issue.

This module does not use AutoLoader at all. It is likely a remnant of using h2xs (without the -X option) to generate the skeleton of the distribution. A better fix is to remove the reference to AutoLoader. For convenience a patch is attached (it's trivial, though). Regards -- Elmar --- a/IP.pm +++ b/IP.pm @@ -13,7 +13,7 @@ use File::Spec; require Exporter; use Carp; -@ISA = qw(Exporter AutoLoader); +@ISA = qw(Exporter); @EXPORT = qw( whoisip_query );

Thu Dec 22 12:09:20 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Dec 23 10:01:43 2016 HEEB [...] cpan.org - Correspondence added

On Thu Dec 22 12:09:20 2016, HEEB wrote: Show quoted text

> This module does not use AutoLoader at all. It is likely a remnant of > using h2xs (without the -X option) to generate the skeleton of the > distribution. > > A better fix is to remove the reference to AutoLoader. For > convenience a patch is attached (it's trivial, though).

A bit more context: This patch already got applied in version 1.17 and has since been reversed. Version 1.16 had a lot of changes which broke the tests. This has been reported in RT ticket #110961. I can reproduce the test failures. Version 1.18 had again many changes. It appears to revert some of the changes of 1.16 and also the single change regarding AutoLoader from 1.17. The test still do not pass in 1.18. Then in 1.19 the source was fixed so that the tests pass again. Some changes relative to 1.15 remain, but the AutoLoader fix did not come back. Applying the isolated patch to remove AutoLoader from @ISA would fix the bug reported in this ticket. The tests pass just fine. In perldoc AutoLoader in the CAVEAT section we can read that this is indeed the recommended fix for the bug (which appears in some other CPAN distributions too). The patch would also fix Debian bug https://bugs.debian.org/849102 in which autopkgtest complains about output in STDERR.

Fri Dec 23 10:16:31 2016 ben [...] foink.com - Correspondence added

Subject:	Re: [rt.cpan.org #99377] Can't locate package AutoLoader
Date:	Fri, 23 Dec 2016 09:16:09 -0600
To:	bug-Net-Whois-IP [...] rt.cpan.org
From:	Ben Schmitz <ben [...] foink.com>

Thanks. I'm on holiday and away from computers for a bit. I'll get a release out after the new year Ben Please pardon any typos; Sent from my phone Show quoted text

> On Dec 23, 2016, at 9:01 AM, Elmar S. Heeb via RT <bug-Net-Whois-IP@rt.cpan.org> wrote: > > Queue: Net-Whois-IP > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=99377 > >

>> On Thu Dec 22 12:09:20 2016, HEEB wrote: >> This module does not use AutoLoader at all. It is likely a remnant of >> using h2xs (without the -X option) to generate the skeleton of the >> distribution. >> >> A better fix is to remove the reference to AutoLoader. For >> convenience a patch is attached (it's trivial, though).

> > A bit more context: > > This patch already got applied in version 1.17 and has since been reversed. > > Version 1.16 had a lot of changes which broke the tests. This has been reported in RT ticket #110961. I can reproduce the test failures. Version 1.18 had again many changes. It appears to revert some of the changes of 1.16 and also the single change regarding AutoLoader from 1.17. The test still do not pass in 1.18. Then in 1.19 the source was fixed so that the tests pass again. Some changes relative to 1.15 remain, but the AutoLoader fix did not come back. > > Applying the isolated patch to remove AutoLoader from @ISA would fix the bug reported in this ticket. The tests pass just fine. > > In perldoc AutoLoader in the CAVEAT section we can read that this is indeed the recommended fix for the bug (which appears in some other CPAN distributions too). > > The patch would also fix Debian bug https://bugs.debian.org/849102 in which autopkgtest complains about output in STDERR.