Skip Menu |

This queue is for tickets about the Variable-Magic CPAN distribution.

Report information
The Basics
Id: 99319
Status: resolved
Priority: 0/
Queue: Variable-Magic

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.54
Fixed in: 0.55



Subject: t/18-opinfo.t: test failure due to change in perl 5 blead
Cf.: https://rt.perl.org/Ticket/Display.html?id=122909 A recent change to Perl 5 blead has caused one test in Variable-Magic's test suite to fail. I am attaching a patch which gets the test to pass once again. (I'm not taking any position as to whether the change in Perl 5 blead was a good one or not. If you don't think it is, please communicate that to P5P.) Thank you very much. Jim Keenan
Subject: 0001-Adjust-one-test-for-change-in-perl-5-blead.patch
From 9b66cadf2abae3f4dcba10a0b72be15a0354d80d Mon Sep 17 00:00:00 2001 From: James E Keenan <jkeenan@cpan.org> Date: Sun, 5 Oct 2014 21:11:35 -0400 Subject: [PATCH] Adjust one test for change in perl 5 blead. This commit to perl 5 blead: commit b46e009d94293e069270690750f6c669c6d0ce22 Author: syber <syber@crazypanda.ru> Date: Thu Sep 4 22:08:59 2014 +0400 Make OP_METHOD* to be of new class METHOP caused a failure in t/18-opinfo.t. See: https://rt.perl.org/Ticket/Display.html?id=122909 --- t/18-opinfo.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/18-opinfo.t b/t/18-opinfo.t index 70b5f74..70f4e43 100644 --- a/t/18-opinfo.t +++ b/t/18-opinfo.t @@ -39,7 +39,7 @@ my @tests = ( [ 'bless', 'B::LISTOP' ] ], [ 'get', '$c', 'my $c = ""','$c =~ /x/', [ 'match', 'B::PMOP' ] ], [ 'get', '$c', 'my $c = "Variable::Magic::TestPkg"', - '$c->foo()', [ 'method_named', 'B::SVOP' ] ], + '$c->foo()', [ 'method_named', 'B::OP' ] ], [ 'get', '$c', 'my $c = ""','$c =~ y/x/y/', [ 'trans', 'B::PVOP' ] ], [ 'get', '$c', 'my $c = 1', '1 for 1 .. $c', [ 'enteriter', 'B::LOOP' ] ], -- 1.9.1
On 2014-10-05 18:19:09, JKEENAN wrote: Show quoted text
> Cf.: https://rt.perl.org/Ticket/Display.html?id=122909 > > A recent change to Perl 5 blead has caused one test in Variable- > Magic's test suite to fail.
Perl 5.21.5 is now out -- is it possible to have this released soon? many thanks!
Le Lun 20 Oct 2014 15:42:49, ETHER a écrit : Show quoted text
> On 2014-10-05 18:19:09, JKEENAN wrote:
> > Cf.: https://rt.perl.org/Ticket/Display.html?id=122909 > > > > A recent change to Perl 5 blead has caused one test in Variable- > > Magic's test suite to fail.
> > Perl 5.21.5 is now out -- is it possible to have this released soon? > many thanks!
If "this" means this patch, then the answer is no, since it only hides the problem. I'll try to release a fix for this when my actual work actually leaves me some free time.
This is now fixed properly in version 0.55.