Skip Menu |

This queue is for tickets about the Catalyst-Helper-View-Bootstrap CPAN distribution.

Report information
The Basics
Id: 99262
Status: resolved
Worked: 15 min
Priority: 0/
Queue: Catalyst-Helper-View-Bootstrap

People
Owner: Nobody in particular
Requestors: bozziebear [...] hotmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.0006
Fixed in: 0.0007



Subject: Bootstrap.pm 0.0006 fails syntax check.
My app stopped working after upgrading to 0.0006; investigation suggests that Bootstrap.pm has syntax errors that prevent it from running: perl -c Catalyst/Helper/View/Bootstrap.pm syntax error at Bootstrap.pm line 81, near ")) " syntax error at Bootstrap.pm line 84, near "elsif" syntax error at Bootstrap.pm line 88, near "}" Global symbol "$jsdir" requires explicit package name ... Bootstrap.pm has too many errors. It looks like lines 81 and 84 (the "require MinifierXXX" lines) have unbalanced parentheses. Cheers, Tom
On Wed Oct 01 18:51:13 2014, TomLB wrote: Hi Tom, et. al., stills seems to be broken. Also found a second issue that prevents the creation of a new view. Here is the patch I used to fix it: --- Catalyst/Helper/View/Bootstrap.pm.orig 2014-11-13 11:37:00.018319923 -0500 +++ Catalyst/Helper/View/Bootstrap.pm 2014-11-13 11:40:18.901298464 -0500 @@ -24,7 +24,7 @@ } my $file = file( $dist_dir, @filename); Carp::confess("Cannot find $file") unless -r $file; - my $contents = $file->(iomode => "<:raw"); + my $contents = $file->slurp(iomode => "<:raw"); return $contents; } @@ -78,10 +78,10 @@ my $jsMinifier = 0; eval { $SIG{__DIE__} = 'IGNORE'; - if(require 'JavaScript::Minifier::XS')) { + if(require 'JavaScript::Minifier::XS') { $jsMinifier = 1; } - elsif(require 'JavaScript::Minifier')) { + elsif(require 'JavaScript::Minifier') { $jsMinifier = 2; } Best regards, Christian Show quoted text
> My app stopped working after upgrading to 0.0006; investigation > suggests that Bootstrap.pm has syntax errors that prevent it from > running: > > perl -c Catalyst/Helper/View/Bootstrap.pm > syntax error at Bootstrap.pm line 81, near ")) " > syntax error at Bootstrap.pm line 84, near "elsif" > syntax error at Bootstrap.pm line 88, near "}" > Global symbol "$jsdir" requires explicit package name ... > Bootstrap.pm has too many errors. > > It looks like lines 81 and 84 (the "require MinifierXXX" lines) have > unbalanced parentheses. > > Cheers, > Tom
From: juan.paredes [...] gmail.com
Hi, all. I'm also affected by this bug, though the patch fixes the issue for me. Can we help the author/maintainer to apply it and push a new version? Regards, Juan El Jue Nov 13 11:46:00 2014, DELTA escribió: Show quoted text
> On Wed Oct 01 18:51:13 2014, TomLB wrote: > > Hi Tom, et. al., > > stills seems to be broken. Also found a second issue that prevents the > creation of a new view. > > Here is the patch I used to fix it: > > --- Catalyst/Helper/View/Bootstrap.pm.orig 2014-11-13 > 11:37:00.018319923 -0500 > +++ Catalyst/Helper/View/Bootstrap.pm 2014-11-13 11:40:18.901298464 > -0500 > @@ -24,7 +24,7 @@ > } > my $file = file( $dist_dir, @filename); > Carp::confess("Cannot find $file") unless -r $file; > - my $contents = $file->(iomode => "<:raw"); > + my $contents = $file->slurp(iomode => "<:raw"); > return $contents; > } > > @@ -78,10 +78,10 @@ > my $jsMinifier = 0; > eval { > $SIG{__DIE__} = 'IGNORE'; > - if(require 'JavaScript::Minifier::XS')) { > + if(require 'JavaScript::Minifier::XS') { > $jsMinifier = 1; > } > - elsif(require 'JavaScript::Minifier')) { > + elsif(require 'JavaScript::Minifier') { > $jsMinifier = 2; > } > > > Best regards, > Christian >
> > My app stopped working after upgrading to 0.0006; investigation > > suggests that Bootstrap.pm has syntax errors that prevent it from > > running: > > > > perl -c Catalyst/Helper/View/Bootstrap.pm > > syntax error at Bootstrap.pm line 81, near ")) " > > syntax error at Bootstrap.pm line 84, near "elsif" > > syntax error at Bootstrap.pm line 88, near "}" > > Global symbol "$jsdir" requires explicit package name ... > > Bootstrap.pm has too many errors. > > > > It looks like lines 81 and 84 (the "require MinifierXXX" lines) have > > unbalanced parentheses. > > > > Cheers, > > Tom
From: juan.paredes [...] gmail.com
I made a pull-request on GitHub to apply the patch provided by Christian, and see if the author/maintainer reviews and uploads a new version. Thanks, all!
RT-Send-CC: juan.paredes [...] gmail.com, juan.paredes [...] gmail.com
Thank you Juan, I've pulled your fix.