Skip Menu |

This queue is for tickets about the ExtUtils-Depends CPAN distribution.

Report information
The Basics
Id: 99260
Status: resolved
Priority: 0/
Queue: ExtUtils-Depends

People
Owner: Nobody in particular
Requestors: ntyni [...] iki.fi
Cc: gregoa [...] cpan.org
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.401
Fixed in: (no value)



Subject: Stable saved config
As part of recent efforts towards reproducible builds of Debian packages (see <https://wiki.debian.org/ReproducibleBuilds>), we noticed that the contents of the *name*::Install::Files modules generated by ExtUtils::Depends vary between builds. See <https://bugs.debian.org/763677>. This happens because of hash key randomization and can be easily fixed by setting $Data::Dumper::Sortkeys=1 in save_config(). Please consider the attached patch, which would get us one step further on the road. Many thanks for your work on free software, -- Niko Tyni (Debian Perl group) ntyni@debian.org
Subject: 0001-Sort-hash-keys-in-saved-configuration-for-reproducib.patch
From cbb18537780f4bef8366f427f34a0b1cdf276d16 Mon Sep 17 00:00:00 2001 From: Niko Tyni <ntyni@debian.org> Date: Wed, 1 Oct 2014 22:44:17 +0300 Subject: [PATCH] Sort hash keys in saved configuration for reproducibility Bug-Debian: https://bugs.debian.org/763677 Having stable saved configuration helps the recent efforts for reproducible builds, see https://wiki.debian.org/ReproducibleBuilds --- lib/ExtUtils/Depends.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ExtUtils/Depends.pm b/lib/ExtUtils/Depends.pm index 05ba8d4..2e43411 100644 --- a/lib/ExtUtils/Depends.pm +++ b/lib/ExtUtils/Depends.pm @@ -114,6 +114,7 @@ sub install { sub save_config { use Data::Dumper; local $Data::Dumper::Terse = 0; + local $Data::Dumper::Sortkeys = 1; use IO::File; my ($self, $filename) = @_; -- 2.1.1
CC: Torsten Schoenfeld <kaffeetisch [...] gmx.de>
Subject: Re: [rt.cpan.org #99260] Stable saved config
Date: Thu, 2 Oct 2014 12:23:16 +0400
To: bug-ExtUtils-Depends [...] rt.cpan.org
From: Brian Manning <cpan [...] xaoc.org>
Thanks for the patch. Torsten, if you don't have any objections, I'll add it to git and push to the repo. Thanks, Brian On Thu, Oct 2, 2014 at 12:28 AM, ntyni@iki.fi via RT <bug-ExtUtils-Depends@rt.cpan.org> wrote: Show quoted text
> Wed Oct 01 16:28:20 2014: Request 99260 was acted upon. > Transaction: Ticket created by ntyni@iki.fi > Queue: ExtUtils-Depends > Subject: Stable saved config > Broken in: 0.401 > Severity: Wishlist > Owner: Nobody > Requestors: ntyni@iki.fi > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=99260 > > > > As part of recent efforts towards reproducible builds of Debian packages (see <https://wiki.debian.org/ReproducibleBuilds>), we noticed that the contents of the *name*::Install::Files modules generated by ExtUtils::Depends vary between builds. See <https://bugs.debian.org/763677>. > > This happens because of hash key randomization and can be easily fixed by setting $Data::Dumper::Sortkeys=1 in save_config(). Please consider the attached patch, which would get us one step further on the road. > > Many thanks for your work on free software, > -- > Niko Tyni (Debian Perl group) > ntyni@debian.org
Subject: Re: [rt.cpan.org #99260] Stable saved config
Date: Thu, 2 Oct 2014 10:28:09 +0200
To: bug-ExtUtils-Depends [...] rt.cpan.org
From: "Torsten Schönfeld" <kaffeetisch [...] gmx.de>
"Brian Manning via RT" <bug-ExtUtils-Depends@rt.cpan.org>: Show quoted text
> Torsten, if you don't have any objections, I'll add it to git and push > to the repo.
If the test suite still passes, the patch looks good to me.
On Thu Oct 02 04:28:22 2014, TSCH wrote: Show quoted text
> "Brian Manning via RT" <bug-ExtUtils-Depends@rt.cpan.org>:
> > Torsten, if you don't have any objections, I'll add it to git and push > > to the repo.
> > If the test suite still passes, the patch looks good to me.
Applied patch and ran tests, the tests all passed with no issues. Released as version 0.402; I've announced it to the list, the source is already available on Sourceforge, and it should be live across all of CPAN in a few hours. Thanks again for the patch! Setting ticket status to "resolved"