Skip Menu |

This queue is for tickets about the constant-tiny CPAN distribution.

Report information
The Basics
Id: 99169
Status: resolved
Priority: 0/
Queue: constant-tiny
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.01
Fixed in: 1.02

History Show all quoted text
  Sat Sep 27 06:14:03 2014 SREZIC [...] cpan.org - Ticket created
Subject: Test suite fails with perl 5.21.4 and newer
See http://matrix.cpantesters.org/?dist=constant-tiny%201.01 for an overview.
  Sat Sep 27 12:45:23 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Sat Sep 27 06:14:03 2014, SREZIC wrote: Show quoted text
> See http://matrix.cpantesters.org/?dist=constant-tiny%201.01 for an > overview.
Here is a patch that deletes the offending test. No, really, I mean it. That test was testing for a compile-time check that was removed in bleadperl because it can produce false positives. The test was testing for a Perl feature, not a constant::tiny feature.
Subject: open_gMzv2sq5.txt
diff -rup constant-tiny-1.01-iBj9Vy-orig/t/constant.t constant-tiny-1.01-iBj9Vy/t/constant.t --- constant-tiny-1.01-iBj9Vy-orig/t/constant.t 2014-09-27 09:42:40.000000000 -0700 +++ constant-tiny-1.01-iBj9Vy/t/constant.t 2014-09-27 09:43:03.000000000 -0700 @@ -10,7 +10,7 @@ END { @warnings && print STDERR join "\n use strict; -use Test::More tests => 95; +use Test::More tests => 94; my $TB = Test::More->builder; use constant PI => 4 * atan2 1, 1; @@ -120,10 +120,6 @@ print $output CCODE->($curr_test+4); $TB->current_test($curr_test+4); -eval q{ CCODE->{foo} }; -ok scalar($@ =~ /^Constant is not a HASH/); - - # Allow leading underscore use constant _PRIVATE => 47; is _PRIVATE, 47;
  Sat Sep 27 12:45:24 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Aug 16 16:36:44 2015 SAPER [...] cpan.org - Correspondence added
Thanks, applied. A new version has been pushed to CPAN. -- Close the world, txEn eht nepO.
  Thu Sep 24 13:24:28 2015 SAPER [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Sep 24 13:24:29 2015 SAPER [...] cpan.org - Fixed in 1.02 added
  Thu Sep 24 16:22:45 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-08-16 16:36:44, SAPER wrote: Show quoted text
> Thanks, applied. A new version has been pushed to CPAN.
The patch is actually by Father Chrysostomos, not by me, as it is stated in the Changes file (but the other patch for #99169 is correctly attributed).
  Thu Sep 24 16:24:51 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-09-24 16:22:45, SREZIC wrote: Show quoted text
> On 2015-08-16 16:36:44, SAPER wrote:
> > Thanks, applied. A new version has been pushed to CPAN.
> > The patch is actually by Father Chrysostomos, not by me, as it is > stated in the Changes file (but the other patch for #99169 is > correctly attributed).
Err, I mean #103958, not #99169. Ah, too much confusion, so here explicitly: #99169 -> by Father Chrysostomos #103958 -> correct