Skip Menu |

This queue is for tickets about the local-lib CPAN distribution.

Report information
The Basics
Id: 99108
Status: rejected
Priority: 0/
Queue: local-lib
People
Owner: Nobody in particular
Requestors: bitcard [...] daedalus.co.uk
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 2.000004
Fixed in: 2.000_005

History Show all quoted text
  Wed Sep 24 06:57:55 2014 bitcard [...] daedalus.co.uk - Ticket created
Subject: "Use of uninitialized value" warning under Windows
When running perl -Mlocal::lib under Windows, the module behaves correctly (i.e. determines the user's home directory correctly), but a "Use of uninitialized value $user in concatenation or string" warning is thrown. This is caused by $user being undefined in resolve_home_path(), in the line: File::Glob::bsd_glob("~$user", File::Glob::GLOB_TILDE()); Replacing this with: File::Glob::bsd_glob("~".($user||""), File::Glob::GLOB_TILDE()); ...fixes the warning. Perl: Strawberry Perl 5.18.2 OS: Windows 7 SP1
  Wed Sep 24 08:06:02 2014 haarg [...] haarg.org - Correspondence added
On Wed Sep 24 06:57:55 2014, bitcard@daedalus.co.uk wrote: Show quoted text
> When running perl -Mlocal::lib under Windows, the module behaves > correctly (i.e. determines the user's home directory correctly), but a > "Use of uninitialized value $user in concatenation or string" warning > is thrown. This is caused by $user being undefined in > resolve_home_path(), in the line: > File::Glob::bsd_glob("~$user", File::Glob::GLOB_TILDE()); > > Replacing this with: > File::Glob::bsd_glob("~".($user||""), File::Glob::GLOB_TILDE()); > > ...fixes the warning. > > Perl: Strawberry Perl 5.18.2 > OS: Windows 7 SP1
I can't reproduce this, and based on the code I can't see how it would happen. Based on: $path =~ /^~([^\/]*)/ or return $path; my $user = $1; If the regex to find the user doesn't match, it will return immediately. If it does match, $user will end up with either a username or an empty string, not undef.
  Wed Sep 24 08:06:04 2014 The RT System itself - Status changed from 'new' to 'open'
  Wed Sep 24 08:31:43 2014 bitcard [...] daedalus.co.uk - Correspondence added
From: bitcard [...] daedalus.co.uk
My apologies - I had run direct checks against v2.000004, and checked that the File::Glob::bsd_glob line still existed in the latest version of local::lib, but didn't check the $path matching line. The issue was actually fixed in v 2.000_005.
  Wed Sep 24 08:41:53 2014 haarg [...] haarg.org - Correspondence added
Thanks for checking.
  Wed Sep 24 08:41:57 2014 haarg [...] haarg.org - Status changed from 'open' to 'rejected'
  Wed Sep 24 12:11:55 2014 ether [...] cpan.org - Broken in 2.000003 deleted
  Wed Sep 24 12:11:56 2014 ether [...] cpan.org - Broken in 2.000006 deleted
  Wed Sep 24 12:11:57 2014 ether [...] cpan.org - Broken in 2.000007 deleted
  Wed Sep 24 12:11:57 2014 ether [...] cpan.org - Broken in 2.000008 deleted
  Wed Sep 24 12:11:58 2014 ether [...] cpan.org - Broken in 2.000010 deleted
  Wed Sep 24 12:11:58 2014 ether [...] cpan.org - Broken in 2.000011 deleted
  Wed Sep 24 12:11:58 2014 ether [...] cpan.org - Broken in 2.000012 deleted
  Wed Sep 24 12:11:59 2014 ether [...] cpan.org - Broken in 2.000013 deleted
  Wed Sep 24 12:11:59 2014 ether [...] cpan.org - Broken in 2.000014 deleted
  Wed Sep 24 12:12:00 2014 ether [...] cpan.org - Broken in 2.000_000 deleted
  Wed Sep 24 12:12:00 2014 ether [...] cpan.org - Broken in 2.000_001 deleted
  Wed Sep 24 12:12:01 2014 ether [...] cpan.org - Broken in 2.000_002 deleted
  Wed Sep 24 12:12:02 2014 ether [...] cpan.org - Broken in 2.000_005 deleted
  Wed Sep 24 12:12:02 2014 ether [...] cpan.org - Broken in 2.000_009 deleted
  Wed Sep 24 12:12:03 2014 ether [...] cpan.org - Fixed in 2.000_005 added