Bug #99026 for Data-Dump-Streamer: usage of JSON::XS

Sun Sep 21 17:47:38 2014 ether [...] cpan.org - Ticket created

Subject:

usage of JSON::XS

two requests: - please consider declaring JSON::XS as test recommends in metadata, rather than runtime recommends - expand t/madness_json.t to also test with Cpanel::JSON::XS (it papers over some of the insanity in the JSON::*::Boolean values)

Mon Sep 22 04:26:28 2014 demerphq [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #99026] usage of JSON::XS
Date:	Mon, 22 Sep 2014 10:26:15 +0200
To:	"bug-Data-Dump-Streamer [...] rt.cpan.org" <bug-Data-Dump-Streamer [...] rt.cpan.org>
From:	demerphq <demerphq [...] gmail.com>

On 21 September 2014 23:47, Karen Etheridge via RT < bug-Data-Dump-Streamer@rt.cpan.org> wrote: Show quoted text

> Sun Sep 21 17:47:38 2014: Request 99026 was acted upon. > Transaction: Ticket created by ETHER > Queue: Data-Dump-Streamer > Subject: usage of JSON::XS > Broken in: (no value) > Severity: Wishlist > Owner: Nobody > Requestors: ether@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=99026 > > > > two requests: > > - please consider declaring JSON::XS as test recommends in metadata, > rather than runtime recommends >

Yeah, this would be nice. It would also be nice if one didnt have to jump through huge hoops to do it as well. Which one unfortunately does. Show quoted text

> - expand t/madness_json.t to also test with Cpanel::JSON::XS (it papers > over some of the insanity in the JSON::*::Boolean values) >

Ill have a look at that. What exactly fails currently if you use that instead? Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"

Mon Sep 22 04:26:29 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Sep 22 12:23:40 2014 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #99026] usage of JSON::XS
Date:	Mon, 22 Sep 2014 09:23:29 -0700
To:	demerphq via RT <bug-Data-Dump-Streamer [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Mon, Sep 22, 2014 at 04:26:29AM -0400, demerphq via RT wrote: Show quoted text

> > - please consider declaring JSON::XS as test recommends in metadata, > > rather than runtime recommends

> > Yeah, this would be nice. It would also be nice if one didnt have to jump > through huge hoops to do it as well. Which one unfortunately does.

Is switching to ExtUtils::MakeMaker an option? Show quoted text

> > - expand t/madness_json.t to also test with Cpanel::JSON::XS (it papers > > over some of the insanity in the JSON::*::Boolean values)

> > Ill have a look at that. What exactly fails currently if you use that > instead?

I haven't seen any problems so far, but I can't be sure I'm exercising all the edge cases :)

Mon Sep 22 13:27:47 2014 demerphq [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #99026] usage of JSON::XS
Date:	Mon, 22 Sep 2014 19:27:36 +0200
To:	"bug-Data-Dump-Streamer [...] rt.cpan.org" <bug-Data-Dump-Streamer [...] rt.cpan.org>
From:	demerphq <demerphq [...] gmail.com>

On 22 September 2014 18:23, Karen Etheridge via RT < bug-Data-Dump-Streamer@rt.cpan.org> wrote: Show quoted text

> Queue: Data-Dump-Streamer > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=99026 > > > On Mon, Sep 22, 2014 at 04:26:29AM -0400, demerphq via RT wrote:

> > > - please consider declaring JSON::XS as test recommends in metadata, > > > rather than runtime recommends

> > > > Yeah, this would be nice. It would also be nice if one didnt have to jump > > through huge hoops to do it as well. Which one unfortunately does.

> > Is switching to ExtUtils::MakeMaker an option? > >

Yes it is. DDS was originally EUMM based, but Josh (who was doing maint for a while there) migrated to MB. Show quoted text

> > > - expand t/madness_json.t to also test with Cpanel::JSON::XS (it papers > > > over some of the insanity in the JSON::*::Boolean values)

> > > > Ill have a look at that. What exactly fails currently if you use that > > instead?

> > I haven't seen any problems so far, but I can't be sure I'm exercising all > the edge cases :) > > >

Ah, I see. I get you now. :-) Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"