Skip Menu |

This queue is for tickets about the Tickit CPAN distribution.

Report information
The Basics
Id: 98983
Status: resolved
Priority: 0/
Queue: Tickit
People
Owner: Nobody in particular
Requestors: leonerd-cpan [...] leonerd.org.uk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.58

History Show all quoted text
  Fri Sep 19 09:38:00 2014 leonerd-cpan [...] leonerd.org.uk - Ticket created
Subject: Fails on 5.10.0 due to lack of mPUSHs
undefined symbol: mPUSHs at .../perl/perl-5.10.0/5da8/lib/5.10.0/x86_64-linux/DynaLoader.pm line 203. 5.10.1 onwards are fine. -- Paul Evans
  Thu Sep 29 16:46:03 2016 leonerd-cpan [...] leonerd.org.uk - Correspondence added
Hopefully fixed by the attached. -- Paul Evans
Subject: rt98983.patch
=== modified file 'lib/Tickit.xs' --- lib/Tickit.xs 2016-08-08 14:46:18 +0000 +++ lib/Tickit.xs 2016-09-29 20:42:01 +0000 @@ -18,6 +18,11 @@ // UVs also have the IOK flag set #define SvIsNumeric(sv) (SvFLAGS(sv) & (SVp_IOK|SVp_NOK)) +// back-compat for 5.10.0 since it's easy +#ifndef mPUSHs +# define mPUSHs(sv) PUSHs(sv_2mortal(sv)) +#endif + static TickitEventType tickit_name2ev(const char *name) { switch(name[0]) {
  Thu Sep 29 16:46:03 2016 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'
  Tue Jun 13 09:49:55 2017 leonerd-cpan [...] leonerd.org.uk - Correspondence added
This was released way back in 0.58 -- Paul Evans
  Tue Jun 13 09:49:55 2017 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'
  Tue Jun 13 09:49:56 2017 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.58 added