Skip Menu |

This queue is for tickets about the Tk CPAN distribution.

Report information
The Basics
Id: 98889
Status: resolved
Priority: 0/
Queue: Tk

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 804.032_500



Subject: Useless hostname and login retrieval in t/fileevent.t
t/fileevent.t reads: chomp($HN = `hostname`); $ME = getlogin; The $HN and $ME variables are then used nowhere. I hit it when running the test on a system without hostname command: Can't exec "hostname": No such file or directory at t/fileevent.t line 215, <DATA> line 77. Use of uninitialized value $HN in scalar chomp at t/fileevent.t line 215, <DATA> line 77. I recommend to remove those two useless lines.
On 2014-09-15 03:06:20, ppisar wrote: Show quoted text
> t/fileevent.t reads: > > chomp($HN = `hostname`); > $ME = getlogin; > > The $HN and $ME variables are then used nowhere. I hit it when running > the test on a system without hostname command: > > Can't exec "hostname": No such file or directory at t/fileevent.t line > 215, <DATA> line 77. > Use of uninitialized value $HN in scalar chomp at t/fileevent.t line > 215, <DATA> line 77. > > I recommend to remove those two useless lines.
Thanks, changed in commit 7f8a00ab1025206784866e48f2535f3d7e42d8cc