Bug #98845 for Helios: helios_job_submit.pl says job arguments invalid, submits anyway

Fri Sep 12 18:58:30 2014 LAJANDY [...] cpan.org - Ticket created

Subject:

helios_job_submit.pl says job arguments invalid, submits anyway

If you attempt to submit a job with invalid job argument XML with helios_job_submit.pl, the command will print an error but submit the job to Helios anyway: $ helios_job_submit.pl -v Helios::TestService "<job><params><arg1>value1</arg1>" Invalid job arguments: <job><params><arg1>value1</arg1> () Jobid: 84 The helios_job_info command confirms the job was submitted with invalid job argument XML: $ helios_job_info --jobid=84 -a -l Jobid: 84 Jobtype: Helios::TestService Submit Time: Fri Sep 12 18:51:21 2014 Run After: Fri Sep 12 18:51:21 2014 Locked Until: Priority: Args: <job><params><arg1>value1</arg1>

Fri Sep 19 21:33:24 2014 LAJANDY [...] cpan.org - Correspondence added

This apparently was introduced with git commit ecb5c1ca0d97ef3d2a53d71b63a4b9a8a627d1bb, where the bulk of the validateParamsXML() function was replaced with code using an eval {} or do {} block instead of the Error module's try and catch. If validation fails, the main body of the command expects validateParamsXML() to return a false value, but the new code does not do that. On Fri Sep 12 18:58:30 2014, LAJANDY wrote: Show quoted text

> If you attempt to submit a job with invalid job argument XML with > helios_job_submit.pl, the command will print an error but submit the > job to Helios anyway: > > $ helios_job_submit.pl -v Helios::TestService > "<job><params><arg1>value1</arg1>" > Invalid job arguments: <job><params><arg1>value1</arg1> () > Jobid: 84 > > The helios_job_info command confirms the job was submitted with > invalid job argument XML: > > $ helios_job_info --jobid=84 -a -l > Jobid: 84 > Jobtype: Helios::TestService > Submit Time: Fri Sep 12 18:51:21 2014 > Run After: Fri Sep 12 18:51:21 2014 > Locked Until: > Priority: > > Args: > <job><params><arg1>value1</arg1>

Fri Sep 19 21:33:25 2014 LAJANDY [...] cpan.org - Status changed from 'new' to 'open'

Fri Sep 19 21:33:25 2014 LAJANDY [...] cpan.org - Taken

Fri Sep 19 21:33:25 2014 LAJANDY [...] cpan.org - Fixed in 2.71_4350 added

Fri Sep 19 21:33:26 2014 LAJANDY [...] cpan.org - Fixed in 2.71_4460 added

Fri Sep 19 21:33:26 2014 LAJANDY [...] cpan.org - Fixed in 2.71_4770 added

Fri Sep 19 21:33:26 2014 LAJANDY [...] cpan.org - Fixed in 2.72_0950 added

Fri Sep 19 21:33:26 2014 LAJANDY [...] cpan.org - Fixed in 2.80 added

Fri Sep 19 21:33:26 2014 LAJANDY [...] cpan.org - Fixed in 2.801_3270 added

Fri Sep 19 21:33:26 2014 LAJANDY [...] cpan.org - Fixed in 2.801_3350 added

Fri Sep 19 21:33:26 2014 LAJANDY [...] cpan.org - Fixed in 2.81 added

Fri Sep 19 21:33:27 2014 LAJANDY [...] cpan.org - Fixed in 2.811_3460 added

Fri Sep 19 22:38:02 2014 LAJANDY [...] cpan.org - Correspondence added

On Fri Sep 19 21:33:24 2014, LAJANDY wrote: Show quoted text

> This apparently was introduced with git commit > ecb5c1ca0d97ef3d2a53d71b63a4b9a8a627d1bb, where the bulk of the > validateParamsXML() function was replaced with code using an eval {} > or do {} block instead of the Error module's try and catch. If > validation fails, the main body of the command expects > validateParamsXML() to return a false value, but the new code does not > do that. > > On Fri Sep 12 18:58:30 2014, LAJANDY wrote:

> > If you attempt to submit a job with invalid job argument XML with > > helios_job_submit.pl, the command will print an error but submit the > > job to Helios anyway: > > > > $ helios_job_submit.pl -v Helios::TestService > > "<job><params><arg1>value1</arg1>" > > Invalid job arguments: <job><params><arg1>value1</arg1> () > > Jobid: 84 > > > > The helios_job_info command confirms the job was submitted with > > invalid job argument XML: > > > > $ helios_job_info --jobid=84 -a -l > > Jobid: 84 > > Jobtype: Helios::TestService > > Submit Time: Fri Sep 12 18:51:21 2014 > > Run After: Fri Sep 12 18:51:21 2014 > > Locked Until: > > Priority: > > > > Args: > > <job><params><arg1>value1</arg1>

Fri Sep 19 22:38:03 2014 LAJANDY [...] cpan.org - Fixed in 2.71_4350 deleted

Fri Sep 19 22:38:03 2014 LAJANDY [...] cpan.org - Fixed in 2.71_4460 deleted

Fri Sep 19 22:38:03 2014 LAJANDY [...] cpan.org - Fixed in 2.71_4770 deleted

Fri Sep 19 22:38:03 2014 LAJANDY [...] cpan.org - Fixed in 2.72_0950 deleted

Fri Sep 19 22:38:03 2014 LAJANDY [...] cpan.org - Fixed in 2.80 deleted

Fri Sep 19 22:38:03 2014 LAJANDY [...] cpan.org - Fixed in 2.801_3270 deleted

Fri Sep 19 22:38:04 2014 LAJANDY [...] cpan.org - Fixed in 2.801_3350 deleted

Fri Sep 19 22:38:04 2014 LAJANDY [...] cpan.org - Fixed in 2.81 deleted

Fri Sep 19 22:38:04 2014 LAJANDY [...] cpan.org - Fixed in 2.811_3460 deleted

Sat Oct 04 23:07:25 2014 LAJANDY [...] cpan.org - Correspondence added

Fixed in 2.811_3850. Will be included in next stable release. On Fri Sep 12 18:58:30 2014, LAJANDY wrote: Show quoted text

> If you attempt to submit a job with invalid job argument XML with > helios_job_submit.pl, the command will print an error but submit the > job to Helios anyway: > > $ helios_job_submit.pl -v Helios::TestService > "<job><params><arg1>value1</arg1>" > Invalid job arguments: <job><params><arg1>value1</arg1> () > Jobid: 84 > > The helios_job_info command confirms the job was submitted with > invalid job argument XML: > > $ helios_job_info --jobid=84 -a -l > Jobid: 84 > Jobtype: Helios::TestService > Submit Time: Fri Sep 12 18:51:21 2014 > Run After: Fri Sep 12 18:51:21 2014 > Locked Until: > Priority: > > Args: > <job><params><arg1>value1</arg1>

Sat Oct 04 23:07:26 2014 LAJANDY [...] cpan.org - Fixed in 2.811_3850 added

Sun Nov 23 20:50:44 2014 LAJANDY [...] cpan.org - Correspondence added

On Fri Sep 12 18:58:30 2014, LAJANDY wrote: Show quoted text

> If you attempt to submit a job with invalid job argument XML with > helios_job_submit.pl, the command will print an error but submit the > job to Helios anyway: > > $ helios_job_submit.pl -v Helios::TestService > "<job><params><arg1>value1</arg1>" > Invalid job arguments: <job><params><arg1>value1</arg1> () > Jobid: 84 > > The helios_job_info command confirms the job was submitted with > invalid job argument XML: > > $ helios_job_info --jobid=84 -a -l > Jobid: 84 > Jobtype: Helios::TestService > Submit Time: Fri Sep 12 18:51:21 2014 > Run After: Fri Sep 12 18:51:21 2014 > Locked Until: > Priority: > > Args: > <job><params><arg1>value1</arg1>

Sun Nov 23 20:50:45 2014 LAJANDY [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Nov 23 20:50:46 2014 LAJANDY [...] cpan.org - Fixed in 2.811_4150 added

Sun Nov 23 20:50:46 2014 LAJANDY [...] cpan.org - Fixed in 2.82 added