On 2014-09-10 02:57:42, RIBASUSHI wrote:
Show quoted text> On Wed Sep 10 11:28:05 2014, RGARCIA wrote:
> >
> > Sorry then, the module just does not work on ancient perls, hence the
> > version requirement.
Pre-5.14 is, regrettably, not yet ancient. The Perl-Toolchain-Gang is still committed to supporting down to perl 5.8 in normal cases, and even accepting non-disruptive patches for earlier versions if anyone is willing to write them. The Moose project has a stated policy of supporting 5.10+ and accepting patches for 5.8.
Show quoted text> This is not true. There are two things that make the version bump
> unacceptable:
>
> 1) The XS portion requires newer macros yes, but nothing prevents you
> from having a couple of IFDEF's. Moreover extra PPPort application is
> likely to make the problem go away altogether
I would request that a newer ppport.h be applied to see if this is sufficient, as it sounds like the simplest solution of all. And, then, adding IFDEFs in code.
Show quoted text> 2) (much more importantly) The module always had a pure-perl
> implmentation which works all the way back to what *I* consider
> ancient. If you are not interested in doing the work required for (1),
> which is entirely your right, you must modify your builder to skip
> building XS on < 5.14. This way you get the C code in whatever shape
> you prefer, and yet nobody gets broken deployments.
I would consider it acceptable for the distribution to fall back to a pure-perl implementation for pre-5.14 installations, if this is documented.
What *isn't* acceptable is for the code to simply stop installing on pre-5.14 perls, as this breaks all upstream dependencies which have stated goals of continuing to work on these versions, which includes Moose. Leaving the dependency chain broken is *NOT* an option.
Please, in future, make breaking changes in an alpha release first so you can safely gauge the impact before disrupting everyone downstream.