Bug #98685 for MooseX-Params-Validate: Params::Validate 'depends' spec parameter not working

Sun Sep 07 14:33:26 2014 STAUGAARD [...] cpan.org - Ticket created

Subject:

Params::Validate 'depends' spec parameter not working

The depends spec parameter (see: https://metacpan.org/pod/Params::Validate#Dependencies) is not passed to Params::Validate Patch attached

Subject:

Validate.pm.patch

--- Validate.pm 2014-09-07 20:27:23.640135500 +0200 +++ Validate.new.pm 2014-09-07 20:29:19.181236900 +0200 @@ -201,6 +201,9 @@ $pv_spec{coerce} = $spec->{coerce} if exists $spec->{coerce}; + $pv_spec{depends} = $spec->{depends} + if exists $spec->{depends}; + my $constraint; if ( defined $spec->{isa} ) { $constraint

Sat Sep 13 15:53:09 2014 DROLSKY [...] cpan.org - Correspondence added

On Sun Sep 07 14:33:26 2014, STAUGAARD wrote: Show quoted text

> The depends spec parameter (see: > https://metacpan.org/pod/Params::Validate#Dependencies) is not passed > to Params::Validate > > Patch attached

I'm not sure what this patch is against, but I don't see how it applies to the current code. Could you maybe submit a pull request against the latest version on GitHub (https://github.com/autarch/Params-Validate)? Also, if you could write a test for this, that'd be very helpful.

Sat Sep 13 15:53:10 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Sep 15 09:25:54 2014 STAUGAARD [...] cpan.org - Correspondence added

On Sat Sep 13 15:53:09 2014, DROLSKY wrote: Show quoted text

> On Sun Sep 07 14:33:26 2014, STAUGAARD wrote:

> > The depends spec parameter (see: > > https://metacpan.org/pod/Params::Validate#Dependencies) is not passed > > to Params::Validate > > > > Patch attached

> > I'm not sure what this patch is against, but I don't see how it > applies to the current code. Could you maybe submit a pull request > against the latest version on GitHub > (https://github.com/autarch/Params-Validate)? Also, if you could write > a test for this, that'd be very helpful.

I'll do that :)

Sun Oct 05 12:26:36 2014 DROLSKY [...] cpan.org - Correspondence added

On Mon Sep 15 09:25:54 2014, STAUGAARD wrote: Show quoted text

> On Sat Sep 13 15:53:09 2014, DROLSKY wrote:

> > On Sun Sep 07 14:33:26 2014, STAUGAARD wrote:

> > > The depends spec parameter (see: > > > https://metacpan.org/pod/Params::Validate#Dependencies) is not passed > > > to Params::Validate > > > > > > Patch attached

> > > > I'm not sure what this patch is against, but I don't see how it > > applies to the current code. Could you maybe submit a pull request > > against the latest version on GitHub > > (https://github.com/autarch/Params-Validate)? Also, if you could write > > a test for this, that'd be very helpful.

> > I'll do that :)

Oops, I was clearly confused about what module this was for. I thought this was for PV itself, not MX::PV. This patch is fine as-is, but it could really use some tests.

Mon Oct 06 04:23:05 2014 STAUGAARD [...] cpan.org - Correspondence added

On Sun Oct 05 12:26:36 2014, DROLSKY wrote: Show quoted text

> On Mon Sep 15 09:25:54 2014, STAUGAARD wrote:

> > On Sat Sep 13 15:53:09 2014, DROLSKY wrote:

> > > On Sun Sep 07 14:33:26 2014, STAUGAARD wrote:

> > > > The depends spec parameter (see: > > > > https://metacpan.org/pod/Params::Validate#Dependencies) is not > > > > passed > > > > to Params::Validate > > > > > > > > Patch attached

> > > > > > I'm not sure what this patch is against, but I don't see how it > > > applies to the current code. Could you maybe submit a pull request > > > against the latest version on GitHub > > > (https://github.com/autarch/Params-Validate)? Also, if you could > > > write > > > a test for this, that'd be very helpful.

> > > > I'll do that :)

> > Oops, I was clearly confused about what module this was for. I thought > this was for PV itself, not MX::PV. This patch is fine as-is, but it > could really use some tests.

Here you go The following changes since commit 0a0bf9c2d3a08e5798015de93643dd9fd47f35d1: Fix small typo (2013-07-22 10:39:21 -0500) are available in the git repository at: https://bitbucket.org/hstaugaard/moosex-params-validate.git for you to fetch changes up to 724f5fdb10d799d23beb038ff56c273c23c36a66: Added 'depends' support (2014-10-06 10:07:51 +0200) ---------------------------------------------------------------- Hans Staugaard (1): Added 'depends' support lib/MooseX/Params/Validate.pm | 3 +++ t/001_basic.t | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+)

Sat Nov 15 11:46:08 2014 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Nov 15 11:46:09 2014 DROLSKY [...] cpan.org - Fixed in 0.19 added