Bug #98635 for XML-Parser-Lite: Don't skip more tests than planned

Fri Sep 05 05:57:16 2014 contyk [...] cpan.org - Ticket created

Subject:

Don't skip more tests than planned

t/26-xmlrpc.t may fail in network-less environments due to skipping 8 tests on line 28 while only 6 are planned. The attached patch fixes the issue.

Subject:

perl-XML-Parser-Lite-0.719-plan.patch

diff --git a/t/26-xmlrpc.t b/t/26-xmlrpc.t index c747636..199b266 100644 --- a/t/26-xmlrpc.t +++ b/t/26-xmlrpc.t @@ -25,7 +25,7 @@ SKIP: { $r = $s->test_connection; unless ( defined $r && defined $r->envelope ) { - skip 'need XMLRPC::Lite', 8 if $@; + skip 'need XMLRPC::Lite', 6 if $@; print "1..0 # Skip: ", $s->transport->status, "\n"; exit; }

Mon Sep 15 12:44:53 2014 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #98635] Don't skip more tests than planned
Date:	Mon, 15 Sep 2014 09:38:59 -0700
To:	bug-XML-Parser-Lite [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

I think 6 tests are already planned: https://metacpan.org/source/PHRED/XML-Parser-Lite-0.719/t/26-xmlrpc.t On Fri, Sep 5, 2014 at 2:57 AM, Petr Šabata via RT <bug-XML-Parser-Lite@rt.cpan.org> wrote: Show quoted text

> Fri Sep 05 05:57:16 2014: Request 98635 was acted upon. > Transaction: Ticket created by contyk > Queue: XML-Parser-Lite > Subject: Don't skip more tests than planned > Broken in: 0.719 > Severity: Normal > Owner: Nobody > Requestors: contyk@redhat.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=98635 > > > > t/26-xmlrpc.t may fail in network-less environments due to skipping 8 tests on line 28 while only 6 are planned. > > The attached patch fixes the issue.

Mon Sep 15 12:44:53 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Sep 15 12:47:16 2014 PHRED [...] cpan.org - Correspondence added

Resolved in 0.720

Mon Sep 15 12:47:17 2014 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Sep 16 05:24:02 2014 contyk [...] cpan.org - Correspondence added

On Mon Sep 15 12:47:16 2014, PHRED wrote: Show quoted text

> Resolved in 0.720

Indeed, six are planned but line 28, at noted in a previous comment, skips eight, which results in the test failure under certain circumstances. Reopening as 0.72 doesn't change anything.

Tue Sep 16 05:24:03 2014 contyk [...] cpan.org - Status changed from 'resolved' to 'open'

Tue Sep 16 05:24:04 2014 contyk [...] cpan.org - Fixed in 0.72 added

Sat Jul 07 06:43:49 2018 paultcochrane [...] gmail.com - Correspondence added

This issue was resolved in version 0.721 and hence this ticket can probably be closed as resolved.