Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DateTime CPAN distribution.

Report information
The Basics
Id: 98532
Status: rejected
Priority: 0/
Queue: DateTime
People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.12
Fixed in: (no value)

History Show all quoted text
  Tue Sep 02 09:47:05 2014 ppisar [...] redhat.com - Ticket created
Subject: Why DateTime-TimeZone dependency version had been increased to 1.74?
Why did DateTime-1.12 increase DateTime-TimeZone minimal version to 1.74? I cannot see the reason. The tests modified with commit 00fed1e2e376e8aa086e4841c3dc5ef6193e65d3 Author: Dave Rolsky <autarch@urth.org> Date: Sun Aug 31 10:55:20 2014 -0500 Fixes for latest DT::TZ does not use any new interface not available before 1.74.
  Tue Sep 02 10:00:14 2014 DROLSKY [...] cpan.org - Correspondence added
On Tue Sep 02 09:47:05 2014, ppisar wrote: Show quoted text
> Why did DateTime-1.12 increase DateTime-TimeZone minimal version to > 1.74? I cannot see the reason. The tests modified with > > commit 00fed1e2e376e8aa086e4841c3dc5ef6193e65d3 > Author: Dave Rolsky <autarch@urth.org> > Date: Sun Aug 31 10:55:20 2014 -0500 > > Fixes for latest DT::TZ > > does not use any new interface not available before 1.74.
Because the tests were breaking with earlier versions of DT::TZ. Given that DT::TZ is backwards compatible (beyond zone name changes) I don't see what the problem is.
  Tue Sep 02 10:00:14 2014 The RT System itself - Status changed from 'new' to 'open'
  Tue Sep 02 10:10:21 2014 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #98532] Why DateTime-TimeZone dependency version had been increased to 1.74?
Date: Tue, 2 Sep 2014 16:10:04 +0200
To: Dave Rolsky via RT <bug-DateTime [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Tue, Sep 02, 2014 at 10:00:14AM -0400, Dave Rolsky via RT wrote: Show quoted text
> On Tue Sep 02 09:47:05 2014, ppisar wrote:
> > Why did DateTime-1.12 increase DateTime-TimeZone minimal version to > > 1.74? I cannot see the reason. The tests modified with > > > > commit 00fed1e2e376e8aa086e4841c3dc5ef6193e65d3 > > Author: Dave Rolsky <autarch@urth.org> > > Date: Sun Aug 31 10:55:20 2014 -0500 > > > > Fixes for latest DT::TZ > > > > does not use any new interface not available before 1.74.
> > Because the tests were breaking with earlier versions of DT::TZ. >
Indeed? I though the breakage for the fixed by the commit, so there is not need to change the version requirement. I tested the patched tests against DateTime-TimeZone-1.73 and even DateTime-TimeZone-1.63 successfully. Show quoted text
> Given that DT::TZ is backwards compatible (beyond zone name changes) I don't > see what the problem is.
Not entirely. E.g. DT-TZ-1.71 started to require List::AllUtils. -- Petr
Download (untitled)
application/pgp-signature 213b

Message body not shown because it is not plain text.

  Tue Sep 02 10:21:39 2014 DROLSKY [...] cpan.org - Correspondence added
On Tue Sep 02 10:10:21 2014, ppisar wrote: Show quoted text
> On Tue, Sep 02, 2014 at 10:00:14AM -0400, Dave Rolsky via RT wrote:
> > On Tue Sep 02 09:47:05 2014, ppisar wrote:
> > > Why did DateTime-1.12 increase DateTime-TimeZone minimal version to > > > 1.74? I cannot see the reason. The tests modified with > > > > > > commit 00fed1e2e376e8aa086e4841c3dc5ef6193e65d3 > > > Author: Dave Rolsky <autarch@urth.org> > > > Date: Sun Aug 31 10:55:20 2014 -0500 > > > > > > Fixes for latest DT::TZ > > > > > > does not use any new interface not available before 1.74.
> > > > Because the tests were breaking with earlier versions of DT::TZ. > >
> Indeed? I though the breakage for the fixed by the commit, so there is > not > need to change the version requirement. > > I tested the patched tests against DateTime-TimeZone-1.73 and even > DateTime-TimeZone-1.63 successfully. >
> > Given that DT::TZ is backwards compatible (beyond zone name changes) > > I don't > > see what the problem is.
> > Not entirely. E.g. DT-TZ-1.71 started to require List::AllUtils.
Fair point. However, intentionally staying on old versions of DT::TZ is likely to lead to broken code. Unfortunately DT::TZ bundles up both the API and the time zone data, so you need to upgrade to stay current. I hope to change this at some point in the future.
  Sat Sep 06 15:39:53 2014 DROLSKY [...] cpan.org - Status changed from 'open' to 'rejected'