Skip Menu |

This queue is for tickets about the Devel-PeekPoke CPAN distribution.

Report information
The Basics
Id: 98462
Status: resolved
Priority: 0/
Queue: Devel-PeekPoke
People
Owner: RURBAN [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.03
Fixed in: (no value)

History Show all quoted text
  Sat Aug 30 05:56:27 2014 SREZIC [...] cpan.org - Ticket created
Subject: Fails with perl 5.20.x
With perl 5.20.1 the test suite fails: Devel::PeekPoke::PP does not *yet* support this perl 5.020001, please file a bugreport (it is very very easy to fix) BEGIN failed--compilation aborted at /tmpfs/.cpan-build/Devel-PeekPoke-0.03-h_TBLD/blib/lib/Devel/PeekPoke/PP.pm line 81. Compilation failed in require at /tmpfs/.cpan-build/Devel-PeekPoke-0.03-h_TBLD/blib/lib/Devel/PeekPoke.pm line 16. Compilation failed in require at t/01basic.t line 7. BEGIN failed--compilation aborted at t/01basic.t line 7. t/01basic.t ................
  Sat Aug 30 16:20:41 2014 RURBAN [...] cpan.org - Correspondence added
On Sat Aug 30 05:56:27 2014, SREZIC wrote: Show quoted text
> With perl 5.20.1 the test suite fails:
Attached patch fixes the 3 open bugs. Just bumped the version requirement. -- Reini Urban
Subject: 0001-extend-xpv-access-from-5.18-to-5.21.patch
From 541304d9c390d40761848986bec20aec8473da0c Mon Sep 17 00:00:00 2001 From: Reini Urban <rurban@cpanel.net> Date: Sat, 30 Aug 2014 22:14:02 +0200 Subject: [PATCH] extend xpv access from 5.18 to 5.21 only COW strings changed but they carry just the COW_REFCOUNT at the end of the string, which is transparent here. --- lib/Devel/PeekPoke/PP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git lib/Devel/PeekPoke/PP.pm lib/Devel/PeekPoke/PP.pm index 7e79b56..d3e437c 100644 --- lib/Devel/PeekPoke/PP.pm +++ lib/Devel/PeekPoke/PP.pm @@ -43,7 +43,7 @@ BEGIN { _XPV_ADDR_OFFSET => undef, # it isn't really undefined, we just do not care }); } - elsif (_PERLVERSION < 5.018) { + elsif (_PERLVERSION < 5.022) { # The xpv address is written to the svu_pv, however we may get in trouble # due to padding/alignment when ivsize (thus svu) is larger than PTR_SIZE constant->import( _XPV_IN_SVU_OFFSET => $Config{ivsize} == PTR_SIZE ? 0 : do { -- 2.0.4
  Sat Aug 30 16:20:42 2014 The RT System itself - Status changed from 'new' to 'open'
  Sat Aug 30 16:20:44 2014 RURBAN [...] cpan.org - Status changed from 'open' to 'patched'
  Mon Sep 01 07:05:23 2014 RURBAN [...] cpan.org - Correspondence added
Fixed in 0.04, now on CPAN -- Reini Urban
  Mon Sep 01 07:05:25 2014 RURBAN [...] cpan.org - Status changed from 'patched' to 'resolved'
  Mon Sep 01 07:05:26 2014 RURBAN [...] cpan.org - Taken
  Mon Sep 01 18:59:53 2014 ribasushi [...] leporine.io - Correspondence added
On Sat Aug 30 22:20:41 2014, RURBAN wrote: Show quoted text
> On Sat Aug 30 05:56:27 2014, SREZIC wrote:
> > With perl 5.20.1 the test suite fails:
> > Attached patch fixes the 3 open bugs. Just bumped the version requirement. >
Just a note why the fix hasn't yet been applied to repo as-is: there is a more substantial rewrite underway, will likely push an 05 in 2 weeks which will happen to contain the same logical fix. Thanks for the new upload anyhow ;)