Bug #98441 for Date-Holidays-PT: Issue with encoding in POD

Fri Aug 29 14:48:20 2014 jonasbn [...] cpan.org - Ticket created

Subject:

Issue with encoding in POD

Hi, I got an error from the pod.t test when attempting to install Date::Holidays::PT. It's a pretty basic bug with encoding. I have added the patch as a patch file. I created a fork from gitpan: https://github.com/gitpan/Date-Holidays-PT, which seems to reflect the latest release to CPAN. So you can take it from Gitpan if you want to migrate to CPAN without all of the yak shaving by creating your own fork or I can transfer ownership of my fork to you - so you will have my patch automagically. Take care, jonasbn

Subject:

pod-encoding.patch

diff --git a/lib/Date/Holidays/PT.pm b/lib/Date/Holidays/PT.pm index 0aa0efc..549835a 100644 --- a/lib/Date/Holidays/PT.pm +++ b/lib/Date/Holidays/PT.pm @@ -6,7 +6,6 @@ use strict; use Date::Holidays::Super; use Date::Easter; use Time::JulianDay; -use utf8; my @ISA = qw(Date::Holidays::Super); @@ -175,8 +174,6 @@ sub holidays { return \%holidays; } -=encoding utf8 - =head1 NATIONAL HOLIDAYS The following Portuguese holidays have fixed dates:

Fri Aug 29 15:45:30 2014 ether [...] cpan.org - Correspondence added

Removing the tag altogether is not correct. If the file is encoded in something else than UTF-8, *that* encoding should be declared instead -- or the encoding of the file should be fixed so it really is UTF-8.

Fri Aug 29 15:45:30 2014 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 29 16:17:49 2014 jonasbn [...] gmail.com - Correspondence added

CC:	"jonasbn [...] cpan.org" <jonasbn [...] cpan.org>
Subject:	Re: [rt.cpan.org #98441] Issue with encoding in POD
Date:	Fri, 29 Aug 2014 22:17:38 +0200
To:	"bug-Date-Holidays-PT [...] rt.cpan.org" <bug-Date-Holidays-PT [...] rt.cpan.org>
From:	Jonas Brømsø Nielsen <jonasbn [...] gmail.com>

oh, I got the diff turned around... I will do a new patch and check encoding in the original file, I just assumed UTF8. And perhaps I should get some sleep to my diffs are correct. jonasbn -- Twitter: @jonasbn Tlf/Phn: +45 31546056 Show quoted text

> Den 29/08/2014 kl. 21.45 skrev "Karen Etheridge via RT" <bug-Date-Holidays-PT@rt.cpan.org>: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=98441 > > > Removing the tag altogether is not correct. > > If the file is encoded in something else than UTF-8, *that* encoding should be declared instead -- or the encoding of the file should be fixed so it really is UTF-8. >

Fri Aug 29 17:09:44 2014 jonasbn [...] cpan.org - Correspondence added

Attempting with new patch just for the record... jonasbn

Subject:

pod-encoding-2.patch.

Download pod-encoding-2.patch.
application/octet-stream 319b

Message body not shown because it is not plain text.

Sun Aug 31 05:44:34 2014 jonasbn [...] cpan.org - Correspondence added

Hi, If you are interested and do not have the time, give me COMAINT and I can throw some time at the distribution. jonasbn

Wed Aug 19 07:45:12 2015 ambs [...] cpan.org - Correspondence added

Fixed on CPAN. Will close this ticket as soon as RT gives me perms for that.

Thu Aug 20 07:10:27 2015 ambs [...] cpan.org - Correspondence added

Module reindexed by CPAN, so it should hit mirrors pretty soon. I think this issue is fixed, together with some enhancements on holidays that were temporarily removed from the Portuguese calendar. Anything else, please, let me know! ambs

Thu Aug 20 07:10:42 2015 ambs [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Aug 20 07:10:44 2015 ambs [...] cpan.org - Fixed in 0.03 added