Bug #98340 for NanoMsg-Raw: Errors with running NanoMsg::Raw under Perl 5.20

Tue Aug 26 18:48:31 2014 H.LiebermanBerg [...] gmail.com - Ticket created

Subject:	Errors with running NanoMsg::Raw under Perl 5.20
Date:	Tue, 26 Aug 2014 15:48:21 -0700
To:	"bug-NanoMsg-Raw [...] rt.cpan.org" <bug-NanoMsg-Raw [...] rt.cpan.org>
From:	Harlan Lieberman-Berg <H.LiebermanBerg [...] gmail.com>

Hello, As part of an investigation into Debian bug #756350, olasd and I discovered a bug in the way the XS handles initialization of the optvallen in nn_getsockopt. A patch is attached which hopefully resolves this issue. Sincerely, -- Harlan Lieberman-Berg ~hlieberman

Message body is not shown because sender requested not to inline it.

Sun Aug 31 16:04:25 2014 H.LiebermanBerg [...] gmail.com - Correspondence added

Subject:	[rt.cpan.org #98340] Test failures
Date:	Sun, 31 Aug 2014 13:04:13 -0700
To:	"bug-NanoMsg-Raw [...] rt.cpan.org" <bug-NanoMsg-Raw [...] rt.cpan.org>
From:	Harlan Lieberman-Berg <H.LiebermanBerg [...] gmail.com>

Hello, While the patch does fix many of the test problems, it doesn't unfortunately solve all of them. There are still failures in the t/threads.t test. I opened a bug with the underlying nanomsg library - https://github.com/nanomsg/nanomsg/issues/305 - because I think that the library should handle that read condition. However, I am not altogether convinced that the problem is really on the nanomsg side. I made a rough attempt at porting the test to C (attached), and I don't see the same failure there. I'm not sure if this is due to differences in the way that I ported the test that might miss the exact circumstances to trigger the read failure, or if there is some bug in the XS that's causing it to occur. I'd appreciate you taking a look. Sincerely, -- Harlan Lieberman-Berg ~hlieberman

Message body is not shown because sender requested not to inline it.

Mon Apr 13 22:09:55 2015 hlieberman [...] setec.io - Correspondence added

CC:	bzm [...] 2bz.de, modules [...] perl.org
Subject:	[rt.cpan.org #98340] Release
Date:	Mon, 13 Apr 2015 22:09:33 -0400
To:	bug-nanomsg-raw [...] rt.cpan.org
From:	Harlan Lieberman-Berg <hlieberman [...] setec.io>

Hello everyone, I'm willing to adopt this module for one release, in order to incorporate bugs that have been fixed downstream in Debian, and to disable a test causing FTBFS occasionally. I help maintain this module in Debian, so I will be around to keep an eye on things as needed, but I'm not comfortable offering to adopt the package wholesale; I'm not sure my XS skills are up to snuff. Sincerely, -- Harlan Lieberman-Berg ~hlieberman

Download signature.asc
application/pgp-signature 948b

Message body not shown because it is not plain text.

Mon Apr 13 22:09:56 2015 The RT System itself - Status changed from 'new' to 'open'

Thu Apr 30 16:19:36 2015 mst [...] shadowcat.co.uk - Correspondence added

CC:	bug-nanomsg-raw [...] rt.cpan.org, bzm [...] 2bz.de, modules [...] perl.org
Subject:	Re: [rt.cpan.org #98340] Release
Date:	Thu, 30 Apr 2015 20:19:14 +0000
To:	Harlan Lieberman-Berg <hlieberman [...] setec.io>
From:	Matt S Trout <mst [...] shadowcat.co.uk>

If nobody has any objections, I'll grant co-maint of this module to both ADOPTME and HARLAN tomorrow. If people think I should be doing something else, please make suggestions. On Mon, Apr 13, 2015 at 10:09:33PM -0400, Harlan Lieberman-Berg wrote: Show quoted text

> Hello everyone, > > I'm willing to adopt this module for one release, in order to > incorporate bugs that have been fixed downstream in Debian, and to > disable a test causing FTBFS occasionally. > > I help maintain this module in Debian, so I will be around to keep an > eye on things as needed, but I'm not comfortable offering to adopt the > package wholesale; I'm not sure my XS skills are up to snuff. > > Sincerely, > -- > Harlan Lieberman-Berg > ~hlieberman

-- Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ Email me now on mst (at) shadowcat.co.uk and let's chat about how our CPAN commercial support, training and consultancy packages could help your team.

Thu Apr 30 16:48:09 2015 xdg [...] xdg.me - Correspondence added

CC:	Harlan Lieberman-Berg <hlieberman [...] setec.io>, bug-nanomsg-raw [...] rt.cpan.org, bzm [...] 2bz.de, "modules [...] perl.org" <modules [...] perl.org>
Subject:	Re: [rt.cpan.org #98340] Release
Date:	Thu, 30 Apr 2015 16:47:25 -0400
To:	Matt S Trout <mst [...] shadowcat.co.uk>
From:	David Golden <xdg [...] xdg.me>

FLORA is primary maint, now, so shouldn't this go through him? On Thu, Apr 30, 2015 at 4:19 PM, Matt S Trout <mst@shadowcat.co.uk> wrote: Show quoted text

> If nobody has any objections, I'll grant co-maint of this module to > both ADOPTME and HARLAN tomorrow. > > If people think I should be doing something else, please make suggestions. > > On Mon, Apr 13, 2015 at 10:09:33PM -0400, Harlan Lieberman-Berg wrote:

> > Hello everyone, > > > > I'm willing to adopt this module for one release, in order to > > incorporate bugs that have been fixed downstream in Debian, and to > > disable a test causing FTBFS occasionally. > > > > I help maintain this module in Debian, so I will be around to keep an > > eye on things as needed, but I'm not comfortable offering to adopt the > > package wholesale; I'm not sure my XS skills are up to snuff. > > > > Sincerely, > > -- > > Harlan Lieberman-Berg > > ~hlieberman

> > > > -- > Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a > clue > > http://shadowcat.co.uk/blog/matt-s-trout/ > http://twitter.com/shadowcat_mst/ > > Email me now on mst (at) shadowcat.co.uk and let's chat about how our CPAN > commercial support, training and consultancy packages could help your team. >

-- David Golden <xdg@xdg.me> Twitter/IRC: @xdg

Thu Apr 30 17:00:41 2015 mst [...] shadowcat.co.uk - Correspondence added

CC:	Harlan Lieberman-Berg <hlieberman [...] setec.io>, bug-nanomsg-raw [...] rt.cpan.org, bzm [...] 2bz.de, "modules [...] perl.org" <modules [...] perl.org>, rafl [...] cpan.org
Subject:	Re: [rt.cpan.org #98340] Release
Date:	Thu, 30 Apr 2015 21:00:28 +0000
To:	David Golden <xdg [...] xdg.me>
From:	Matt S Trout <mst [...] shadowcat.co.uk>

On Thu, Apr 30, 2015 at 04:47:25PM -0400, David Golden wrote: Show quoted text

> FLORA is primary maint, now, so shouldn't this go through him?

Huh, I wasn't aware there was already an attempted adoption - there doesn't seem to've been a release yet. rafl, whaddya want us to do? -- Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ Email me now on mst (at) shadowcat.co.uk and let's chat about how our CPAN commercial support, training and consultancy packages could help your team.

Thu Apr 30 17:18:52 2015 bzm [...] 2bz.de - Correspondence added

CC:	David Golden <xdg [...] xdg.me>, Harlan Lieberman-Berg <hlieberman [...] setec.io>, bug-nanomsg-raw [...] rt.cpan.org, "modules [...] perl.org" <modules [...] perl.org>, rafl [...] cpan.org
Subject:	Re: [rt.cpan.org #98340] Release
Date:	Thu, 30 Apr 2015 23:18:42 +0200
To:	Matt S Trout <mst [...] shadowcat.co.uk>
From:	Boris Zentner <bzm [...] 2bz.de>

I think those bugs are fixed long ago. If not please create issues on github or here patches are welcome.But I think everything is already fixed in the latest release. http://cpansearch.perl.org/src/BORISZ/NanoMsg-Raw-0.04/Changes -- Boris Zentner Show quoted text

> Am 30.04.2015 um 23:00 schrieb Matt S Trout <mst@shadowcat.co.uk>: > > On Thu, Apr 30, 2015 at 04:47:25PM -0400, David Golden wrote:

>> FLORA is primary maint, now, so shouldn't this go through him?

> > Huh, I wasn't aware there was already an attempted adoption - there doesn't > seem to've been a release yet. > > rafl, whaddya want us to do? > > -- > Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue > > http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ > > Email me now on mst (at) shadowcat.co.uk and let's chat about how our CPAN > commercial support, training and consultancy packages could help your team.

Download signature.asc
application/pgp-signature 495b

Message body not shown because it is not plain text.

Thu Apr 30 17:22:51 2015 rafl [...] debian.org - Correspondence added

Subject:	Re: Fw: Re: [rt.cpan.org #98340] Release
Date:	Thu, 30 Apr 2015 17:22:26 -0400
To:	Matt S Trout <mst [...] shadowcat.co.uk>,bzm [...] 2bz.de,modules [...] perl.org,bug-nanomsg-raw [...] rt.cpan.org
From:	Florian Ragwitz <rafl [...] debian.org>

I had given Boris (on Cc, hi Boris!) co-maint a while back so he could release some of his changes, which he did. Boris, do you think getting these fixes released is something you could help with? Would you mind more co-maintainers being added? I certainly have no objections to that as the original author. On April 30, 2015 5:11:21 PM EDT, Matt S Trout <mst@shadowcat.co.uk> wrote: Show quoted text

>DAMNIT I CC'ED rafl@ YET AGAIN > >----- Forwarded message from Matt S Trout <mst@shadowcat.co.uk> ----- > >Date: Thu, 30 Apr 2015 21:00:28 +0000 >From: Matt S Trout <mst@shadowcat.co.uk> >To: David Golden <xdg@xdg.me> >Cc: Harlan Lieberman-Berg <hlieberman@setec.io>, > bug-nanomsg-raw@rt.cpan.org, bzm@2bz.de, > "modules@perl.org" <modules@perl.org>, rafl@cpan.org >Subject: Re: [rt.cpan.org #98340] Release >User-Agent: Mutt/1.5.20 (2009-06-14) > >On Thu, Apr 30, 2015 at 04:47:25PM -0400, David Golden wrote:

>> FLORA is primary maint, now, so shouldn't this go through him?

> >Huh, I wasn't aware there was already an attempted adoption - there >doesn't >seem to've been a release yet. > >rafl, whaddya want us to do? > >-- >Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit >and a clue > >http://shadowcat.co.uk/blog/matt-s-trout/ >http://twitter.com/shadowcat_mst/ > >Email me now on mst (at) shadowcat.co.uk and let's chat about how our >CPAN >commercial support, training and consultancy packages could help your >team. > >----- End forwarded message ----- > >-- >Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit >and a clue > >http://shadowcat.co.uk/blog/matt-s-trout/ >http://twitter.com/shadowcat_mst/ > >Email me now on mst (at) shadowcat.co.uk and let's chat about how our >CPAN >commercial support, training and consultancy packages could help your >team.

-- Sent from Kaiten Mail. Please excuse my brevity.

Thu Apr 30 17:27:19 2015 hlieberman [...] setec.io - Correspondence added

CC:	David Golden <xdg [...] xdg.me>, bug-nanomsg-raw [...] rt.cpan.org, "modules\ [...] perl.org" <modules [...] perl.org>, rafl [...] cpan.org
Subject:	Re: [rt.cpan.org #98340] Release
Date:	Thu, 30 Apr 2015 17:27:10 -0400
To:	Boris Zentner <bzm [...] 2bz.de>, Matt S Trout <mst [...] shadowcat.co.uk>
From:	Harlan Lieberman-Berg <hlieberman [...] setec.io>

Boris Zentner <bzm@2bz.de> writes: Show quoted text

> I think those bugs are fixed long ago. If not please create issues on > github or here patches are welcome.But I think everything is already > fixed in the latest release.

Hi Boris, Unfortunately, this bug is definitely extant. I've applied one patch in this thread that fixes problems under Perl 5.20, but we've been trying to solve problems in the test suite in Debian for a while now. (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756350). I think the threads.t test is broken enough that it simply should be removed entirely; I've been unable to figure out why it intermittentely fails, but it's using the old thread code in Perl anyway, and probably isn't providing any value. Sincerely, -- Harlan Lieberman-Berg ~hlieberman

Thu Apr 30 17:41:34 2015 hlieberman [...] setec.io - Correspondence added

CC:	David Golden <xdg [...] xdg.me>, bug-nanomsg-raw [...] rt.cpan.org, "modules\ [...] perl.org" <modules [...] perl.org>, rafl [...] cpan.org
Subject:	Re: [rt.cpan.org #98340] Release
Date:	Thu, 30 Apr 2015 17:41:27 -0400
To:	Boris Zentner <bzm [...] 2bz.de>, Matt S Trout <mst [...] shadowcat.co.uk>
From:	Harlan Lieberman-Berg <hlieberman [...] setec.io>

Harlan Lieberman-Berg <hlieberman@setec.io> writes: Show quoted text

> Unfortunately, this bug is definitely extant.

Egg on my face -- looks like you did indeed make the same fix as was in the patch in the newer versions. Show quoted text

> I think the threads.t test is broken enough that it simply should be > removed entirely...

This is still an issue, though. Sincerely, -- Harlan Lieberman-Berg ~hlieberman

Sat May 02 08:40:14 2015 bzm [...] 2bz.de - Correspondence added

CC:	Matt S Trout <mst [...] shadowcat.co.uk>, modules [...] perl.org, bug-nanomsg-raw [...] rt.cpan.org, Harlan Lieberman-Berg <hlieberman [...] setec.io>
Subject:	Re: [rt.cpan.org #98340] Release
Date:	Sat, 2 May 2015 14:39:59 +0200
To:	Florian Ragwitz <rafl [...] debian.org>
From:	Boris Zentner <bzm [...] 2bz.de>

Hi, I think everyone here has overlooked the last two releases and that has caused confusion. The patch is not needed. The issue is fixed since 0.03. In general I have no objections against more co-maintainers and I accept all decisions from Florian. But I do not see any need for yet another maintainer. To fix the threads.t test, I follow Harlan’s suggestion and release another version without this test. -- Boris Zentner Show quoted text

> Am 30.04.2015 um 23:22 schrieb Florian Ragwitz <rafl@debian.org>: > > I had given Boris (on Cc, hi Boris!) co-maint a while back so he could release some of his changes, which he did. > > Boris, do you think getting these fixes released is something you could help with? Would you mind more co-maintainers being added? I certainly have no objections to that as the original author. > > > > On April 30, 2015 5:11:21 PM EDT, Matt S Trout <mst@shadowcat.co.uk> wrote: > DAMNIT I CC'ED rafl@ YET AGAIN > > ----- Forwarded message from Matt S Trout <mst@shadowcat.co.uk> ----- > > Date: Thu, 30 Apr 2015 21:00:28 +0000 > From: Matt S Trout <mst@shadowcat.co.uk> > To: David Golden <xdg@xdg.me> > Cc: Harlan Lieberman-Berg <hlieberman@setec.io>, > bug-nanomsg-raw@rt.cpan.org, bzm@2bz.de, > "modules@perl.org" <modules@perl.org>, rafl@cpan.org > Subject: Re: [rt.cpan.org #98340] Release > User-Agent: Mutt/1.5.20 (2009-06-14) > > On Thu, Apr 30, 2015 at 04:47:25PM -0400, David Golden wrote: > FLORA is primary maint, now, so shouldn't this go through him? > > Huh, I wasn't aware there was already an attempted adoption - there doesn't > seem to've been a release yet. > > rafl, whaddya want us to do? > > -- > Sent from Kaiten Mail. Please excuse my brevity.

Download signature.asc
application/pgp-signature 495b

Message body not shown because it is not plain text.