Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 98291
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse
People
Owner: Nobody in particular
Requestors: NEILB [...] cpan.org
Cc: ether [...] cpan.org
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.92
Fixed in: (no value)

History Show all quoted text
  Sun Aug 24 06:51:16 2014 NEILB [...] cpan.org - Ticket created
Subject: Quoted filename including space in MANIFEST not handled correctly
If you look at my dist BackPAN-Index-Create in CPANTS you'll see it has a red cross against 'manifest matches dist' http://cpants.cpanauthors.org/dist/BackPAN-Index-Create The MANIFEST is fine, but it has one quoted path, because one of the test files has a trailing space in the name: 't/testpan/authors/id/P/PO/POGLE/Wood-Pogle-0.001.tar.gz ' I haven't looked at the code, but given the error I'm getting, it looks quoted entries in MANIFEST aren't handled right. Cheers, Neil
  Sun Aug 24 07:10:35 2014 ishigaki [...] cpan.org - Correspondence added
On Sun Aug 24 19:51:16 2014, NEILB wrote: Show quoted text
> If you look at my dist BackPAN-Index-Create in CPANTS you'll see it > has a red cross against 'manifest matches dist' > > http://cpants.cpanauthors.org/dist/BackPAN-Index-Create > > The MANIFEST is fine, but it has one quoted path, because one of the > test files has a trailing space in the name: > > 't/testpan/authors/id/P/PO/POGLE/Wood-Pogle-0.001.tar.gz ' > > I haven't looked at the code, but given the error I'm getting, it > looks quoted entries in MANIFEST aren't handled right. > > Cheers, > Neil
I doubt that, because the file with a trailing space is "Missing in Dist", that means, it's listed in MANIFEST correctly, but File::Find can't find it. Most probably it's because the file is not extracted with the trailing space, but I'll look at it more closely when I finish writing my slides... See also https://metacpan.org/source/NEILB/BackPAN-Index-Create-0.12/t/testpan/authors/id/P/PO/POGLE , which seems to have the same problem.
  Sun Aug 24 07:10:36 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Aug 24 12:58:21 2014 ether [...] cpan.org - Cc ETHER added
  Thu Nov 20 01:29:37 2014 ishigaki [...] cpan.org - Correspondence added
On Sun Aug 24 20:10:35 2014, ISHIGAKI wrote: Show quoted text
> On Sun Aug 24 19:51:16 2014, NEILB wrote:
> > If you look at my dist BackPAN-Index-Create in CPANTS you'll see it > > has a red cross against 'manifest matches dist' > > > > http://cpants.cpanauthors.org/dist/BackPAN-Index-Create > > > > The MANIFEST is fine, but it has one quoted path, because one of the > > test files has a trailing space in the name: > > > > 't/testpan/authors/id/P/PO/POGLE/Wood-Pogle-0.001.tar.gz ' > > > > I haven't looked at the code, but given the error I'm getting, it > > looks quoted entries in MANIFEST aren't handled right. > > > > Cheers, > > Neil
> > I doubt that, because the file with a trailing space is "Missing in > Dist", that means, it's listed in MANIFEST correctly, but File::Find > can't find it. Most probably it's because the file is not extracted > with the trailing space, but I'll look at it more closely when I > finish writing my slides... > > See also https://metacpan.org/source/NEILB/BackPAN-Index-Create- > 0.12/t/testpan/authors/id/P/PO/POGLE , which seems to have the same > problem.
For the record, https://github.com/jib/archive-tar-new/pull/9
  Sun Apr 24 11:24:06 2016 ishigaki [...] cpan.org - Correspondence added
On Thu Nov 20 15:29:37 2014, ISHIGAKI wrote: Show quoted text
> On Sun Aug 24 20:10:35 2014, ISHIGAKI wrote:
> > On Sun Aug 24 19:51:16 2014, NEILB wrote:
> > > If you look at my dist BackPAN-Index-Create in CPANTS you'll see it > > > has a red cross against 'manifest matches dist' > > > > > > http://cpants.cpanauthors.org/dist/BackPAN-Index-Create > > > > > > The MANIFEST is fine, but it has one quoted path, because one of the > > > test files has a trailing space in the name: > > > > > > 't/testpan/authors/id/P/PO/POGLE/Wood-Pogle-0.001.tar.gz ' > > > > > > I haven't looked at the code, but given the error I'm getting, it > > > looks quoted entries in MANIFEST aren't handled right. > > > > > > Cheers, > > > Neil
> > > > I doubt that, because the file with a trailing space is "Missing in > > Dist", that means, it's listed in MANIFEST correctly, but File::Find > > can't find it. Most probably it's because the file is not extracted > > with the trailing space, but I'll look at it more closely when I > > finish writing my slides... > > > > See also https://metacpan.org/source/NEILB/BackPAN-Index-Create- > > 0.12/t/testpan/authors/id/P/PO/POGLE , which seems to have the same > > problem.
> > For the record, https://github.com/jib/archive-tar-new/pull/9 >
Archive::Tar 2.06 with this fix was released, and BackPAN-Index-Create-0.12.tar.gz started failing extraction for other reasons... ("Could not chown" => "Could not update timestamp") Anyway, I'd close this considering the original issue is addressed.
  Sun Apr 24 11:24:15 2016 ishigaki [...] cpan.org - Correspondence added
On Thu Nov 20 15:29:37 2014, ISHIGAKI wrote: Show quoted text
> On Sun Aug 24 20:10:35 2014, ISHIGAKI wrote:
> > On Sun Aug 24 19:51:16 2014, NEILB wrote:
> > > If you look at my dist BackPAN-Index-Create in CPANTS you'll see it > > > has a red cross against 'manifest matches dist' > > > > > > http://cpants.cpanauthors.org/dist/BackPAN-Index-Create > > > > > > The MANIFEST is fine, but it has one quoted path, because one of the > > > test files has a trailing space in the name: > > > > > > 't/testpan/authors/id/P/PO/POGLE/Wood-Pogle-0.001.tar.gz ' > > > > > > I haven't looked at the code, but given the error I'm getting, it > > > looks quoted entries in MANIFEST aren't handled right. > > > > > > Cheers, > > > Neil
> > > > I doubt that, because the file with a trailing space is "Missing in > > Dist", that means, it's listed in MANIFEST correctly, but File::Find > > can't find it. Most probably it's because the file is not extracted > > with the trailing space, but I'll look at it more closely when I > > finish writing my slides... > > > > See also https://metacpan.org/source/NEILB/BackPAN-Index-Create- > > 0.12/t/testpan/authors/id/P/PO/POGLE , which seems to have the same > > problem.
> > For the record, https://github.com/jib/archive-tar-new/pull/9 >
Archive::Tar 2.06 with this fix was released, and BackPAN-Index-Create-0.12.tar.gz started failing extraction for other reasons... ("Could not chown" => "Could not update timestamp") Anyway, I'd close this considering the original issue is addressed.
  Sun Apr 24 11:24:15 2016 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'