Skip Menu |

This queue is for tickets about the Imager CPAN distribution.

Report information
The Basics
Id: 98234
Status: resolved
Priority: 0/
Queue: Imager
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.000
Fixed in: (no value)

History Show all quoted text
  Thu Aug 21 14:15:10 2014 SREZIC [...] cpan.org - Ticket created
Subject: Conflict with Perl's my_strerror (perl 5.21.x)
perl 5.21.x defines Perl_my_strerror and probably creates a my_strerror alias, which conflicts with the my_strerror function in perlio.c. See http://matrix.cpantesters.org/?dist=Imager%201.000 for a number of build fails because of this.
  Thu Aug 21 14:23:35 2014 SREZIC [...] cpan.org - Correspondence added
On 2014-08-21 14:15:10, SREZIC wrote: Show quoted text
> perl 5.21.x defines Perl_my_strerror and probably creates a > my_strerror alias, which conflicts with the my_strerror function in > perlio.c. See http://matrix.cpantesters.org/?dist=Imager%201.000 for a > number of build fails because of this.
Attached a possible patch.
Subject: Imager-1.000-RT98234.patch
From c1ef29c62235b599f8bc6855c293d54c928f2a52 Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Thu, 21 Aug 2014 20:15:38 +0200 Subject: [PATCH] my_strerror is defined since perl 5.21.x This change fixes https://rt.cpan.org/Ticket/Display.html?id=98234 --- perlio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/perlio.c b/perlio.c index d69e519..c4a6e87 100644 --- a/perlio.c +++ b/perlio.c @@ -18,6 +18,8 @@ static int perlio_closer(void *handle); static void perlio_destroy(void *handle); +/* my_strerror is defined since perl 5.21.x */ +#undef my_strerror static const char *my_strerror(pTHX_ int err); #ifndef tTHX -- 1.8.3.4
  Mon Aug 25 01:19:13 2014 TONYC [...] cpan.org - Correspondence added
On Thu Aug 21 14:23:35 2014, SREZIC wrote: Show quoted text
> On 2014-08-21 14:15:10, SREZIC wrote:
> > perl 5.21.x defines Perl_my_strerror and probably creates a > > my_strerror alias, which conflicts with the my_strerror function in > > perlio.c. See http://matrix.cpantesters.org/?dist=Imager%201.000 for a > > number of build fails because of this.
> > Attached a possible patch.
Thanks, applied for the next release. Tony
  Mon Aug 25 01:19:14 2014 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 25 01:19:15 2014 TONYC [...] cpan.org - Status changed from 'open' to 'patched'
  Fri Jan 23 22:13:24 2015 TONYC [...] cpan.org - Correspondence added
On Mon Aug 25 01:19:13 2014, TONYC wrote: Show quoted text
> On Thu Aug 21 14:23:35 2014, SREZIC wrote:
> > On 2014-08-21 14:15:10, SREZIC wrote:
> > > perl 5.21.x defines Perl_my_strerror and probably creates a > > > my_strerror alias, which conflicts with the my_strerror function in > > > perlio.c. See http://matrix.cpantesters.org/?dist=Imager%201.000 for a > > > number of build fails because of this.
> > > > Attached a possible patch.
> > Thanks, applied for the next release.
And released in Imager 1.001. Thanks, Tony
  Fri Jan 23 22:13:26 2015 TONYC [...] cpan.org - Status changed from 'patched' to 'resolved'