Skip Menu |

This queue is for tickets about the DB_File-Lock CPAN distribution.

Report information
The Basics
Id: 98224
Status: new
Priority: 0/
Queue: DB_File-Lock

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.05
Fixed in: (no value)



Subject: Test fails with perl 5.21.x: Can't use 'defined(%hash)'
See subject. A sample test report showing this failure with perl 5.21.3: http://www.cpantesters.org/cpan/report/2fa35c1a-1b47-11e4-9337-cabdc7ccabfc
On 2014-08-21 04:39:53, SREZIC wrote: Show quoted text
> See subject. A sample test report showing this failure with perl 5.21.3: > http://www.cpantesters.org/cpan/report/2fa35c1a-1b47-11e4-9337-cabdc7ccabfc
The attached patch should fix the problem.
Subject: DB_File-Lock-0.05-RT98224.patch
From 247a7ec3a57f2bca977531281f258d5e4ed46c1f Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Thu, 21 Aug 2014 19:54:41 +0200 Subject: [PATCH] don't use defined %hash This fixes https://rt.cpan.org/Ticket/Display.html?id=98224 --- test.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 test.pl diff --git a/test.pl b/test.pl old mode 100644 new mode 100755 index 92ebcf6..cba6da6 --- a/test.pl +++ b/test.pl @@ -81,7 +81,7 @@ if ( not defined $pid ) { sleep(1); $TEST_NUM += 2; report_result( not tie %hash3, 'DB_File::Lock', $file1, O_RDWR, 0600, $DB_HASH, $nonblock_write ); - report_result( not defined %hash3 ); # double check and satisfy -w about %hash3 + report_result( not keys %hash3 ); # double check and satisfy -w about %hash3 $TEST_NUM += 1; report_result( wait() == $pid ); report_result( tie %hash3, 'DB_File::Lock', $file1, O_RDWR, 0600, $DB_HASH, $nonblock_write ); -- 1.8.3.4
On 2014-08-21 13:58:29, SREZIC wrote: Show quoted text
> On 2014-08-21 04:39:53, SREZIC wrote:
> > See subject. A sample test report showing this failure with perl > > 5.21.3: > > http://www.cpantesters.org/cpan/report/2fa35c1a-1b47-11e4-9337- > > cabdc7ccabfc
> > The attached patch should fix the problem.
The problem still appears with perl 5.21.10.
On 2015-03-20 17:00:06, SREZIC wrote: Show quoted text
> On 2014-08-21 13:58:29, SREZIC wrote:
> > On 2014-08-21 04:39:53, SREZIC wrote:
> > > See subject. A sample test report showing this failure with perl > > > 5.21.3: > > > http://www.cpantesters.org/cpan/report/2fa35c1a-1b47-11e4-9337- > > > cabdc7ccabfc
> > > > The attached patch should fix the problem.
> > The problem still appears with perl 5.21.10.
And with the next stable perl 5.22.0.
On 2015-05-20 14:10:39, SREZIC wrote: Show quoted text
> On 2015-03-20 17:00:06, SREZIC wrote:
> > On 2014-08-21 13:58:29, SREZIC wrote:
> > > On 2014-08-21 04:39:53, SREZIC wrote:
> > > > See subject. A sample test report showing this failure with perl > > > > 5.21.3: > > > > http://www.cpantesters.org/cpan/report/2fa35c1a-1b47-11e4-9337- > > > > cabdc7ccabfc
> > > > > > The attached patch should fix the problem.
> > > > The problem still appears with perl 5.21.10.
> > And with the next stable perl 5.22.0.
Fails also with stable 5.24.0, and the current bleadperl 5.25.1. I'm willing to do a release with this patch. Regards, Slaven
On 2016-05-21 02:28:45, SREZIC wrote: Show quoted text
> On 2015-05-20 14:10:39, SREZIC wrote:
> > On 2015-03-20 17:00:06, SREZIC wrote:
> > > On 2014-08-21 13:58:29, SREZIC wrote:
> > > > On 2014-08-21 04:39:53, SREZIC wrote:
> > > > > See subject. A sample test report showing this failure with perl > > > > > 5.21.3: > > > > > http://www.cpantesters.org/cpan/report/2fa35c1a-1b47-11e4-9337- > > > > > cabdc7ccabfc
> > > > > > > > The attached patch should fix the problem.
> > > > > > The problem still appears with perl 5.21.10.
> > > > And with the next stable perl 5.22.0.
> > Fails also with stable 5.24.0, and the current bleadperl 5.25.1. > > I'm willing to do a release with this patch.
Still failing with perl 5.28.0-RC1.