Bug #98182 for mod_perl: Couple of Patches

Tue Aug 19 15:14:25 2014 dwheeler [...] cpan.org - Ticket created

Subject:	Couple of Patches
Date:	Tue, 19 Aug 2014 12:14:02 -0700
To:	bug-mod_perl [...] rt.cpan.org
From:	"David E. Wheeler" <dwheeler [...] cpan.org>

I had to apply these patches to get mod_perl tests to pass. mod_perl-undef_args.patch: Fixes an error on Perl 5.20 when args returns undef. mod_perl-header_underscore.patch: Supports LWP > 6.0. Best, David

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 842b

Message body not shown because it is not plain text.

Tue Aug 19 16:54:10 2014 dwheeler [...] cpan.org - Correspondence added

Found another instance of an undefined error. Updated patch attached.

Subject:

mod_perl-undef_args.patch

--- a/t/response/TestDirective/perlloadmodule2.pm 2014-08-14 13:55:56.331568918 -0700 +++ b/t/response/TestDirective/perlloadmodule2.pm 2014-08-14 13:55:58.599567494 -0700 @@ -82,7 +82,7 @@ my $s = $r->server; - if ($r->args eq 'srv') { + if ($r->args || '' eq 'srv') { my $srv_cfg = $self->get_config($s); $r->print("srv: @{ $srv_cfg->{MyMergeTest}||[] }"); } --- a/Apache-Reload/t/lib/Apache2/TestReload.pm 2014-08-19 13:36:49.324352146 -0700 +++ b/Apache-Reload/t/lib/Apache2/TestReload.pm 2014-08-19 13:36:51.357351017 -0700 @@ -15,7 +15,7 @@ sub handler { my $r = shift; $pass++; - if ($r->args eq 'last') { + if ($r->args || '' eq 'last') { Apache2::Reload->unregister_module($package); ModPerl::Util::unload_package($package); $pass = 0;

Thu Oct 30 04:22:37 2014 shay [...] cpan.org - Correspondence added

Thanks for the patches, but these changes have already been made in trunk (r1528836, r1565579 and r1605020).

Thu Oct 30 04:22:37 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 30 04:22:38 2014 shay [...] cpan.org - Status changed from 'open' to 'resolved'