| Subject: | 03insert.t failing in 1.07 |
In the following test report:
http://www.nntp.perl.org/group/perl.cpan.testers/165923
There appears to be a problem with the testing of the version of DBI. The skip, according to Test.pm, is incorrect. The patch here appears to fix the error.
--- C:\wip\diffs\DBD-SQLite\DBD-SQLite-1.07/t/03insert.t Mon Jan 17 10:25:50 2005
+++ C:\wip\diffs\DBD-SQLite\DBD-SQLite-1.07-barbie/t/03insert.t Mon Jan 17 10:35:31 2005
@@ -8,12 +8,9 @@
ok(my $rows = $sth->execute("Fred", "Bloggs", "fred\@bloggs.com"));
ok($rows == 1);
ok($dbh->func('last_insert_rowid'));
-if ($DBI::VERSION < 1.43) {
- skip("last_insert_id requires DBI v1.43");
-}
-else {
- ok($dbh->last_insert_id(undef, undef, undef, undef));
-}
+my $unless_min_dbi =
+ $DBI::VERSION < 1.43 ? 'last_insert_id requires DBI v1.43' : '';
+skip($unless_min_dbi, $dbh->last_insert_id(undef, undef, undef, undef) );
ok($sth->execute("test", "test", "1"));
ok($sth->execute("test", "test", "2"));
ok($sth->execute("test", "test", "3"));