Skip Menu |

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 98154
Status: rejected
Priority: 0/
Queue: DBIx-Class
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Aug 18 16:18:21 2014 ether [...] cpan.org - Ticket created
Subject: use Module::Runtime::module_notional_filename
DBIx/Class/Optional/Dependencies.pm repeats the logic from module_notional_filename. DRY. DBIx/Class/Optional/Dependencies.pm:757: (my $modfn = __PACKAGE__ . '.pm') =~ s|::|/|g; DBIx/Class/Optional/Dependencies.pm:759: (my $podfn = "$pod_dir/$modfn") =~ s/\.pm$/\.pod/;
  Mon Aug 18 18:47:53 2014 ilmari+cpan [...] ilmari.org - Correspondence added
Show quoted text
> DBIx/Class/Optional/Dependencies.pm repeats the logic from > module_notional_filename. DRY.
https://github.com/dbsrgits/dbix-class/blob/master/lib/DBIx/Class/Optional/Dependencies.pm#L8 # NO EXTERNAL NON-5.8.1 CORE DEPENDENCIES EVER (e.g. C::A::G) # This module is to be loaded by Makefile.PM on a pristine system Rejected.
  Mon Aug 18 18:47:55 2014 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 18 18:47:56 2014 ilmari+cpan [...] ilmari.org - Status changed from 'open' to 'rejected'
  Mon Aug 18 18:56:56 2014 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #98154] use Module::Runtime::module_notional_filename
Date: Mon, 18 Aug 2014 15:56:46 -0700
To: Dagfinn Ilmari Mannsaker via RT <bug-DBIx-Class [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Mon, Aug 18, 2014 at 06:47:55PM -0400, Dagfinn Ilmari Mannsaker via RT wrote: Show quoted text
> # NO EXTERNAL NON-5.8.1 CORE DEPENDENCIES EVER (e.g. C::A::G) > # This module is to be loaded by Makefile.PM on a pristine system > Rejected.
I was going to say "ok, I'll work on getting MR cored", but I see you only want things that were in core as of 5.8.1. *shakes fist* :)