Skip Menu |

This queue is for tickets about the Unicode-Stringprep CPAN distribution.

Report information
The Basics
Id: 98106
Status: resolved
Priority: 0/
Queue: Unicode-Stringprep

People
Owner: CFAERBER [...] cpan.org
Requestors: fraserbn [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.105



Subject: [PATCH] Silence "Redundant argument in sprintf" warnings
These haven't made it to a stable release of perl yet, but due to the NoWarnings test, it was causing make test to fail.
Subject: 0001-Silence-Redundant-argument-in-sprintf-warnings.patch
From d54bc1a3753809734d38a64a7463573ce816b476 Mon Sep 17 00:00:00 2001 From: Brian Fraser <fraserbn@gmail.com> Date: Sun, 17 Aug 2014 11:04:48 +0200 Subject: [PATCH] Silence "Redundant argument in sprintf" warnings These haven't made it to a stable release of perl yet. --- lib/Unicode/Stringprep.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/Unicode/Stringprep.pm b/lib/Unicode/Stringprep.pm index 55d5c0d..0ad3841 100644 --- a/lib/Unicode/Stringprep.pm +++ b/lib/Unicode/Stringprep.pm @@ -139,10 +139,9 @@ sub _compile_set { return undef if !@set; return '['.join('', map { - sprintf( $_->[0] >= $_->[1] - ? "\\x{%X}" - : "\\x{%X}-\\x{%X}", - @{$_}) + $_->[0] >= $_->[1] + ? sprintf("\\x{%X}", $_->[0]) + : sprintf("\\x{%X}-\\x{%X}", @{$_}[0,1]) } @set ).']'; } -- 1.7.12.4 (Apple Git-37)
Thank you for reporting this issue. I'll release a new version with your patch shortly.