Bug #97934 for libnet: constructor does not set $@

Mon Aug 11 11:42:46 2014 BGU [...] cpan.org - Ticket created

Subject:

constructor does not set $@

my $ftp = Net::FTP->new( $ftp_server, Debug => 0 ) or die "$@"; Use of uninitialized value $@ in concatenation (.) or string Net::FTP->new does not set $@ as the documentation mentions, but sets @! instead

Tue Aug 12 14:41:36 2014 ether [...] cpan.org - Correspondence added

On 2014-08-11 08:42:46, BGU wrote: Show quoted text

> my $ftp = Net::FTP->new( $ftp_server, Debug => 0 ) or die "$@"; > > Use of uninitialized value $@ in concatenation (.) or string > > Net::FTP->new does not set $@ as the documentation mentions, but sets > @! instead

It sounds pretty odd to me that a constructor would do anything other than return a blessed object or die. That's not very perlish!

Tue Aug 12 14:41:37 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Aug 14 08:56:41 2014 shay [...] cpan.org - Correspondence added

On Mon Aug 11 11:42:46 2014, BGU wrote: Show quoted text

> my $ftp = Net::FTP->new( $ftp_server, Debug => 0 ) or die "$@"; > > Use of uninitialized value $@ in concatenation (.) or string > > Net::FTP->new does not set $@ as the documentation mentions, but sets > @! instead

Can you give an example of this? Looking at the code, it mostly does what it says on the tin, namely, return undef and put an error message in $@ (however un-perlish that may be!). In some cases it does actually croak() instead! E.g. Non-existent host: Show quoted text

>perl -MNet::FTP -le "$f = Net::FTP->new('XXX') or print 'Error: ' . $@"

Error: Net::FTP: Bad hostname 'XXX' or localhost with no FTP server: Show quoted text

>perl -MNet::FTP -le "$f = Net::FTP->new('localhost') or print 'Error: ' . $@"

Error: Net::FTP: connect: 10061