Bug #9793 for CPANPLUS-Dist-Build: CPANPLUS FAIL reports using Module::Build do not include tests output

Sun Jan 16 16:19:09 2005 SAPER [...] cpan.org - Ticket created

Subject:

FAIL reports does not include tests output

Hello Jos, The FAIL reports sent by CPANPLUS 0.051 don't include the output of "make test" or "Build test", whereas CPANPLUS 0.050_xx did. While not being severe, this may be annoying to an author who receive such reports because they he then don't have the opportunity to immediatly know (for example) wihch test failed. For reference, here[1] is a FAIL report sent by CPANPLUS 0.050_xx and here[2] is one sent by CPANPLUS 0.051. [1] http://www.nntp.perl.org/group/perl.cpan.testers/175706 [2] http://www.nntp.perl.org/group/perl.cpan.testers/178985 Regards, Sébastien Aperghis-Tramoni

Mon Jan 17 03:02:30 2005 kane [...] cpan.org - Correspondence added

Subject:

CPANPLUS FAIL reports using Module::Build do not include tests output

[SAPER - Sun Jan 16 16:19:09 2005]: Show quoted text

> The FAIL reports sent by CPANPLUS 0.051 don't include the output of > "make test" or "Build test", whereas CPANPLUS 0.050_xx did. While > not being severe, this may be annoying to an author who receive > such reports because they he then don't have the opportunity to > immediatly know (for example) wihch test failed. > > For reference, here[1] is a FAIL report sent by CPANPLUS 0.050_xx and > here[2] is one sent by CPANPLUS 0.051. > > [1] http://www.nntp.perl.org/group/perl.cpan.testers/175706 > [2] http://www.nntp.perl.org/group/perl.cpan.testers/178985

Actually, this is not a difference between 0.050_04 and 0.051, but between using Module:: Build and using ExtUtils::MakeMaker; EU::MM's make test is run by shelling out and capturing the output, but M::B's build test is run by calling it's API. The build test call will die on test failure, but $@ only contains the summary line, rather than the entire output. This could be fixed in either T::H or in M::B, but M::B seems the logical choice in this case. Attached is a patch for M::B 0.2607 which will change this test report: http://www.nntp.perl.org/group/perl.cpan.testers/178257 into this test report: http://www.nntp.perl.org/group/perl.cpan.testers/179030 Moving this ticket over to the M::B queue, so they may address the issue

==== //depot/cpanplus/devel/lib/CPANPLUS/inc/installers/Module/Build/Base.pm#3 - /Users/kane/sources/p4/cpanplus/devel/lib/CPANPLUS/inc/installers/Module/Build/Base.pm ==== 1349c1349,1369 < Test::Harness::runtests(@$tests); --- > > # Test::Harness prints all it's diagnostics to STDOUT, then dies > # with a summary of the failure. In order to facilitate test reporting > # and better diagnostics, we'd like to capture the T::H output and add > # it to our die() message. > use IO::String; > local *STDOUT; > tie *STDOUT, 'IO::String'; > > eval { Test::Harness::runtests(@$tests) }; > > seek( STDOUT, 0, 0 ); > my $msg .= join "", <STDOUT>; > > # T::H would have done this already, but we caught it's output > print $msg; > > # now die with the full output, plus the error message, if there > # was an error > die $msg . $/ . $@ if $@; >

Mon Jan 17 03:02:31 2005 kane [...] cpan.org - Status changed from 'new' to 'open'

Mon Jan 17 03:03:21 2005 kane [...] cpan.org - Queue changed from CPANPLUS to Module-Build

Mon Jan 17 03:03:21 2005 kane [...] cpan.org - Subject changed from 'FAIL reports does not include tests output' to 'CPANPLUS FAIL reports using Module::Build do not include tests output'

Tue Feb 01 15:33:41 2005 SAPER [...] cpan.org - Correspondence added

I can't update the keywords of this ticket but I can confirm that this bug was present with Module::Build 0.2607 and is still present with Module::Build 0.2608.

Tue Jun 14 06:51:17 2005 leon [...] astray.com - Correspondence added

[KANE - Mon Jan 17 03:02:30 2005]: Show quoted text

> Moving this ticket over to the M::B queue, so they may address the > issue

Just to add my complaint to this "Unimportant item". This bug annoys me on a daily basic, because of CPAN Testers reports like the following: http://www.nntp.perl.org/group/perl.cpan.testers/215404 Please fix. Leon

Tue Jun 14 08:51:18 2005 kwilliams [...] cpan.org - Correspondence added

RT-Send-CC:

LBROCARD [...] cpan.org, KANE [...] cpan.org

I think that because this bug was moved into the M::B queue and didn't originate there, I never got an email about it. Sorry I didn't notice it in the queue. I'm not sure it's a great idea to have $@ contain the entire failure output. In general we try to have $@ contain just the text of an "exception" message. Other "informational" messages go to STDOUT or STDERR. Since CPANPLUS is the one that actually wants this output, it seems like it should be the one that collects it too. -Ken

Fri Jun 17 00:37:53 2005 kwilliams [...] cpan.org - Queue changed from Module-Build to CPANPLUS

Sat Jun 18 05:11:39 2005 kane [...] cpan.org - Correspondence added

[KWILLIAMS - Tue Jun 14 08:51:18 2005]: Show quoted text

> Since CPANPLUS is the one that actually wants this output, it seems > like it should be the one that collects it too.

Then please make it available through your API.

Sat Jun 18 05:59:48 2005 kane [...] cpan.org - Severity Unimportant changed to Important

Sat Jun 18 06:00:36 2005 kane [...] cpan.org - Queue changed from CPANPLUS to Module-Build

Sat Jun 18 06:02:29 2005 kane [...] cpan.org - Correspondence added

Ken, I didn't even notice you just moved the ticket back to the CPANPLUS queue. I'm not quite sure what you're thinking here, but this is in all intents and purposes a problem with Module::Build, and not CPANPLUS. So it would be kindly appreciated if, rather than ignoring a bug ticket for half a year, you'd actually take the time to fix the issue at hand. Please leave this ticket in your queue and attend to it, thanks.

Tue Mar 14 05:33:25 2006 mramberg [...] cpan.org - Correspondence added

Like Leo, I'm often bothered by this problem. Would be really nice if this patch got applied.

Tue Mar 14 05:43:41 2006 NUFFIN [...] cpan.org - Correspondence added

From:

NUFFIN [...] cpan.org

On Tue Mar 14 05:33:25 2006, MRAMBERG wrote: Show quoted text

> Like Leo, I'm often bothered by this problem. Would be really nice if > this patch got applied.

I suffer from this quite often too... There are other ways to fix it: make $@ an error object which stringifies to the terse message but also has the long message, or have a global accumilator that can be accessed after detecting the error.

Thu Mar 16 18:02:49 2006 kwilliams [...] cpan.org - Correspondence added

I definitely agree, this is an important issue. It's the first thing we're planning to work on after the 0.28 release. The 0.28 release itself will just be essentially the current beta release with enough bugs fixed to get tests passing in bleadperl. -Ken

Tue Aug 22 16:30:04 2006 cpan [...] desert-island.me.uk - Correspondence added

From:

JROBINSON [...] cpan.org

On Thu Mar 16 18:02:49 2006, KWILLIAMS wrote: Show quoted text

> I definitely agree, this is an important issue. It's the first thing > we're planning to work on after > the 0.28 release. The 0.28 release itself will just be essentially > the current beta release with > enough bugs fixed to get tests passing in bleadperl. > > -Ken

I'd like this fixed too! (Anyone know how to remove erroneous/useless tester reports ? ;)

Sun Sep 30 18:59:37 2007 EWILHELM [...] cpan.org - Correspondence added

Bug in CPANPLUS.

Sun Sep 30 18:59:38 2007 EWILHELM [...] cpan.org - Status changed from 'open' to 'rejected'

Sun Sep 30 19:35:03 2007 mschwern [...] cpan.org - Correspondence added

Reopening. We might not know who needs to fix what, but it's definitely a problem and shouldn't be rejected.

Sun Sep 30 19:35:04 2007 The RT System itself - Status changed from 'rejected' to 'open'

Sun Sep 30 20:19:10 2007 EWILHELM [...] cpan.org - Queue changed from Module-Build to CPANPLUS-Dist-Build

Tue Mar 03 17:33:01 2009 BINGOS [...] cpan.org - Correspondence added 2220 min

New releases now include process separation of Build.PL and Build actions with capturing. Cheers.

Tue Mar 03 17:33:02 2009 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Mar 03 17:33:03 2009 BINGOS [...] cpan.org - Given to BINGOS