Skip Menu |

This queue is for tickets about the LWP-UserAgent-Paranoid CPAN distribution.

Report information
The Basics
Id: 97906
Status: resolved
Priority: 0/
Queue: LWP-UserAgent-Paranoid
People
Owner: Nobody in particular
Requestors: RWSTAUNER [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sat Aug 09 13:19:17 2014 RWSTAUNER [...] cpan.org - Ticket created
Subject: Having resolver be read/write is useless and can lead to confusion
Looking at Oi's OpenID pull request I was going to suggest that she update the ua's resolver attribute and pass in a new Net::DNS::Paranoid with a new whitelist attribute... but when I tried that the tests failed. Since the UA calls make_paranoid in the construtor, if you later update the resolver attribute, the new one will never be used. So do you think it's reasonable to either make the attribute read-only (since you thankfully can update the attributes on the resolver itself) or to recall make_paranoid when the resolver is updated?
  Sat Aug 09 15:24:30 2014 tsibley [...] cpan.org - Status changed from 'new' to 'resolved'
  Sat Aug 09 15:24:38 2014 tsibley [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #97906] Having resolver be read/write is useless and can lead to confusion
Date: Sat, 09 Aug 2014 12:24:03 -0700
To: bug-LWP-UserAgent-Paranoid [...] rt.cpan.org
From: Thomas Sibley <tsibley [...] cpan.org>
On 08/09/2014 10:19 AM, Randy Stauner via RT wrote: Show quoted text
> Looking at Oi's OpenID pull request I was going to suggest that she > update the ua's resolver attribute and pass in a new > Net::DNS::Paranoid with a new whitelist attribute... but when I tried > that the tests failed. > > Since the UA calls make_paranoid in the construtor, if you later > update the resolver attribute, the new one will never be used. > > So do you think it's reasonable to either make the attribute > read-only (since you thankfully can update the attributes on the > resolver itself) or to recall make_paranoid when the resolver is > updated?
Nice catch! Thanks for the report. It's simpler just to make it read-only. Calling make_paranoid() again would require we cleanup the previously installed request handler on $self before installing the new one. I made the change and released as 0.96.