Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 97628
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: ishigaki [...] cpan.org
Requestors: NEILB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: v0.74
Fixed in: (no value)



Subject: Proposed new metric: distname in release filename doesn't match dist name in metadata
Hi Ishigaki-san, What do you think about a new metric which checks whether the distname in the file name matches the distname given in the dist's metadata? Ie if the distname returned by CPAN::DistnameInfo($release_path)->dist ne metadata->{name} Lots of tools use CPAN::DistnameInfo to get the dist name for a release, but in some situations the path might not be easily available. In some cases I've used the MetaCPAN API to get the dist's dist name, but in some cases they don't match. I'm slowly working through those, raising bugs, but it would be good to have a check for that! Cheers, Neil
On 2014-07-30 11:30:41, NEILB wrote: Show quoted text
> Hi Ishigaki-san, > > What do you think about a new metric which checks whether the distname > in the file name matches the distname given in the dist's metadata?
+1
Implemented in the master, and started regenerating CPANTS databases. Confirmed ~1% of minicpan failed. Let's see what happens for the whole CPAN/BackPAN. Thanks! https://github.com/cpants/Module-CPANTS-SiteKwalitee/commit/7f9102563611df98240d1ae366930cdc8723664e On Thu Jul 31 03:30:41 2014, NEILB wrote: Show quoted text
> Hi Ishigaki-san, > > What do you think about a new metric which checks whether the distname > in the file name matches the distname given in the dist's metadata? > > Ie if the distname returned by CPAN::DistnameInfo($release_path)->dist > ne metadata->{name} > > Lots of tools use CPAN::DistnameInfo to get the dist name for a > release, but in some situations the path might not be easily > available. In some cases I've used the MetaCPAN API to get the dist's > dist name, but in some cases they don't match. I'm slowly working > through those, raising bugs, but it would be good to have a check for > that! > > Cheers, > Neil
素晴らしい!
Done and ready. Thanks. http://cpants.cpanauthors.org/kwalitee/distname_matches_name_in_meta On Thu Jul 31 12:36:26 2014, ISHIGAKI wrote: Show quoted text
> Implemented in the master, and started regenerating CPANTS databases. > Confirmed ~1% of minicpan failed. Let's see what happens for the whole > CPAN/BackPAN. Thanks! > > https://github.com/cpants/Module-CPANTS- > SiteKwalitee/commit/7f9102563611df98240d1ae366930cdc8723664e > > On Thu Jul 31 03:30:41 2014, NEILB wrote:
> > Hi Ishigaki-san, > > > > What do you think about a new metric which checks whether the > > distname > > in the file name matches the distname given in the dist's metadata? > > > > Ie if the distname returned by CPAN::DistnameInfo($release_path)-
> > >dist
> > ne metadata->{name} > > > > Lots of tools use CPAN::DistnameInfo to get the dist name for a > > release, but in some situations the path might not be easily > > available. In some cases I've used the MetaCPAN API to get the dist's > > dist name, but in some cases they don't match. I'm slowly working > > through those, raising bugs, but it would be good to have a check for > > that! > > > > Cheers, > > Neil