Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla-Plugin-Test-ReportPrereqs CPAN distribution.

Report information
The Basics
Id: 97616
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-Test-ReportPrereqs

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Useless test-dependency on File::Spec
META.json lists File::Spec in prereqs test requires. However the module is used only xt/author/00-compile.t. Thus I think the dependency is not needed and should be removed from this meta-data section.
On 2014-07-30 01:29:07, ppisar wrote: Show quoted text
> META.json lists File::Spec in prereqs test requires. However the > module is used only xt/author/00-compile.t. Thus I think the > dependency is not needed and should be removed from this meta-data > section.
File::Spec::Functions is used by t/00-report-prereqs.t, and it's a core library, so at least nothing new is getting installed, but this seems to be via [Test::Compile], so I'll look into it there.
On 2014-07-30 01:29:07, ppisar wrote: Show quoted text
> META.json lists File::Spec in prereqs test requires. However the > module is used only xt/author/00-compile.t. Thus I think the > dependency is not needed and should be removed from this meta-data > section.
It's not [Test::Compile]: https://github.com/karenetheridge/Dist-Zilla-Plugin-Test-Compile/commit/c56575f2406be9dd67fa85e20a1893d3edf3f4af I'm closing this ticket, but I will keep an eye out for which plugin is causing it (and when I have tuits will dig deeper).
On 2014-07-30 07:44:41, ETHER wrote: Show quoted text
> On 2014-07-30 01:29:07, ppisar wrote:
> > META.json lists File::Spec in prereqs test requires. However the > > module is used only xt/author/00-compile.t. Thus I think the > > dependency is not needed and should be removed from this meta-data > > section.
> > It's not [Test::Compile]: https://github.com/karenetheridge/Dist- > Zilla-Plugin-Test- > Compile/commit/c56575f2406be9dd67fa85e20a1893d3edf3f4af > > I'm closing this ticket, but I will keep an eye out for which plugin > is causing it (and when I have tuits will dig deeper).
Looks like it is [Test::ReportPrereqs]: ### registering prereqs for test, requires: $VAR1 = { 'Scalar::Util' => 0, 'List::Util' => 0, 'File::Spec' => 0, 'ExtUtils::MakeMaker' => 0, 'Test::More' => 0 }; at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/Dist/Zilla/Prereqs.pm line 90. Dist::Zilla::Prereqs::register_prereqs(Dist::Zilla::Prereqs=HASH(0x103377480), HASH(0x107a8b910), "Test::More", 0, "ExtUtils::MakeMaker", 0, "File::Spec", 0, "List::Util", ...) called at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/darwin-2level/Moose/Meta/Method/Delegation.pm line 112 Dist::Zilla::register_prereqs(Dist::Zilla::Dist::Builder=HASH(0x10348e500), HASH(0x107a8b910), "Test::More", 0, "ExtUtils::MakeMaker", 0, "File::Spec", 0, "List::Util", ...) called at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/Dist/Zilla/Plugin/Test/ReportPrereqs.pm line 43 Dist::Zilla::Plugin::Test::ReportPrereqs::register_prereqs(Dist::Zilla::Plugin::Test::ReportPrereqs=HASH(0x10637fa58)) called at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/Dist/Zilla/Dist/Builder.pm line 329 Dist::Zilla::Dist::Builder::build_in(Dist::Zilla::Dist::Builder=HASH(0x10348e500)) called at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/Dist/Zilla/Dist/Builder.pm line 306 Dist::Zilla::Dist::Builder::build(Dist::Zilla::Dist::Builder=HASH(0x10348e500)) called at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/Dist/Zilla/App/Command/build.pm line 66 Dist::Zilla::App::Command::build::execute(Dist::Zilla::App::Command::build=HASH(0x102b831a8), Getopt::Long::Descriptive::Opts::__OPT__::2=HASH(0x102c72d60), ARRAY(0x100bd95e0)) called at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/App/Cmd.pm line 282 App::Cmd::execute_command(Dist::Zilla::App=HASH(0x100fee548), Dist::Zilla::App::Command::build=HASH(0x102b831a8), Getopt::Long::Descriptive::Opts::__OPT__::2=HASH(0x102c72d60)) called at /Users/ether/.perlbrew/libs/21.1@std/lib/perl5/App/Cmd.pm line 210 App::Cmd::run("Dist::Zilla::App") called at /Users/ether/.perlbrew/libs/21.1@std/bin/dzil line 15 xdg: could you s/File::Spec/File::Spec::Functions/ in the 'register_prereqs' call?
Shipped new [Test::ReportPrereqs] that uses File::Spec instead of File::Spec::Functions for clarity.