Bug #97601 for Module-CPANTS-Analyse: Test::Kwalitee incorrectly reports non-use of strict in Inline::CPP

Tue Jul 29 14:03:21 2014 davido [...] cpan.org - Ticket created

Subject:

Test::Kwalitee incorrectly reports non-use of strict in Inline::CPP

After downloading and unpacking the tarball for Inline::CPP, and then setting RELEASE_TESTING=1, running "make test" will cause Test::Kwalitee to incorrectly report that lib/Inline/CPP.pm is not using strict. This became an issue when Inline::CPP restructured its file hierarchy moving CPP.pm from top level into lib/. Oddly, make disttest results in a PASS; the test doesn't incorrectly fail in this case. So, steps to reproduce: Grab Inline::CPP and unpack the tarball. cd into distribution directory. export RELEASE_TESTING=1 perl Makefile.PL && make && make test Steps to have a clean run (ie, problem not detected): make disttest

Tue Jul 29 14:12:05 2014 ether [...] cpan.org - Queue changed from Test-Kwalitee to Module-CPANTS-Analyse

Tue Jul 29 14:12:23 2014 ether [...] cpan.org - Correspondence added

On 2014-07-29 11:03:21, DAVIDO wrote: Show quoted text

> After downloading and unpacking the tarball for Inline::CPP, and then > setting RELEASE_TESTING=1, running "make test" will cause > Test::Kwalitee to incorrectly report that lib/Inline/CPP.pm is not > using strict.

This is a Module::CPANTS::Analyse problem; redirecting.

Tue Jul 29 14:12:23 2014 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 29 14:13:00 2014 ether [...] cpan.org - Cc ETHER added

Tue Jul 29 14:25:01 2014 ishigaki [...] cpan.org - Correspondence added

Hi, could you first tell us 1) the version of Module::CPANTS::Analyse, 2) the version of Module::ExtractUse, 3) the version of Test::Kwalitee, 4) and the version of Inline::CPP (repository or CPAN) ? As far as CPANTS website can tell, it should pass the test if everything is up-to-date. See also http://cpants.cpanauthors.org/dist/Inline-CPP On Wed Jul 30 03:03:21 2014, DAVIDO wrote: Show quoted text

> After downloading and unpacking the tarball for Inline::CPP, and then > setting RELEASE_TESTING=1, running "make test" will cause > Test::Kwalitee to incorrectly report that lib/Inline/CPP.pm is not > using strict. > > This became an issue when Inline::CPP restructured its file hierarchy > moving CPP.pm from top level into lib/. > > Oddly, make disttest results in a PASS; the test doesn't incorrectly > fail in this case. > > So, steps to reproduce: > > Grab Inline::CPP and unpack the tarball. > cd into distribution directory. > export RELEASE_TESTING=1 > perl Makefile.PL && make && make test > > Steps to have a clean run (ie, problem not detected): > > make disttest

Tue Jul 29 18:38:04 2014 davido [...] cpan.org - Correspondence added

On Tue Jul 29 11:25:01 2014, ISHIGAKI wrote: Show quoted text

> Hi, could you first tell us 1) the version of Module::CPANTS::Analyse, > 2) the version of Module::ExtractUse, 3) the version of > Test::Kwalitee, 4) and the version of Inline::CPP (repository or CPAN)

I guess I'm going to have to withdraw the report. As mysteriously as it appeared, it has heisen-disappeared. The change that triggered its appearance was moving CPP.pm from the base project directory into lib/Inline/CPP.pm. This coincided with Inline::CPP v0.51. By 0.52 it disappeared, with no (seemingly) significant change to CPP.pm that could account for the disappearance. I would love to be able to reproduce it for you, because I feel that the alignment of the celestial bodies that brought it on is probably triggering undesirable behavior (certainly at no point was 'use strict;' ever excluded from CPP.pm, and aside from Test::Kwalitee, all other distribution tests were passing.) But alas, I've stopped being able to produce it. To answer your questions, however: Inline::CPP v0.51 Module::CPANTS::Analyse v0.92 Module::ExtractUse v0.33 Test::Kwalitee v1.19 Perl version: 5.20.0 (Perlbrew). Inline v0.64. Inline::C v0.62

Tue Jul 29 23:12:49 2014 ishigaki [...] cpan.org - Correspondence added

Thanks. Most probably the error happened because of (temporal) inconsistency of "provides" field in META files. I fetched Inline-CPP-0.51.tar.gz and modified the META files and let "CPP.pm" point to non-existent file, and confirmed the error was reproduced. Fixed in the master. https://github.com/cpants/Module-CPANTS-Analyse/commit/10a1b6e556da78971c5679555fbde58d5132580c On Wed Jul 30 07:38:04 2014, DAVIDO wrote: Show quoted text

> On Tue Jul 29 11:25:01 2014, ISHIGAKI wrote:

> > Hi, could you first tell us 1) the version of > > Module::CPANTS::Analyse, > > 2) the version of Module::ExtractUse, 3) the version of > > Test::Kwalitee, 4) and the version of Inline::CPP (repository or > > CPAN)

> > I guess I'm going to have to withdraw the report. As mysteriously as > it appeared, it has heisen-disappeared. > > The change that triggered its appearance was moving CPP.pm from the > base project directory into lib/Inline/CPP.pm. This coincided with > Inline::CPP v0.51. By 0.52 it disappeared, with no (seemingly) > significant change to CPP.pm that could account for the disappearance. > > I would love to be able to reproduce it for you, because I feel that > the alignment of the celestial bodies that brought it on is probably > triggering undesirable behavior (certainly at no point was 'use > strict;' ever excluded from CPP.pm, and aside from Test::Kwalitee, all > other distribution tests were passing.) > > But alas, I've stopped being able to produce it. > > To answer your questions, however: > > Inline::CPP v0.51 > Module::CPANTS::Analyse v0.92 > Module::ExtractUse v0.33 > Test::Kwalitee v1.19 > Perl version: 5.20.0 (Perlbrew). > Inline v0.64. > Inline::C v0.62

Tue Jul 29 23:12:50 2014 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Fri Sep 26 04:42:34 2014 ishigaki [...] cpan.org - Correspondence added

On Wed Jul 30 12:12:49 2014, ISHIGAKI wrote: Show quoted text

> Thanks. Most probably the error happened because of (temporal) > inconsistency of "provides" field in META files. I fetched Inline-CPP- > 0.51.tar.gz and modified the META files and let "CPP.pm" point to non- > existent file, and confirmed the error was reproduced. Fixed in the > master. > > https://github.com/cpants/Module-CPANTS- > Analyse/commit/10a1b6e556da78971c5679555fbde58d5132580c > > > On Wed Jul 30 07:38:04 2014, DAVIDO wrote:

> > On Tue Jul 29 11:25:01 2014, ISHIGAKI wrote:

> > > Hi, could you first tell us 1) the version of > > > Module::CPANTS::Analyse, > > > 2) the version of Module::ExtractUse, 3) the version of > > > Test::Kwalitee, 4) and the version of Inline::CPP (repository or > > > CPAN)

> > > > I guess I'm going to have to withdraw the report. As mysteriously as > > it appeared, it has heisen-disappeared. > > > > The change that triggered its appearance was moving CPP.pm from the > > base project directory into lib/Inline/CPP.pm. This coincided with > > Inline::CPP v0.51. By 0.52 it disappeared, with no (seemingly) > > significant change to CPP.pm that could account for the > > disappearance. > > > > I would love to be able to reproduce it for you, because I feel that > > the alignment of the celestial bodies that brought it on is probably > > triggering undesirable behavior (certainly at no point was 'use > > strict;' ever excluded from CPP.pm, and aside from Test::Kwalitee, > > all > > other distribution tests were passing.) > > > > But alas, I've stopped being able to produce it. > > > > To answer your questions, however: > > > > Inline::CPP v0.51 > > Module::CPANTS::Analyse v0.92 > > Module::ExtractUse v0.33 > > Test::Kwalitee v1.19 > > Perl version: 5.20.0 (Perlbrew). > > Inline v0.64. > > Inline::C v0.62

Closed as 0.94 is released. Thanks.

Fri Sep 26 04:42:35 2014 ishigaki [...] cpan.org - Status changed from 'patched' to 'resolved'