Skip Menu |

This queue is for tickets about the Benchmark-Chart CPAN distribution.

Report information
The Basics
Id: 97580
Status: new
Priority: 0/
Queue: Benchmark-Chart
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
KENTNL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.01
Fixed in: (no value)

History Show all quoted text
  Tue Jul 29 00:58:23 2014 ANDK [...] cpan.org - Ticket created
Subject: fails under 5.19+ because of fatal warnings and experimental feature
As per subject. Sample fail report: http://www.cpantesters.org/cpan/report/2ac0717c-16bc-11e4-8c40-c1af0a370852 Similar RT tickets: https://rt.perl.org/Public/Bug/Display.html?id=121371 HTH&&Thanks,
  Mon Sep 15 10:38:08 2014 KENTNL [...] cpan.org - Requestor KENTNL added
  Mon Sep 15 10:40:55 2014 KENTNL [...] cpan.org - Correspondence added

Its a reasonably simple thing to fix for compatibility with older and newer versions:

 

 

Subject: keys_legacy.patch
--- lib/Benchmark/Chart.pm.old 2014-09-16 02:38:35.197396353 +1200 +++ lib/Benchmark/Chart.pm 2014-09-16 02:39:13.400263893 +1200 @@ -155,7 +155,7 @@ my $max = 0; my @y; - for my $key ( keys $b ) { + for my $key ( keys %{$b} ) { $cases{$key}->{$name} = $self->_calculateRate( benchmark => $b->{$key} ); if ( $cases{$key}->{$name} > $max ) { $max = $cases{$key}->{$name}; @@ -163,7 +163,7 @@ } if ( $self->{uniform} && $max > 0) { - for my $key ( keys $b ) { + for my $key ( keys %{$b} ) { $cases{$key}->{$name} = $cases{$key}->{$name} / $max * 100; } }