Skip Menu |

This queue is for tickets about the UNIVERSAL-isa CPAN distribution.

Report information
The Basics
Id: 97468
Status: open
Priority: 0/
Queue: UNIVERSAL-isa
People
Owner: Nobody in particular
Requestors: mst [...] shadowcat.co.uk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.20140927

History Show all quoted text
  Thu Jul 24 15:37:31 2014 mst [...] shadowcat.co.uk - Ticket created
CC: exodist [...] cpan.org
Subject: Verbose warnings causes false positives
Date: Thu, 24 Jul 2014 19:37:20 +0000
To: bugs-UNIVERSAL-isa [...] rt.cpan.org
From: Matt S Trout <mst [...] shadowcat.co.uk>
Adding a ninth entry to t/warnings.t of - $warning = ''; $bar->isa('Bar'); is( $warning, '', 'No warning on actual method call' ); reveals that we *do* still warn on an actual method call. This produces fun failures like http://www.cpantesters.org/cpan/report/3ee883b4-10fa-11e4-97f6-9b514fc05230 because newer Test::Builder versions now actually use ->isa to check the types of things internally. -- Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ Email me now on mst (at) shadowcat.co.uk and let's chat about how our CPAN commercial support, training and consultancy packages could help your team.
  Thu Jul 24 15:48:31 2014 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #97468] Verbose warnings causes false positives
Date: Thu, 24 Jul 2014 12:48:12 -0700
To: Matt S Trout via RT <bug-UNIVERSAL-isa [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
And when in verbose mode, the warning message isn't even correct. It should simply be "UNIVERSAL::isa called as method on <invocant>", so the developer won't think he's going crazy by triggering an impossible situation.
  Thu Jul 24 15:48:32 2014 The RT System itself - Status changed from 'new' to 'open'
  Thu Jul 24 15:57:28 2014 mst [...] shadowcat.co.uk - Correspondence added
Subject: Re: [rt.cpan.org #97468] Verbose warnings causes false positives
Date: Thu, 24 Jul 2014 19:57:17 +0000
To: Karen Etheridge via RT <bug-UNIVERSAL-isa [...] rt.cpan.org>
From: Matt S Trout <mst [...] shadowcat.co.uk>
On Thu, Jul 24, 2014 at 03:48:32PM -0400, Karen Etheridge via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=97468 > > > > And when in verbose mode, the warning message isn't even correct. It should > simply be "UNIVERSAL::isa called as method on <invocant>", so the developer > won't think he's going crazy by triggering an impossible situation.
Um, no. That case shouldn't even warn at all. -- Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ Email me now on mst (at) shadowcat.co.uk and let's chat about how our CPAN commercial support, training and consultancy packages could help your team.
  Thu Jul 24 16:32:41 2014 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #97468] Verbose warnings causes false positives
Date: Thu, 24 Jul 2014 13:32:33 -0700
To: Matt S Trout via RT <bug-UNIVERSAL-isa [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Thu, Jul 24, 2014 at 03:57:29PM -0400, Matt S Trout via RT wrote: Show quoted text
> > And when in verbose mode, the warning message isn't even correct. It should > > simply be "UNIVERSAL::isa called as method on <invocant>", so the developer > > won't think he's going crazy by triggering an impossible situation.
> > Um, no. That case shouldn't even warn at all.
Ah, I see, I misunderstood what the verbose mode did -- I was thinking it warned about *all calls to isa*, regardless of the invocant -- in which case the warning that we were hitting in Test::More was actually correct.
  Sat Aug 23 22:39:12 2014 ether [...] cpan.org - Correspondence added
In the absence of some sort of XS or B:: magic that I'm not aware of, there is no way to disambiguate between: UNIVERSAL::isa($obj, 'something'); and $obj->isa('something') from within UNIVERSAL::isa. *All* calls to isa during verbose mode will warn. Consequently, I think the best we can do is hack the tests so they don't fail when Test::Builder calls isa() during its own tests.
  Sun Aug 24 01:28:39 2014 ether [...] cpan.org - Taken
  Sun Aug 24 01:31:49 2014 ether [...] cpan.org - Correspondence added
RT-Send-CC: exodist [...] cpan.org
UNIVERSAL-isa-1.20140824 is released.
  Sun Aug 24 01:31:51 2014 ether [...] cpan.org - Status changed from 'open' to 'resolved'
  Sun Aug 24 01:55:10 2014 ether [...] cpan.org - Correspondence added
Oops, this shouldn't be closed. The problem still persists. The only thing solved by the last release is the failing tests in the presence of newer Test::Builder.
  Sun Aug 24 01:55:11 2014 ether [...] cpan.org - Status changed from 'resolved' to 'open'
  Sun Aug 24 01:55:12 2014 ether [...] cpan.org - Untaken
  Sun Jun 14 19:15:28 2015 ether [...] cpan.org - Correspondence added
On 2014-08-23 22:55:10, ETHER wrote: Show quoted text
> Oops, this shouldn't be closed. The problem still persists. > > The only thing solved by the last release is the failing tests in the > presence of newer Test::Builder.
The bug, as originally described in the first message, has been fixed. Resolving.
  Sun Jun 14 19:15:32 2015 ether [...] cpan.org - Fixed in 1.20140927 added