Skip Menu |

This queue is for tickets about the CPAN-Changes CPAN distribution.

Report information
The Basics
Id: 97377
Status: resolved
Priority: 0/
Queue: CPAN-Changes
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jul 21 11:42:42 2014 ether [...] cpan.org - Ticket created
Subject: Parsing of group headings is not strict enough
The spec suggests that group headers must only have leading whitespace, and nothing else in front. And yet... https://metacpan.org/release/ETHER/Dist-Zilla-PluginBundle-Author-ETHER-0.065 https://github.com/CPAN-API/metacpan-web/issues/1252
  Mon Jul 21 13:57:02 2014 bricas [...] cpan.org - Correspondence added
On Mon Jul 21 12:42:42 2014, ETHER wrote: Show quoted text
> The spec suggests that group headers must only have leading > whitespace, and nothing else in front. And yet... > > https://metacpan.org/release/ETHER/Dist-Zilla-PluginBundle-Author- > ETHER-0.065 > https://github.com/CPAN-API/metacpan-web/issues/1252
Interesting. It appears that this is the offending line: [ModuleBuildTiny::Fallback], [MakeMaker::Fallback] And, well, it does only have whitespace before the square bracket, hence the start of a new group. How would you expect it to behave differently? Cheers, -Brian
  Mon Jul 21 13:57:02 2014 The RT System itself - Status changed from 'new' to 'open'
  Tue Jul 22 15:17:52 2014 ether [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #97377] Parsing of group headings is not strict enough
Date: Tue, 22 Jul 2014 12:17:42 -0700
To: Brian Cassidy via RT <bug-CPAN-Changes [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Mon, Jul 21, 2014 at 01:57:02PM -0400, Brian Cassidy via RT wrote: Show quoted text
> Interesting. It appears that this is the offending line: > > [ModuleBuildTiny::Fallback], [MakeMaker::Fallback] > > And, well, it does only have whitespace before the square bracket, hence the start of a new group. > > How would you expect it to behave differently?
It comes as a surprise to me that a new group can start on a line following a non-blank line -- that is, not prefaced with \n\n. I would have thought that non-blank lines following another blank line belong with that previous line (paragraph folding) -- or at least just the start of a new bullet point (if starting with "-" or other acceptable bullet characters).
  Mon May 18 22:01:40 2015 haarg [...] haarg.org - Correspondence added
I think the sensible thing is to forbid the [ and ] characters in group names. I'm planning on making that change for the next release.
  Mon May 18 22:01:43 2015 haarg [...] haarg.org - Status changed from 'open' to 'patched'
  Sat May 23 03:26:30 2015 haarg [...] haarg.org - Correspondence added
Fixed in 0.400001
  Sat May 23 03:26:37 2015 haarg [...] haarg.org - Status changed from 'patched' to 'resolved'