Bug #97372 for Net-DNS: Fwd: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures

Mon Jul 21 08:06:00 2014 ondrej [...] sury.org - Ticket created

Subject:	Fwd: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures
Date:	Mon, 21 Jul 2014 14:05:42 +0200
To:	bug-Net-DNS [...] rt.cpan.org
From:	Ondřej Surý <ondrej [...] sury.org>

-- Ondřej Surý <ondrej@sury.org> Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server Show quoted text

----- Original message ----- From: gregor herrmann <gregoa@debian.org> To: 755317@bugs.debian.org Cc: Ondřej Surý <ondrej@debian.org> Subject: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures Date: Sun, 20 Jul 2014 14:39:02 +0200 Control: tag -1 + confirmed On Sat, 19 Jul 2014 20:44:36 +0200, David Suárez wrote:

> Source: libnet-bonjour-perl > Version: 0.96-1 > Severity: serious > Tags: jessie sid > User: debian-qa@lists.debian.org > Usertags: qa-ftbfs-20140718 qa-ftbfs > Justification: FTBFS on amd64 > > Hi, > > During a rebuild of all packages in sid, your package failed to build on > amd64. > > Relevant part (hopefully):

> > make[1]: Entering directory '/«PKGBUILDDIR»' > > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > > t/1-use.t ......... ok > > Use of uninitialized value in uc at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 272. > > Use of uninitialized value $_[4] in join or string at /usr/lib/perl5/Net/DNS/RR.pm line 69. > > Use of uninitialized value $argument in concatenation (.) or string at /usr/lib/perl5/Net/DNS/RR/AAAA.pm line 75. > > in new Net::DNS::RR( type AAAA ttl 3600 address name server.local ... ) at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 327. > > # Looks like you planned 18 tests but ran 15. > > # Looks like your test exited with 255 just after 15. > > t/2-entry.t ....... > > Dubious, test returned 255 (wstat 65280, 0xff00) > > Failed 3/18 subtests

Breakage by recent Net::DNS? Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Wir sind Helden: Der Krieg kommt schneller zurück als du denkst

Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

Mon Jul 21 09:51:04 2014 willem [...] nlnetlabs.nl - Correspondence added

Subject:	Re: [rt.cpan.org #97372] Fwd: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures
Date:	Mon, 21 Jul 2014 09:50:47 -0400
To:	bug-Net-DNS [...] rt.cpan.org, 755317 [...] bugs.debian.org
From:	Willem Toorop <willem [...] nlnetlabs.nl>

Show quoted text

> From: gregor herrmann <gregoa@debian.org> To: 755317@bugs.debian.org Cc: Ondřej Surý <ondrej@debian.org> Subject: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures Date: Sun, 20 Jul 2014 14:39:02 +0200 Control: tag -1 + confirmed On Sat, 19 Jul 2014 20:44:36 +0200, David Suárez wrote:

>> Source: libnet-bonjour-perl >> Version: 0.96-1 >> Severity: serious >> Tags: jessie sid >> User: debian-qa@lists.debian.org >> Usertags: qa-ftbfs-20140718 qa-ftbfs >> Justification: FTBFS on amd64 >> >> Hi, >> >> During a rebuild of all packages in sid, your package failed to build on >> amd64. >> >> Relevant part (hopefully):

>>> make[1]: Entering directory '/«PKGBUILDDIR»' >>> PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t >>> t/1-use.t ......... ok >>> Use of uninitialized value in uc at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 272. >>> Use of uninitialized value $_[4] in join or string at /usr/lib/perl5/Net/DNS/RR.pm line 69. >>> Use of uninitialized value $argument in concatenation (.) or string at /usr/lib/perl5/Net/DNS/RR/AAAA.pm line 75. >>> in new Net::DNS::RR( type AAAA ttl 3600 address name server.local ... ) at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 327. >>> # Looks like you planned 18 tests but ran 15. >>> # Looks like your test exited with 255 just after 15. >>> t/2-entry.t ....... >>> Dubious, test returned 255 (wstat 65280, 0xff00) >>> Failed 3/18 subtests

> > Breakage by recent Net::DNS?

Yes, but caused by wrong usage (initializing address with undef value) by Net::Bonjour. Here is a patch: --- lib/Net/Bonjour/Entry.pm.orig 2014-07-21 09:43:40.378946335 -0400 +++ lib/Net/Bonjour/Entry.pm 2014-07-21 09:44:39.011734092 -0400 @@ -324,6 +324,8 @@ foreach my $type (qw(A AAAA)) { + next unless $self->{'_' . $type}; + my $rr = Net::DNS::RR->new( 'type' => $type, 'ttl' => $self->ttl, @@ -331,7 +333,7 @@ 'name' => $self->hostname ); - push(@addrs, $rr) if $self->{'_' . $type}; + push(@addrs, $rr); } $packet->push('additional', @addrs); However since Net::DNS 0.75 also test 7 of Net::Bonjour's t/4-enterprise.ot fails. Still looking into that... Cheers, -- Willem

Mon Jul 21 09:51:04 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 28 10:49:05 2014 rwfranks [...] acm.org - Correspondence added

From:

rwfranks [...] acm.org

On Mon Jul 21 08:06:00 2014, ondrej@sury.org wrote: Show quoted text

> >

Show quoted text

> > Use of uninitialized value in uc at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 272.

First warning occurs in *your* code, not Net::DNS. Show quoted text

> > Use of uninitialized value $_[4] in join or string at /usr/lib/perl5/Net/DNS/RR.pm line 69.

But, I am happy to claim the blame for this error in constructing the error message. Show quoted text

> > Use of uninitialized value $argument in concatenation (.) or string at /usr/lib/perl5/Net/DNS/RR/AAAA.pm line 75.

Warning raised in AAAA.pm (but only if perl -w flag is set). This is inconsistent with A.pm, which silently ignores the problem. In short-term, AAAA.pm should do the same. I am not entirely convinced that this is the right thing to do long-term. Show quoted text

> > in new Net::DNS::RR( type AAAA ttl 3600 address undef name server.local ... )

at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 327. Location of error is correctly identified.

Tue Jul 29 08:19:44 2014 NLNETLABS [...] cpan.org - Correspondence added

On Mon 21 Jul 2014 09:51:04, wimpie wrote: Show quoted text

> However since Net::DNS 0.75 also test 7 of Net::Bonjour's > t/4-enterprise.ot fails. Still looking into that...

Nothing to do with Net::DNS version. Test 4 fails because exampleprinter.dns-sd.org. A doesn't exist any more.

Tue Jul 29 08:37:58 2014 NLNETLABS [...] cpan.org - Correspondence added

We have a ticket in the Net::Bonjour queue too, so safe to reject here. However, the last release of Net::Bonjour is 2009. Maybe the author's unresponsiveness is because of change of jobs/different e-mail address etc. Maybe someone should try to connect with him.

Tue Jul 29 08:37:59 2014 NLNETLABS [...] cpan.org - Status changed from 'open' to 'rejected'

Sun Sep 07 07:42:43 2014 gregoa [...] cpan.org - Cc GREGOA added

Fri Oct 24 10:51:23 2014 gregoa [...] debian.org - Correspondence added

CC:	bug-Net-DNS [...] rt.cpan.org, Ondřej Surý <ondrej [...] debian.org>
Subject:	Re: Bug#755317: [rt.cpan.org #97372] Fwd: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures
Date:	Fri, 24 Oct 2014 16:50:50 +0200
To:	Willem Toorop <willem [...] nlnetlabs.nl>, 755317 [...] bugs.debian.org
From:	gregor herrmann <gregoa [...] debian.org>

Control: tag -1 - confirmed + unreproducible patch upstream Control: severity -1 normal On Mon, 21 Jul 2014 09:50:47 -0400, Willem Toorop wrote: Show quoted text

> >> Relevant part (hopefully):

> >>> make[1]: Entering directory '/«PKGBUILDDIR»' > >>> PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > >>> t/1-use.t ......... ok > >>> Use of uninitialized value in uc at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 272. > >>> Use of uninitialized value $_[4] in join or string at /usr/lib/perl5/Net/DNS/RR.pm line 69. > >>> Use of uninitialized value $argument in concatenation (.) or string at /usr/lib/perl5/Net/DNS/RR/AAAA.pm line 75. > >>> in new Net::DNS::RR( type AAAA ttl 3600 address name server.local ... ) at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 327. > >>> # Looks like you planned 18 tests but ran 15. > >>> # Looks like your test exited with 255 just after 15. > >>> t/2-entry.t ....... > >>> Dubious, test returned 255 (wstat 65280, 0xff00) > >>> Failed 3/18 subtests

> > > > Breakage by recent Net::DNS?

> > Yes, but caused by wrong usage (initializing address with undef value) > by Net::Bonjour. Here is a patch:

[..] Show quoted text

> However since Net::DNS 0.75 also test 7 of Net::Bonjour's > t/4-enterprise.ot fails. Still looking into that...

Interestingly, it builds again now: dh_auto_test make[1]: Entering directory '/tmp/buildd/libnet-bonjour-perl-0.96' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1-use.t ......... ok Use of uninitialized value in uc at /tmp/buildd/libnet-bonjour-perl-0.96/blib/lib/Net/Bonjour/Entry.pm line 272. t/2-entry.t ....... ok Use of uninitialized value in uc at /tmp/buildd/libnet-bonjour-perl-0.96/blib/lib/Net/Bonjour/Entry.pm line 272. t/3-rendezvous.t .. ok All tests successful. Files=3, Tests=37, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.20 cusr 0.01 csys = 0.24 CPU) Result: PASS This is with libnet-dns-perl 0.80.2. (And t/4-enterprise._o_t is not run.) Lowering the severity ... Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Rolling Stones: Thruandthru

Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

Fri Oct 24 10:57:19 2014 ondrej [...] sury.org - Correspondence added

CC:	gregoa [...] cpan.org
Subject:	Re: Bug#755317: [rt.cpan.org #97372] Fwd: Re: Bug#755317: libnet-bonjour-perl: FTBFS: Tests failures
Date:	Fri, 24 Oct 2014 16:57:06 +0200
To:	gregor herrmann via RT <bug-Net-DNS [...] rt.cpan.org>
From:	Ondřej Surý <ondrej [...] sury.org>

I saw some fixes in 0.81 pre-release (marked as 0.80_2), so I went and uploaded it, so we have those in jessie. Glad it helped. O. On Fri, Oct 24, 2014, at 16:51, gregor herrmann via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=97372 > > > Control: tag -1 - confirmed + unreproducible patch upstream > Control: severity -1 normal > > On Mon, 21 Jul 2014 09:50:47 -0400, Willem Toorop wrote: >

> > >> Relevant part (hopefully):

> > >>> make[1]: Entering directory '/«PKGBUILDDIR»' > > >>> PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > > >>> t/1-use.t ......... ok > > >>> Use of uninitialized value in uc at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 272. > > >>> Use of uninitialized value $_[4] in join or string at /usr/lib/perl5/Net/DNS/RR.pm line 69. > > >>> Use of uninitialized value $argument in concatenation (.) or string at /usr/lib/perl5/Net/DNS/RR/AAAA.pm line 75. > > >>> in new Net::DNS::RR( type AAAA ttl 3600 address name server.local ... ) at /«PKGBUILDDIR»/blib/lib/Net/Bonjour/Entry.pm line 327. > > >>> # Looks like you planned 18 tests but ran 15. > > >>> # Looks like your test exited with 255 just after 15. > > >>> t/2-entry.t ....... > > >>> Dubious, test returned 255 (wstat 65280, 0xff00) > > >>> Failed 3/18 subtests

> > > > > > Breakage by recent Net::DNS?

> > > > Yes, but caused by wrong usage (initializing address with undef value) > > by Net::Bonjour. Here is a patch:

> [..]

> > However since Net::DNS 0.75 also test 7 of Net::Bonjour's > > t/4-enterprise.ot fails. Still looking into that...

> > Interestingly, it builds again now: > > dh_auto_test > make[1]: Entering directory '/tmp/buildd/libnet-bonjour-perl-0.96' > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" > "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, > 'blib/lib', 'blib/arch')" t/*.t > t/1-use.t ......... ok > Use of uninitialized value in uc at > /tmp/buildd/libnet-bonjour-perl-0.96/blib/lib/Net/Bonjour/Entry.pm line > 272. > t/2-entry.t ....... ok > Use of uninitialized value in uc at > /tmp/buildd/libnet-bonjour-perl-0.96/blib/lib/Net/Bonjour/Entry.pm line > 272. > t/3-rendezvous.t .. ok > All tests successful. > Files=3, Tests=37, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.20 cusr > 0.01 csys = 0.24 CPU) > Result: PASS > > This is with libnet-dns-perl 0.80.2. > > (And t/4-enterprise._o_t is not run.) > > > Lowering the severity ... > > > Cheers, > gregor > > -- > .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key > 0xBB3A68018649AA06 > : :' : Debian GNU/Linux user, admin, and developer - > http://www.debian.org/ > `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation > Europe > `- NP: Rolling Stones: Thruandthru > > Email had 1 attachment: > + signature.asc > 1k (application/pgp-signature)

-- Ondřej Surý <ondrej@sury.org> Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server