Skip Menu |

This queue is for tickets about the Math-OEIS CPAN distribution.

Report information
The Basics
Id: 97218
Status: resolved
Priority: 0/
Queue: Math-OEIS

People
Owner: Nobody in particular
Requestors: DANAJ [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 3
Fixed in: (no value)



Subject: Grep doesn't check that the stripped file exists
Trying the example for Grep, I get: $ perl -MMath::OEIS::Grep=-search,123,456,789 Can't use an undefined value as a symbol reference at /.../perlbrew/perls/perl-5.20.0/lib/site_perl/5.20.0/Math/OEIS/Grep.pm line 224. BEGIN failed--compilation aborted. This is caused by: $fh = Math::OEIS::Stripped->fh; returning undef. This happens both with and without File::Map installed. In neither case does use_mmap get set. If I put the stripped file in OEIS/stripped, then things mostly work. I believe two changes need to be made: 1) The documentation needs to be much clearer about the need to manually download the stripped file, including simple instructions using wget 2) Either Stripped or Grep needs to check whether the OEIS directory and stripped file exists, and give a clear error if so.
CC: DANAJ [...] cpan.org
Subject: Re: [rt.cpan.org #97218] Grep doesn't check that the stripped file exists
Date: Wed, 16 Jul 2014 20:50:50 +1000
To: bug-Math-OEIS [...] rt.cpan.org
From: Kevin Ryde <user42_kevin [...] yahoo.com.au>
"Dana Jacobsen via RT" <bug-Math-OEIS@rt.cpan.org> writes: Show quoted text
> > 1) The documentation needs to be much clearer about the need to > manually download the stripped file, including simple > instructions using wget > 2) Either Stripped or Grep needs to check whether the OEIS directory > and stripped file exists, and give a clear error if so.
Beaut. I uploaded a version 4 which might be a little better. I made the Grep croak on file not found. I'll try to show the nature of the problem (file not found or whatever) as well in the future.
On Wed Jul 16 06:51:34 2014, user42_kevin@yahoo.com.au wrote: Show quoted text
> "Dana Jacobsen via RT" <bug-Math-OEIS@rt.cpan.org> writes:
> > > > 1) The documentation needs to be much clearer about the need to > > manually download the stripped file, including simple > > instructions using wget > > 2) Either Stripped or Grep needs to check whether the OEIS directory > > and stripped file exists, and give a clear error if so.
> > Beaut. I uploaded a version 4 which might be a little better. I made > the Grep croak on file not found. I'll try to show the nature of the > problem (file not found or whatever) as well in the future.
Looks much nicer, thanks! I get a message abut the file not found, and Math::OEIS::Stripped shows how to get the file. I think this can be closed.