Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 97184
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: BARBIE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: metayml_has_repository_resource not validating correctly
I have tried to find this metric, but I keep seeing references to Module::CPANTS::SiteKwalitee, which doesn't exist on CPAN, so I'm guessing this bit exists there. However, the experimental metric metayml_has_repository_resource seems to be a bit unpredictable. For most of my dists this works fine, however, I had a failure recently (http://cpants.cpanauthors.org/dist/CPAN-Testers-WWW-Reports/metadata) as follows: Metadata Analyzed metadata and errors of CPAN-Testers-WWW-Reports. { ... "got_prereq_from" : "META.yml", "kwalitee" : { ... "metayml_has_repository_resource" : 0, ... }, ... "meta_yml" : { ... "resources" : { "bugtracker" : "http://rt.cpan.org/Public/Dist/Display.html?Name=CPAN-Testers-WWW-Reports", "license" : "http://www.perlfoundation.org/artistic_license_2_0", "repository" : "http://github.com/barbie/cpan-testers-www-reports" }, ... }, "metayml_is_parsable" : 1, ... "package" : "CPAN-Testers-WWW-Reports-3.49.tar.gz", ... } So the analysis shows that META,yml clearly has a resource->repository reference, but the kwalitee indicator says it doesn't. I'd try and find the bug if I knew where to look :( PS: I found Module::CPANTS::SiteKwalitee on GitHub, but this metric doesn't exist there either!
That looks like the Meta v1.4 version of repository. In v2, repository is a hash: https://metacpan.org/pod/CPAN::Meta::Spec#resources However, META.yml *is* v1.4, so the metric should find this acceptable (as long as the version is properly declared in the data structure). Is this metric using a recent version of CPAN::Meta::Validator, I wonder? On 2014-07-13 02:10:26, BARBIE wrote: Show quoted text
> I have tried to find this metric, but I keep seeing references to > Module::CPANTS::SiteKwalitee, which doesn't exist on CPAN, so I'm > guessing this bit exists there. > > However, the experimental metric metayml_has_repository_resource seems > to be a bit unpredictable. For most of my dists this works fine, > however, I had a failure recently > (http://cpants.cpanauthors.org/dist/CPAN-Testers-WWW-Reports/metadata) > as follows: > > Metadata > > Analyzed metadata and errors of CPAN-Testers-WWW-Reports. > > { > ... > > "got_prereq_from" : "META.yml", > "kwalitee" : { > ... > > "metayml_has_repository_resource" : 0, > > ... > }, > > ... > > "meta_yml" : { > ... > > "resources" : { > "bugtracker" : > "http://rt.cpan.org/Public/Dist/Display.html?Name=CPAN-Testers-WWW- > Reports", > "license" : "http://www.perlfoundation.org/artistic_license_2_0", > "repository" : "http://github.com/barbie/cpan-testers-www-reports" > }, > > ... > }, > "metayml_is_parsable" : 1, > > ... > > "package" : "CPAN-Testers-WWW-Reports-3.49.tar.gz", > > ... > } > > So the analysis shows that META,yml clearly has a resource->repository > reference, but the kwalitee indicator says it doesn't. > > I'd try and find the bug if I knew where to look :( > > PS: I found Module::CPANTS::SiteKwalitee on GitHub, but this metric > doesn't exist there either!
On Sun Jul 13 11:23:36 2014, ETHER wrote: Show quoted text
> That looks like the Meta v1.4 version of repository. In v2, repository > is a hash: > > https://metacpan.org/pod/CPAN::Meta::Spec#resources > > However, META.yml *is* v1.4, so the metric should find this acceptable > (as long as the version is properly declared in the data structure). > > Is this metric using a recent version of CPAN::Meta::Validator, I > wonder?
Except this passes for my other distributions that use this format. Either they are all wrong, or all right, not mostly right, but occasionally wrong. Note this is META.yml (v1.4) not META.json (v2): meta-spec: version: 1.4 url: http://module-build.sourceforge.net/META-spec-v1.4.html
Oops. Sorry for the mess. I must have pushed private WIP code into production by mistake. The code had a "resouces" typo, and that's the cause of the incorrectness. I pushed the fixed code into github master, and started regenerating CPANTS databases as well (which should end in a day). On Sun Jul 13 18:10:26 2014, BARBIE wrote: Show quoted text
> I have tried to find this metric, but I keep seeing references to > Module::CPANTS::SiteKwalitee, which doesn't exist on CPAN, so I'm > guessing this bit exists there. > > However, the experimental metric metayml_has_repository_resource seems > to be a bit unpredictable. For most of my dists this works fine, > however, I had a failure recently > (http://cpants.cpanauthors.org/dist/CPAN-Testers-WWW-Reports/metadata) > as follows: > > Metadata > > Analyzed metadata and errors of CPAN-Testers-WWW-Reports. > > { > ... > > "got_prereq_from" : "META.yml", > "kwalitee" : { > ... > > "metayml_has_repository_resource" : 0, > > ... > }, > > ... > > "meta_yml" : { > ... > > "resources" : { > "bugtracker" : > "http://rt.cpan.org/Public/Dist/Display.html?Name=CPAN-Testers-WWW- > Reports", > "license" : "http://www.perlfoundation.org/artistic_license_2_0", > "repository" : "http://github.com/barbie/cpan-testers-www-reports" > }, > > ... > }, > "metayml_is_parsable" : 1, > > ... > > "package" : "CPAN-Testers-WWW-Reports-3.49.tar.gz", > > ... > } > > So the analysis shows that META,yml clearly has a resource->repository > reference, but the kwalitee indicator says it doesn't. > > I'd try and find the bug if I knew where to look :( > > PS: I found Module::CPANTS::SiteKwalitee on GitHub, but this metric > doesn't exist there either!
No worries, glad it was a simple fix :) Thanks, Barbie.
Confirmed the issue has gone at the site.