Bug #97105 for Module-Info: Bleadperl v5.21.1-127-g29e61fd breaks MBARBON/Module-Info-0.35.tar.gz

Thu Jul 10 01:17:56 2014 ANDK [...] cpan.org - Ticket created

Subject:

Bleadperl v5.21.1-127-g29e61fd breaks MBARBON/Module-Info-0.35.tar.gz

Just a cross reference: https://rt.perl.org/Public/Bug/Display.html?id=122251

Thu Jul 10 10:15:18 2014 RURBAN [...] cpan.org - Correspondence added

On Thu Jul 10 01:17:56 2014, ANDK wrote: Show quoted text

> Just a cross reference: > https://rt.perl.org/Public/Bug/Display.html?id=122251

Hi Mattia, See the B::Utils upstream fix https://github.com/jbenjore/B-Utils/pull/10 What extensions do you need in B::Utils? Do you have public src repo for this somewhere? -- Reini Urban

Thu Jul 10 10:15:18 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 10 10:17:26 2014 RURBAN [...] cpan.org - Correspondence added

On Thu Jul 10 10:15:18 2014, RURBAN wrote: Show quoted text

> Do you have public src repo for this somewhere?

Found the repo, will do a pull request at gh -- Reini Urban

Thu Jul 10 10:24:18 2014 mbarbon [...] users.sourceforge.net - Correspondence added

RT-Send-CC:

NEILB [...] cpan.org

On Thu Jul 10 10:17:26 2014, RURBAN wrote: Show quoted text

> On Thu Jul 10 10:15:18 2014, RURBAN wrote:

> > Do you have public src repo for this somewhere?

> > Found the repo, will do a pull request at gh

FYI, I passed maintainership to Neil Bowers. Regards, Mattia

Thu Jul 10 13:27:53 2014 NEILB [...] cpan.org - Correspondence added

Show quoted text

> Found the repo, will do a pull request at gh

You can also find my repo on github/neilbowers. I'm visiting my Dad in hospital at the moment, but will be working on Module::Info probably at the weekend. Neil

Mon Aug 11 13:08:41 2014 ether [...] cpan.org - Correspondence added

On 2014-07-10 10:27:53, NEILB wrote: Show quoted text

> > Found the repo, will do a pull request at gh

> > You can also find my repo on github/neilbowers. > > I'm visiting my Dad in hospital at the moment, but will be working on > Module::Info probably at the weekend. > > Neil

Hi, how is this going? This distribution now fails to install on perl 5.21.2.

Mon Aug 11 13:16:33 2014 NEILB [...] cpan.org - Correspondence added

Sorry, this dropped off my mental queue. I'll try to make it one of my releases on CPAN Day! I'm stupid busy with work and other stuff this week, so not likely to happen before the weekend, I'm afraid. Neil

Mon Aug 11 13:16:34 2014 NEILB [...] cpan.org - Taken

Tue Sep 16 09:31:30 2014 KENTNL [...] cpan.org - Requestor KENTNL added

Wed Feb 11 23:51:08 2015 ANDK [...] cpan.org - Correspondence added

Note that bleadperl v5.21.8-175-gc3890f9 provides $B::OP::does_parent. Maybe adding a repository to the metadata would attract h4x0r? Regards,

Tue Mar 31 05:52:44 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-02-11 23:51:08, ANDK wrote: Show quoted text

> Note that bleadperl v5.21.8-175-gc3890f9 provides $B::OP::does_parent.

Possibly related ticket in B::Utils: https://rt.cpan.org/Ticket/Display.html?id=100251

Fri Apr 03 18:56:06 2015 ether [...] cpan.org - Cc ETHER added

Fri Jun 05 05:13:32 2015 kmx [...] cpan.org - Correspondence added

Show quoted text

> Possibly related ticket in B::Utils:
> https://rt.cpan.org/Ticket/Display.html?id=100251

It is not related to B::Utils as Module::Info keeps its own B::Utils "fork" in Module-Info-0.35/lib/B/BUtils.pm

So IMO lib/B/BUtils.pm needs to patched in a similar way as B::Utils

Like:

diff -ru Module-Info-0.35/lib/B/BUtils.pm Module-Info-0.35_patched/lib/B/BUtils.pm
--- Module-Info-0.35/lib/B/BUtils.pm    2013-09-08 14:12:29.000000000 +0200
+++ Module-Info-0.35_patched/lib/B/BUtils.pm    2015-06-05 11:01:30.531167000 +0200
@@ -214,6 +214,9 @@

 =cut

+BEGIN {
+  unless ($] >= 5.021002 and exists &B::OP::parent) {
+    eval q[
 sub B::OP::parent {
     my $target = shift;
     printf( "parent %s %s=(0x%07x)\n",
@@ -254,6 +257,20 @@
    my $start = $target;
    $result = $search->($start) and return $result while $start = $start->next;
    return $search->($start);
+}];
+  } else {
+    eval q[
+sub B::OP::_parent {
+    my $op     = shift;
+    my $parent = $op->_parent_impl( $op, "" );
+    $parent;
+}];
+  }
+  if ($] >= 5.021002) {
+    eval q[
+sub B::NULL::kids { }
+];
+  }
 }

Fri Jun 05 14:00:40 2015 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #97105] Bleadperl v5.21.1-127-g29e61fd breaks MBARBON/Module-Info-0.35.tar.gz
Date:	Fri, 5 Jun 2015 11:00:23 -0700
To:	bug-Module-Info [...] rt.cpan.org
From:	Karen Etheridge <ether [...] cpan.org>

Show quoted text

> So IMO lib/B/BUtils.pm needs to patched in a similar way as B::Utils

Is there a need for a separate implementation anymore? It would be better if it could be simply removed from this distribution. On Fri, Jun 5, 2015 at 2:13 AM, kmx via RT <bug-Module-Info@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=97105 > >

> > Possibly related ticket in B::Utils: > > https://rt.cpan.org/Ticket/Display.html?id=100251

> > It is not related to B::Utils as Module::Info keeps its own B::Utils > "fork" in > Module-Info-0.35/lib/B/BUtils.pm > > So IMO lib/B/BUtils.pm needs to patched in a similar way as B::Utils > > Like: > > diff -ru Module-Info-0.35/lib/B/BUtils.pm > Module-Info-0.35_patched/lib/B/BUtils.pm > --- Module-Info-0.35/lib/B/BUtils.pm 2013-09-08 14:12:29.000000000 +0200 > +++ Module-Info-0.35_patched/lib/B/BUtils.pm 2015-06-05 > 11:01:30.531167000 +0200 > @@ -214,6 +214,9 @@ > > =cut > > +BEGIN { > + unless ($] >= 5.021002 and exists &B::OP::parent) { > + eval q[ > sub B::OP::parent { > my $target = shift; > printf( "parent %s %s=(0x%07x)\n", > @@ -254,6 +257,20 @@ > my $start = $target; > $result = $search->($start) and return $result while $start = > $start->next; > return $search->($start); > +}]; > + } else { > + eval q[ > +sub B::OP::_parent { > + my $op = shift; > + my $parent = $op->_parent_impl( $op, "" ); > + $parent; > +}]; > + } > + if ($] >= 5.021002) { > + eval q[ > +sub B::NULL::kids { } > +]; > + } > } > >

Fri Jun 05 17:58:24 2015 NEILB [...] cpan.org - Correspondence added

Show quoted text

> Is there a need for a separate implementation anymore? It would be > better > if it could be simply removed from this distribution.

With the latest B::Utils, one Module::Info test fails. It's gonna take me a while to get my head around it to work out what the problem is, and whether it's really a problem :-) Neil

Tue Aug 25 11:08:17 2015 gregoa [...] cpan.org - Cc GREGOA added

Sat Aug 29 04:42:48 2015 SREZIC [...] cpan.org - Cc SREZIC added

Fri Sep 11 19:12:15 2015 ether [...] cpan.org - Correspondence added

On 2015-06-05 14:58:24, NEILB wrote: Show quoted text

> > Is there a need for a separate implementation anymore? It would be > > better > > if it could be simply removed from this distribution.

> > With the latest B::Utils, one Module::Info test fails. It's gonna take > me a while to get my head around it to work out what the problem is, > and whether it's really a problem :-)

Hey Neil, I understand B::Utils a *wee* bit better now.. it would be great if the overrides could be removed in this distribution. Let me know what interfaces you need that are missing?

Tue Sep 22 17:47:36 2015 NEILB [...] cpan.org - Correspondence added

Show quoted text

> Hey Neil, I understand B::Utils a *wee* bit better now.. it would be > great if > the overrides could be removed in this distribution. Let me know what > interfaces > you need that are missing?

Thanks Ether! I've got my working version nearly working with the regular B::Utils. There's one last bit which I needed to learn a bit more about B::Utils and opcodes for, which I haven't got to yet. I'll remind myself exactly what the problem is, and get back to you. Cheers!

Fri Oct 02 10:11:28 2015 gregoa [...] cpan.org - Correspondence added

Anything new here? We are about to upload Perl 5.22 to Debian/unstable soon, which means this module will have to be removed from testing first, and later from the archive completely. Any help welcome! Cheers, gregor, Debian Perl Group

Fri Oct 02 10:40:00 2015 NEILB [...] cpan.org - Correspondence added

Show quoted text

> Anything new here?

Hoping to move this forward soon. Thanks for the nudge -- I'll try and move things forward this weekend.

Fri Oct 02 11:23:52 2015 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #97105] Bleadperl v5.21.1-127-g29e61fd breaks MBARBON/Module-Info-0.35.tar.gz
Date:	Fri, 2 Oct 2015 17:23:39 +0200
To:	Neil_Bowers via RT <bug-Module-Info [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Fri, 02 Oct 2015 10:40:06 -0400, Neil_Bowers via RT wrote: Show quoted text

> > Anything new here?

> Hoping to move this forward soon. Thanks for the nudge -- I'll try and move things forward this weekend.

That's good news, thank you! Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Cássia Eller: Nos

Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

Tue Oct 13 18:45:53 2015 NEILB [...] cpan.org - Correspondence added

I've just uploaded another developer release. It passes cleanly on 5.22 for me, and still passes cleanly on 5.16.3 for me as well. So now I'll wait to see what CPAN Testers says. Thanks to ETHER for the updated version of B::Utils, which resolved one bunch of problems.

Sat Oct 24 10:11:48 2015 NEILB [...] cpan.org - Correspondence added

RT-Send-CC:

ether [...] cpan.org, gregoa [...] debian.org

Thank you -- this has finally been fixed with the 0.36 release. Thanks are due to ETHER, WOLFSAGE, and others for their help in getting this resolved.

Sat Oct 24 10:12:02 2015 NEILB [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Oct 24 10:12:03 2015 NEILB [...] cpan.org - Fixed in 0.36 added