Bug #96885 for BTRIEVE-Native: Crash due to invalid memory allocation

Hello,

We don't need sv_setpvn because data already in place.

We need SvCUR_set because dataLength after BTRCALL can be smaller then before, so we need set dataBuffer length (sv_setpvn do this in original version).

We don't need apply SvCUR_set to posBlock and keyBuffer because their length assumed to be fixed (in original version).

I investigated issue a little bit more, in my case memory error caused by following line of code:

keyBuffer  sv_setpvn((SV*)ST(4), keyBuffer , MAX_KEY_SIZE   );

In my case, length of scalar keyBuffer was less then MAX_KEY_SIZE and memory corruption occurs.

So, this is not exactly BTRIEVE::Native bug, but BTRIVE::Native is not safe and in pair with BTRIEVE::FileIO error occurs.

So, after all i suggest following changes to make BTRIEVE::Native more safe and more efficient:

short

Call( operation, posBlock, dataBuffer, dataLength, keyBuffer, keyNumber )

  unsigned short operation

  char*          posBlock

  char*          dataBuffer

  unsigned long  dataLength

  char*          keyBuffer

  short          keyNumber

  CODE:

  if ( SvCUR(ST(1)) != POS_BLOCK_SIZE ) {

      croak("posBlock length must be %d",POS_BLOCK_SIZE);

  }

  RETVAL = BTRCALL( operation, posBlock, dataBuffer, &dataLength, keyBuffer, SvCUR(ST(4)), keyNumber );

  OUTPUT:

  posBlock   ;

  dataBuffer SvCUR_set((SV*)ST(2),dataLength);

  dataLength

  keyBuffer  ;

  RETVAL

03.07.2014, 14:54, "Steffen Goeldner via RT" <bug-BTRIEVE-Native@rt.cpan.org>:

--
Илья.