Skip Menu |

This queue is for tickets about the Acme-Damn CPAN distribution.

Report information
The Basics
Id: 96872
Status: resolved
Priority: 0/
Queue: Acme-Damn

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.05
Fixed in: 0.06



Subject: Fails with bleadperl
As per subject. In the same boat: https://rt.perl.org/rt3/Ticket/Display.html?id=122031 HTH&&Thanks, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)
On Tue Jul 01 20:48:07 2014, ANDK wrote: Show quoted text
> As per subject. In the same boat: > https://rt.perl.org/rt3/Ticket/Display.html?id=122031 > > HTH&&Thanks, > (Disclaimer: this was discovered by statistical analysis, I'm not > speaking as a user)
The patch attached lets all Acme::Damn tests pass again. Tested with Perl 5.20.0. Thank you very much. Jim Keenan
Subject: 122031-96872-Damn.diff
67,68d66 < if ( SvTYPE( sv ) != SVt_PVIO ) /* if we don't have an IO stream, we */ < PL_sv_objcount--; /* should decrement the object count */
CC: ANDK [...] cpan.org
Subject: Re: [rt.cpan.org #96872] Fails with bleadperl
Date: Wed, 02 Jul 2014 08:44:27 +0200
To: bug-Acme-Damn [...] rt.cpan.org
From: Andreas Koenig <andreas.koenig.7os6VVqR [...] franz.ak.mind.de>
Show quoted text
>>>>> On Tue, 1 Jul 2014 22:00:32 -0400, "James E Keenan via RT" <bug-Acme-Damn@rt.cpan.org> said:
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=96872 > > On Tue Jul 01 20:48:07 2014, ANDK wrote:
>> As per subject. In the same boat: >> https://rt.perl.org/rt3/Ticket/Display.html?id=122031 >> >> HTH&&Thanks, >> (Disclaimer: this was discovered by statistical analysis, I'm not >> speaking as a user)
Show quoted text
> The patch attached lets all Acme::Damn tests pass again. Tested > with Perl 5.20.0.
Jim, did you intentionally omit the #if PERL_VERSION < 18 that Reini suggested in his patch and that was also deemed necessary by Nicholas in his posting http://nntp.perl.org/group/perl.perl5.porters/216599 ? Show quoted text
> Jim Keenan
Show quoted text
> 67,68d66 > < if ( SvTYPE( sv ) != SVt_PVIO ) /* if we don't have an IO stream, we */ > < PL_sv_objcount--; /* should decrement the object count */
And please, use unified diff. -- andreas
Installation is impossible on all perls in the 5.21 series: http://matrix.cpantesters.org/?dist=Acme-Damn+0.05
On Wed Jul 02 02:44:47 2014, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote: Show quoted text
> >>>>> On Tue, 1 Jul 2014 22:00:32 -0400, "James E Keenan via RT" <bug- > >>>>> Acme-Damn@rt.cpan.org> said:
>
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=96872 > > > On Tue Jul 01 20:48:07 2014, ANDK wrote:
> >> As per subject. In the same boat: > >> https://rt.perl.org/rt3/Ticket/Display.html?id=122031 > >> > >> HTH&&Thanks, > >> (Disclaimer: this was discovered by statistical analysis, I'm not > >> speaking as a user)
> >
> > The patch attached lets all Acme::Damn tests pass again. Tested > > with Perl 5.20.0.
> > Jim, did you intentionally omit the > > #if PERL_VERSION < 18 > > that Reini suggested in his patch and that was also deemed necessary > by > Nicholas in his posting > http://nntp.perl.org/group/perl.perl5.porters/216599 ? >
> > Jim Keenan
>
> > 67,68d66 > > < if ( SvTYPE( sv ) != SVt_PVIO ) /* if we don't have an IO stream, > > we */ > > < PL_sv_objcount--; /* should decrement the object > > count */
> > And please, use unified diff.
The maintainer has fixed this problem on Oct 26 2014. See: http://search.cpan.org/~ibb/Acme-Damn-0.06/ I've confirmed this: ##### $ /home/jkeenan/testing/blead/bin/perl -I/home/jkeenan/testing/blead/lib -V | head -6 Summary of my perl5 (revision 5 version 21 subversion 6) configuration: Commit id: 52ec28d5ff5fcb874bd7ffac4db0609315227668 Platform: osname=linux, osvers=3.13.0-37-generic, archname=x86_64-linux uname='linux zareason 3.13.0-37-generic #64-ubuntu smp mon sep 22 21:28:38 utc 2014 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel -Uversiononly -Dprefix=/home/jkeenan/testing/blead -Dman1dir=none -Dman3dir=none' $ /home/jkeenan/testing/blead/bin/perl -I/home/jkeenan/testing/blead/lib Makefile.PL Checking if your kit is complete... Looks good Generating a Unix-style Makefile Writing Makefile for Acme::Damn Writing MYMETA.yml and MYMETA.json $ make cp Damn.pm blib/lib/Acme/Damn.pm Running Mkbootstrap for Acme::Damn () chmod 644 Damn.bs /home/jkeenan/testing/blead/bin/perl /home/jkeenan/testing/blead/lib/perl5/5.21.6/ExtUtils/xsubpp -typemap /home/jkeenan/testing/blead/lib/perl5/5.21.6/ExtUtils/typemap Damn.xs > Damn.xsc && mv Damn.xsc Damn.c cc -c -I. -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"0.07\" -DXS_VERSION=\"0.07\" -fPIC "-I/home/jkeenan/testing/blead/lib/perl5/5.21.6/x86_64-linux/CORE" Damn.c rm -f blib/arch/auto/Acme/Damn/Damn.so cc -shared -O2 -L/usr/local/lib -fstack-protector Damn.o -o blib/arch/auto/Acme/Damn/Damn.so \ \ chmod 755 blib/arch/auto/Acme/Damn/Damn.so /home/jkeenan/testing/blead/bin/perl -MExtUtils::Command::MM -e 'cp_nonempty' -- Damn.bs blib/arch/auto/Acme/Damn/Damn.bs 644 Manifying blib/man3/Acme::Damn.0 $ make test Running Mkbootstrap for Acme::Damn () chmod 644 Damn.bs PERL_DL_NONLAZY=1 /home/jkeenan/testing/blead/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1compile.t .. ok t/2damn.t ..... ok t/3aliases.t .. ok t/4name.t ..... ok t/5bad.t ...... ok t/6bless.t .... ok All tests successful. Files=6, Tests=188, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS So this ticket can be closed (but the maintainer needs to do that). Thank you very much. Jim Keenan
Thanks for the report - am surprised this module is still being used.