| CC: | zmughal [...] cpan.org |
| Subject: | Possible problem in XS regarding overload magic |
Hello,
I was reading through the code for DDS and I came across the following in
version 2.38 [^1]:
void
SvAMAGIC_off(sv)
SV * sv
PROTOTYPE: $
CODE:
SvAMAGIC_off(sv);
void
SvAMAGIC_on(sv,klass)
SV * sv
SV * klass
PROTOTYPE: $$
CODE:
SvAMAGIC_off(sv);
The second function should probably say SvAMAGIC_on. I compiled and ran the
tests after making that change and it seems to still pass. Looking through the
RT queue, the line seems to have been added in RT#53700 [^2].
[^1]: Starting on line 778 <https://metacpan.org/source/YVES/Data-Dump-Streamer-2.38/lib/Data/Dump/Streamer.xs#L778>.
[^2]: "RT#53700: Data::Dump::Streamer breaks overload magic on perl <= 5.8.8" <https://rt.cpan.org/Ticket/Display.html?id=53700>
Cheers,
- Zaki Mughal