Bug #96827 for XML-LibXML: test style-trailing-space.t fails due to extra space in dynamically generated XS code comment line

Sun Jun 29 21:38:50 2014 jimhallsun [...] gmail.com - Ticket created

Subject:	test style-trailing-space.t fails due to extra space in dynamically generated XS code comment line
Date:	Sun, 29 Jun 2014 21:38:34 -0400
To:	bug-XML-LibXML [...] rt.cpan.org
From:	James Hall <jimhallsun [...] gmail.com>

Hi, Decided to install Test::TrailingSpace to take advantage of running style-trailing-space.t and see what the benefit is. But it seems pretty clear that no one should be able to successfully run this test because it seems the two dynamically generated .c files: - Devel.c - LibXML.c Have a line with a trailing character: /* * This file was generated automatically by ExtUtils::ParseXS version 2.21 from the * contents of Devel.xs. Do not edit this file, edit Devel.xs instead. * * ANY CHANGES MADE HERE WILL BE LOST! <—— this line has a trailing space #### * */ Here are some work arounds and/or possible paths to pursue: #1 - vim the two files prior to testing and remove the trailing space. This is what I choose but it will break automation because these files are dynamically generated. #2 - Edit t/style-trailing-space.t and change the regular expression to skip these two dynamically generated files. Example change filename_regex => qr/(?:\.(?:t|pm|pl|xs|c|h|txt|pod|PL)|README|Changes|TODO|LICENSE)\z/, to filename_regex => qr/(?:\.(?:t|pm|pl|xs|h|txt|pod|PL)|README|Changes|TODO|LICENSE)\z/, #3 - I guess you could file a bug against ExtUtils::ParseXS, but I don’t see the point. Why do you need to eliminate trailing spaces on a C comment line? You may want to consider removing this test file. Here is the error report: t/style-trailing-space.t .................. # Found trailing space in file 'Devel.c' # Found trailing space in file 'LibXML.c' t/style-trailing-space.t .................. 1/1 # Failed test 'No trailing space was found.' # at t/style-trailing-space.t line 28. # got: '2' # expected: '0' # Looks like you failed 1 test of 1. t/style-trailing-space.t .................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/style-trailing-space.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=70, Tests=2559, 10 wallclock secs ( 0.56 usr 0.27 sys + 6.78 cusr 1.61 csys = 9.22 CPU) Result: FAIL Failed 1/70 test programs. 1/2559 subtests failed. *** Error code 1 make: Fatal error: Command failed for target `test_dynamic' SHLOMIF/XML-LibXML-2.0116.tar.gz make test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports SHLOMIF/XML-LibXML-2.0116.tar.gz Failed during this command: SHLOMIF/XML-LibXML-2.0116.tar.gz : make_test NO

Sun Jun 29 22:03:29 2014 jimhallsun [...] gmail.com - Correspondence added

Subject:	[rt.cpan.org #96827] Re: test read-write.t fails for some reason
Date:	Sun, 29 Jun 2014 22:03:15 -0400
To:	bug-IO-Pty-Easy [...] rt.cpan.org
From:	James Hall <jimhallsun [...] gmail.com>

FYI — I commented out line 24: # $pty->write('a'x(1024*1024)); And the test runs successfully. Wondering if there is another way to write this? Everything else works…. JIM

Thu Jul 03 16:00:40 2014 SHLOMIF [...] cpan.org - Correspondence added

On Sun Jun 29 21:38:50 2014, jimhallsun@gmail.com wrote: Show quoted text

> Hi, > > Decided to install Test::TrailingSpace to take advantage of running > style-trailing-space.t and see what the benefit is. But it seems > pretty clear that no one should be able to successfully run this test > because it seems the two dynamically generated .c files: > > - Devel.c > - LibXML.c > > Have a line with a trailing character: > > /* > * This file was generated automatically by ExtUtils::ParseXS version > 2.21 from the > * contents of Devel.xs. Do not edit this file, edit Devel.xs instead. > *

There's already ExtUtils::ParseXS version 3.24 - please upgrade and try again. It works fine here (perl-5.20.0). Regards, -- Shlomi Fish Show quoted text

> * ANY CHANGES MADE HERE WILL BE LOST! <—— this line has a > trailing space #### > * > */ > > Here are some work arounds and/or possible paths to pursue: > > #1 - vim the two files prior to testing and remove the trailing space. > This is what I choose but it will break automation because these files > are dynamically generated. > > #2 - Edit t/style-trailing-space.t and change the regular expression > to skip these two dynamically generated files. Example change > > filename_regex => > qr/(?:\.(?:t|pm|pl|xs|c|h|txt|pod|PL)|README|Changes|TODO|LICENSE)\z/, > > to > > filename_regex => > qr/(?:\.(?:t|pm|pl|xs|h|txt|pod|PL)|README|Changes|TODO|LICENSE)\z/, > > #3 - I guess you could file a bug against ExtUtils::ParseXS, but I > don’t see the point. Why do you need to eliminate trailing spaces on a > C comment line? You may want to consider removing this test file. > > Here is the error report: > > t/style-trailing-space.t .................. # Found trailing space in > file 'Devel.c' > # Found trailing space in file 'LibXML.c' > t/style-trailing-space.t .................. 1/1 > # Failed test 'No trailing space was found.' > # at t/style-trailing-space.t line 28. > # got: '2' > # expected: '0' > # Looks like you failed 1 test of 1. > t/style-trailing-space.t .................. Dubious, test returned 1 > (wstat 256, 0x100) > Failed 1/1 subtests > > Test Summary Report > ------------------- > t/style-trailing-space.t (Wstat: 256 Tests: 1 Failed: > 1) > Failed test: 1 > Non-zero exit status: 1 > Files=70, Tests=2559, 10 wallclock secs ( 0.56 usr 0.27 sys + 6.78 > cusr 1.61 csys = 9.22 CPU) > Result: FAIL > Failed 1/70 test programs. 1/2559 subtests failed. > *** Error code 1 > make: Fatal error: Command failed for target `test_dynamic' > SHLOMIF/XML-LibXML-2.0116.tar.gz > make test -- NOT OK > //hint// to see the cpan-testers results for installing this module, > try: > reports SHLOMIF/XML-LibXML-2.0116.tar.gz > Failed during this command: > SHLOMIF/XML-LibXML-2.0116.tar.gz : make_test NO

Thu Jul 03 16:00:41 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 03 16:00:42 2014 SHLOMIF [...] cpan.org - Status changed from 'open' to 'rejected'

Fri Jul 04 13:02:30 2014 jimhallsun [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #96827] test style-trailing-space.t fails due to extra space in dynamically generated XS code comment line
Date:	Fri, 4 Jul 2014 13:02:17 -0400
To:	bug-XML-LibXML [...] rt.cpan.org
From:	Jim Hall <jimhallsun [...] gmail.com>

That did it! Thanks, JIM On Thu, Jul 3, 2014 at 4:00 PM, Shlomi Fish via RT < bug-XML-LibXML@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=96827 > > > On Sun Jun 29 21:38:50 2014, jimhallsun@gmail.com wrote:

> > Hi, > > > > Decided to install Test::TrailingSpace to take advantage of running > > style-trailing-space.t and see what the benefit is. But it seems > > pretty clear that no one should be able to successfully run this test > > because it seems the two dynamically generated .c files: > > > > - Devel.c > > - LibXML.c > > > > Have a line with a trailing character: > > > > /* > > * This file was generated automatically by ExtUtils::ParseXS version > > 2.21 from the > > * contents of Devel.xs. Do not edit this file, edit Devel.xs instead. > > *

> > There's already ExtUtils::ParseXS version 3.24 - please upgrade and try > again. It works fine here (perl-5.20.0). > > Regards, > > -- Shlomi Fish >

> > * ANY CHANGES MADE HERE WILL BE LOST! <—— this line has a > > trailing space #### > > * > > */ > > > > Here are some work arounds and/or possible paths to pursue: > > > > #1 - vim the two files prior to testing and remove the trailing space. > > This is what I choose but it will break automation because these files > > are dynamically generated. > > > > #2 - Edit t/style-trailing-space.t and change the regular expression > > to skip these two dynamically generated files. Example change > > > > filename_regex => > > qr/(?:\.(?:t|pm|pl|xs|c|h|txt|pod|PL)|README|Changes|TODO|LICENSE)\z/, > > > > to > > > > filename_regex => > > qr/(?:\.(?:t|pm|pl|xs|h|txt|pod|PL)|README|Changes|TODO|LICENSE)\z/, > > > > #3 - I guess you could file a bug against ExtUtils::ParseXS, but I > > don’t see the point. Why do you need to eliminate trailing spaces on a > > C comment line? You may want to consider removing this test file. > > > > Here is the error report: > > > > t/style-trailing-space.t .................. # Found trailing space in > > file 'Devel.c' > > # Found trailing space in file 'LibXML.c' > > t/style-trailing-space.t .................. 1/1 > > # Failed test 'No trailing space was found.' > > # at t/style-trailing-space.t line 28. > > # got: '2' > > # expected: '0' > > # Looks like you failed 1 test of 1. > > t/style-trailing-space.t .................. Dubious, test returned 1 > > (wstat 256, 0x100) > > Failed 1/1 subtests > > > > Test Summary Report > > ------------------- > > t/style-trailing-space.t (Wstat: 256 Tests: 1 Failed: > > 1) > > Failed test: 1 > > Non-zero exit status: 1 > > Files=70, Tests=2559, 10 wallclock secs ( 0.56 usr 0.27 sys + 6.78 > > cusr 1.61 csys = 9.22 CPU) > > Result: FAIL > > Failed 1/70 test programs. 1/2559 subtests failed. > > *** Error code 1 > > make: Fatal error: Command failed for target `test_dynamic' > > SHLOMIF/XML-LibXML-2.0116.tar.gz > > make test -- NOT OK > > //hint// to see the cpan-testers results for installing this module, > > try: > > reports SHLOMIF/XML-LibXML-2.0116.tar.gz > > Failed during this command: > > SHLOMIF/XML-LibXML-2.0116.tar.gz : make_test NO

> > > >